[Akonadi] [Bug 364005] ASSERT: "!mReadingFinished" when composing a message

2016-06-18 Thread Christophe Giboudeaux via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364005

--- Comment #4 from Christophe Giboudeaux  ---
false alarm, deleting the whole build dir helped.

-- 
You are receiving this mail because:
You are watching all bug changes.


[Akonadi] [Bug 364005] ASSERT: "!mReadingFinished" when composing a message

2016-06-18 Thread Christophe Giboudeaux via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364005

--- Comment #3 from Christophe Giboudeaux  ---
Well, it still crashes with the same bt:

#7  0x7f4306756f1e in qt_assert(char const*, char const*, int)
(assertion=, file=, line=) at
global/qglobal.cpp:2999
#8  0x7f42ff57bc58 in Akonadi::JobPrivate::handleResponse(long long,
Akonadi::Protocol::Command const&) (this=0x479a660, tag=12, response=...) at
/kde/src/5/akonadiserver/src/core/jobs/job.cpp:69
#9  0x7f42ff53d5d8 in Akonadi::SessionPrivate::handleCommand(long long,
Akonadi::Protocol::Command const&) (this=0x3c483d0, tag=12, cmd=...) at
/kde/src/5/akonadiserver/src/core/session.cpp:143
#10 0x7f42ff53f2c3 in Akonadi::Session::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) (_o=0x3c359d0,
_c=QMetaObject::InvokeMetaMethod, _id=4, _a=0x7f425800cac0) at
/kde/build/5/akonadiserver/src/core/moc_session.cpp:117

-- 
You are receiving this mail because:
You are watching all bug changes.


[Akonadi] [Bug 364005] ASSERT: "!mReadingFinished" when composing a message

2016-06-18 Thread Daniel Vrátil via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364005

Daniel Vrátil  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/akon
   ||adi/d5c6a12a10dbe58384676a8
   ||777c871c1bebc1744
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Daniel Vrátil  ---
Git commit d5c6a12a10dbe58384676a8777c871c1bebc1744 by Daniel Vrátil.
Committed on 18/06/2016 at 10:33.
Pushed by dvratil into branch 'master'.

Session: connect to KJob::finished() rather than result()

KJob::result() is not emitted when job is killed quietly which prevents
Session from scheduling the next job until the killed job is destroyed.
This leads to responses being delivered to a wrong job when the job is
killed.
CCMAIL: fa...@kde.org

M  +2-0src/core/jobs/job.cpp
M  +1-1src/core/session.cpp

http://commits.kde.org/akonadi/d5c6a12a10dbe58384676a8777c871c1bebc1744

-- 
You are receiving this mail because:
You are watching all bug changes.

[Akonadi] [Bug 364005] ASSERT: "!mReadingFinished" when composing a message

2016-06-15 Thread Daniel Vrátil via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364005

Daniel Vrátil  changed:

   What|Removed |Added

 CC||dvra...@kde.org

--- Comment #1 from Daniel Vrátil  ---
Yeah, this were a bugs we were trying to debug with dfaure - sometimes a job
was getting response that belonged to previous job which has ended, or has
signaled that it has ended and then another response arrived and the job
emitted another signal.

The assert helped us catch all the broken jobs and bugs in Job handling. The
last issue that triggers the assert is when a job is manually killed and the
session is restarted - which is exactly what happens in the completion code in
composer when you type fast enough so the composer kills the running
ContactSearchJob and starts a new one. I'm still trying to figure out how to
properly handle that, for now please just comment-out the Q_ASSERT.

-- 
You are receiving this mail because:
You are watching all bug changes.