[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Nate Graham changed: What|Removed |Added CC||rich.addis...@gmail.com --- Comment #7 from Nate Graham --- *** Bug 396284 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Nate Graham changed: What|Removed |Added CC||pedrosilva...@gmail.com --- Comment #6 from Nate Graham --- *** Bug 390625 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Nate Graham changed: What|Removed |Added Version Fixed In||5.15.0 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/bre ||eze-gtk/6ec73bf0693821ffda1 ||ea262e8b7c162242dc495 Status|CONFIRMED |RESOLVED --- Comment #5 from Nate Graham --- Git commit 6ec73bf0693821ffda1ea262e8b7c162242dc495 by Nate Graham, on behalf of Matthias Groß. Committed on 31/10/2018 at 18:39. Pushed by ngraham into branch 'master'. share common values for both Breeze and Breeze-dark GTK themes Summary: As described in bug #396091, the Breeze-dark theme is often neglected in updates. This patch fixes #396091 and some additional, related inconsistencies, enables sharing the basic stuff like shape, size, style, etc. of components in a common single css file while keeping the colour definitions separated from that in different files for both the light and dark theme. This allows easier changes, easier maintenance because of less LOC, less duplicate code as well as easier extensibility for potential additional colour schemes like [[ https://hig.kde.org/style/color/light.html | light ]] or [[ https://hig.kde.org/style/color/high.html | high-contrast ]]. I only did this for GTK 3.20 for now. If you like the effort, it could (and maybe should) get extended to other versions. Further potential steps in the same direction of saving code would be going back to SASS, which is used by many other popular GTK themes and was used by Breeze-gtk as well in the past. The only downside of that is that the SASS source files would have to be "compiled" to CSS prior to packaging. Test Plan: I don't know of any automated test suites comparing UI components. I have already posted screenshots in the original bug report and can post additional ones of the new state for comparison. Apart from that, my manual sparse testing makes me feel the dark GTK theme looks and feels much more consistent to Breeze now. Reviewers: jackg, #breeze, #plasma, ngraham Reviewed By: #breeze, ngraham Subscribers: grmat, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D16365 M +60 -3707 Breeze-dark-gtk/gtk-3.20/gtk.css C +0-122 Breeze-gtk/gtk-3.20/common.css [from: Breeze-gtk/gtk-3.20/gtk.css - 097% similarity] M +1-3692 Breeze-gtk/gtk-3.20/gtk.css https://commits.kde.org/breeze-gtk/6ec73bf0693821ffda1ea262e8b7c162242dc495 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 --- Comment #4 from gr...@sub.red --- I've posted the related D15786 in phabricator. If this change gets rejected, I can also offer an alternative manual patch, making the dark theme catching up with commit 01a86601804222929441c0c1c8bb0db6d4ee2769 and others. However, I'd prefer the first approach since it saves time now and in the future. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 --- Comment #3 from Nate Graham --- Not at all an inappropriate venue! ...Especially if you plan to submit patches. :) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 --- Comment #2 from gr...@sub.red --- > The differences between breeze-gtk and breeze-gtk-dark are likely a simple > omission, the result of forgetting to update the dark variant. Oops. That's what I thought. And that's why I also think that the code base should be reduced. There is no point in duplicating all the code for the dark theme if you could just share the basic stuff like layout, size, shape, ... and then only swap colours, is it? > Let me know what I can do to help you get started! Thanks, I've already done my first submission via Phabricator in the last days. However, I have some additional suggestions. One is that many GTK+ themes are using Sass, which offers additional functionality over CSS like variables, some math and easier nesting/inheritage. Sass needs less code and can be compiled to CSS afterwards, so it's easier to maintain. It would also be possible to replace GTK's own extensions, for example use variables which get replaced at CSS creation time rather than GTK's @define-color, which resides in the CSS. This would bring the opportunity to re-use the CSS on the web, if that's a use-case, I don't know. But to me it looks like some newer KDE web pages are using a Breeze-ish design. But I'm not sure this is the right place to discuss any of this? -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 396091] Scrollbar appearance inconsistent in between Breeze themes
https://bugs.kde.org/show_bug.cgi?id=396091 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Nate Graham --- The differences between breeze-gtk and breeze-gtk-dark are likely a simple omission, the result of forgetting to update the dark variant. Oops. Please feel free to get involved. We would be *thrilled* to have some help here! We use Phabricator to submit patches, and here's the documentation: https://community.kde.org/Infrastructure/Phabricator Let me know what I can do to help you get started! -- You are receiving this mail because: You are watching all bug changes.
