[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Nate Graham changed: What|Removed |Added Version Fixed In||5.20 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Carson Black changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/breeze-gtk/commit/9c1f7f ||52867747d1dcb304ca31eabbdbb ||53ec60f --- Comment #9 from Carson Black --- Git commit 9c1f7f52867747d1dcb304ca31eabbdbb53ec60f by Carson Black. Committed on 03/08/2020 at 21:33. Pushed by cblack into branch 'master'. Fix GTK Assistant styles to be legible M +1-0src/gtk3/gtk.scss A +24 -0src/gtk3/widgets/_assistant.scss M +0-19 src/gtk3/widgets/_base.scss https://invent.kde.org/plasma/breeze-gtk/commit/9c1f7f52867747d1dcb304ca31eabbdbb53ec60f -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/6 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866
--- Comment #7 from Michael Weghorn ---
(In reply to Michael Weghorn from comment #5)
> Created attachment 129666 [details]
> [...]
> (Not sure whether the fact that the unused part of the sidebar is still
> black is another issue, IMHO this at least looks a bit weird...)
This seems to come from those lines just a few lines above, also can be seen in
Ilhan's comment 4:
> assistant .sidebar {
> background-color: @theme_fg_color;
or, as it is in current master (with "@theme_text_color" instead of
"theme_fg_color"):
https://invent.kde.org/plasma/breeze-gtk/-/blob/84530aee0955d5bfb561ae6267c847cd544d6084/src/gtk3/widgets/_base.scss#L203
Maybe that's intended, to have a certain contrast? I'm not a designer, and
don't know much about the topic...
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 --- Comment #6 from Michael Weghorn --- Created attachment 129667 --> https://bugs.kde.org/attachment.cgi?id=129667=edit Screenshot LibreOffice-internal mail merge wizard (with modification from comment 4) (This is with breeze-gtk-theme 5.17.5-2 from Debian testing and the modification mentioned in comment 4 manually applied.) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 --- Comment #5 from Michael Weghorn --- Created attachment 129666 --> https://bugs.kde.org/attachment.cgi?id=129666=edit Screenshot LibreOffice-internal mail merge wizard (before) The same can be seen with LibreOffice's own mail merge dialog when using the gtk3 VCL plugin: * start LibreOffice Writer, using gtk3 VCL plugin: SAL_USE_VCLPLUGIN=gtk3 libreoffice --writer * start mail merge dialog via "Tools" -> "Mail Merge Wizard" Attached the screenshot without the extra line. I can confirm that adding the line as mentioned in comment 4 makes the non-active entries visible like in Ilhan's example. (Not sure whether the fact that the unused part of the sidebar is still black is another issue, IMHO this at least looks a bit weird...) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866
--- Comment #4 from Ilhan Yesil ---
This is a german extension for libreoffice, so I can't provide a translation.
In this example, the third selection has three items.
I've take a look in /usr/share/themes/Breeze/gtk-3.20/gtk.css:
If I add one line, I've a correct display:
assistant .sidebar {
background-color: @theme_fg_color;
border-top: 1px solid @borders; }
assistant .sidebar:backdrop {
background-color: @theme_fg_color;
border-color: @borders; }
assistant.csd .sidebar {
border-top-style: none; }
assistant .sidebar label {
padding: 6px 12px;
background-color: @theme_bg_color; << added line
}
assistant .sidebar label.highlight {
background-color: @extra_dull_borders; }
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 --- Comment #3 from Ilhan Yesil --- Created attachment 129660 --> https://bugs.kde.org/attachment.cgi?id=129660=edit Text can be seen if background color is set -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 --- Comment #2 from Ilhan Yesil --- Created attachment 129659 --> https://bugs.kde.org/attachment.cgi?id=129659=edit Text overlapped with black background -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #1 from Nate Graham --- A screenshot would be very helpful. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 422866] In GtkAssistant's left sidebar, normal text is overlapped by black foreground
https://bugs.kde.org/show_bug.cgi?id=422866 Ilhan Yesil changed: What|Removed |Added OS|Other |Linux -- You are receiving this mail because: You are watching all bug changes.
