[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 --- Comment #7 from Janek Bevendorff --- Thanks. I know this request is a bit strange perhaps, so thank you for removing the icons regardless. I love the Breeze theme in general, but the KeePassXC icons didn't quite transport the visuals of our branding. I wouldn't know that we are actively setting IconThemePath anywhere. If anything, it's Qt doing that under the hood. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 Nicolas Fella changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/breeze-icons/commit/ ||0ee909f19e86811f94df2a72f17 ||d73f317a9cbfd --- Comment #6 from Nicolas Fella --- Git commit 0ee909f19e86811f94df2a72f17d73f317a9cbfd by Nicolas Fella. Committed on 17/01/2021 at 21:03. Pushed by nicolasfella into branch 'master'. Remove KeePassXC icons Upstream asked us to remove those. D +0-36 icons-dark/apps/48/keepassxc.svg D +0-15 icons-dark/status/22/keepassxc-locked.svg D +0-1icons-dark/status/22/keepassxc-monochrome-dark-locked.svg D +0-1icons-dark/status/22/keepassxc-monochrome-dark.svg D +0-8icons-dark/status/22/keepassxc-unlocked.svg D +0-36 icons/apps/48/keepassxc.svg D +0-15 icons/status/22/keepassxc-locked.svg D +0-1icons/status/22/keepassxc-monochrome-light-locked.svg D +0-1icons/status/22/keepassxc-monochrome-light.svg D +0-8icons/status/22/keepassxc-unlocked.svg https://invent.kde.org/frameworks/breeze-icons/commit/0ee909f19e86811f94df2a72f17d73f317a9cbfd -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 --- Comment #5 from David Redondo --- > Icons within the application are no problem. But this is about the launcher > and tray icons, which are taken from the system theme no matter what. > FWIW I looked into the tray and saw that you set the "IconThemePath" property which is not specified but wildly used. There was an attempt to specify it and you can find emails proposing it by googling. The Plasma code for that makes a bunch of assumptions about the structure of the icon theme you pass which I think do not fit your icon folder. I am not sure who is wrong here. See https://invent.kde.org/plasma/plasma-workspace/-/blob/master/dataengines/statusnotifieritem/statusnotifieritemsource.cpp#L233 Of course this doesn't matter with the above MR :) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 --- Comment #4 from Janek Bevendorff --- > I'm confused about this request. If you want to enforce the use of your > upstream icons, you should be able to do that without any help from us. As > far as I know, we do not force apps to use breeze-icons. Icons within the application are no problem. But this is about the launcher and tray icons, which are taken from the system theme no matter what. > A possibly relevant merge request was started @ > https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/74 Thanks -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/74 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 Noah Davis changed: What|Removed |Added CC||noaha...@gmail.com --- Comment #2 from Noah Davis --- The icons that are currently in the breeze theme follow the patterns of existing breeze icons. When you're making pixel aligned 16x16 icon (with 2px margins, effectively 12x12) or 22x22 icons (with 3px margins, effectively 16x16), you usually can't stay completely true to the original proportions. If you try to shrink your upstream monochrome icons down to 16x16 or 22x22, you'll see that your pixel alignment is not as good and the margins do not match breeze icons. I'm confused about this request. If you want to enforce the use of your upstream icons, you should be able to do that without any help from us. As far as I know, we do not force apps to use breeze-icons. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 431593] Please redesign or remove KeePassXC icons
https://bugs.kde.org/show_bug.cgi?id=431593 David Redondo changed: What|Removed |Added CC||k...@david-redondo.de --- Comment #1 from David Redondo --- Not knowing anything about keepasxc or wanting to comment on the actual issue here: How are you "trying not to allow custom overrides for our icons, but Plasma seems to be ignoring that request and shows the Breeze overrides anyway.?" -- You are receiving this mail because: You are watching all bug changes.
