[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.25 Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/breeze-gtk/commit/7be4c0 |ma/breeze-gtk/commit/dcd699 |4e4dca2ba61b5822d8d50b7d3ee |bcd994acf6cda8f741850d0fed3 |3a87702 |d37cffb Status|ASSIGNED|RESOLVED --- Comment #18 from Nate Graham --- Git commit dcd699bcd994acf6cda8f741850d0fed3d37cffb by Nate Graham, on behalf of Janet Blackquill. Committed on 28/02/2022 at 16:13. Pushed by ngraham into branch 'master'. gtk3, gtk4: shrink padding of menus by 1px FIXED-IN: 5.25 M +1-1src/gtk3/widgets/_menus.scss M +1-1src/gtk4/widgets/_menus.scss https://invent.kde.org/plasma/breeze-gtk/commit/dcd699bcd994acf6cda8f741850d0fed3d37cffb -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #17 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/45 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Severity|normal |minor Priority|HI |NOR -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #16 from Nate Graham --- You can check out the last commit that attempted to fix it: https://invent.kde.org/plasma/breeze-gtk/commit/7be4c04e4dca2ba61b5822d8d50b7d3ee3a87702 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #15 from gsbhasi...@gmail.com --- Sorry for creating a duplicate bug, I was not able to find it previously reported. I'm happy to play around and attempt to create a PR, but I'm not sure how the Breeze GTK build system works. If I get the time, I'll try taking a look over the weekend -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Status|RESOLVED|REPORTED Priority|VHI |HI Resolution|FIXED |--- Version Fixed In|5.21.3 | Ever confirmed|1 |0 --- Comment #14 from Nate Graham --- Re-opening since apparently they are still not the same height. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added CC||gsbhasi...@gmail.com --- Comment #13 from Nate Graham --- *** Bug 435126 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #12 from ConteZero --- The bug is not fixed, I've tested on openSUSE Tumbleweed and Plasma 5.21.3 and menu items in gtk3 applications have greater heights than QT ones. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #11 from ConteZero --- Maybe I'm wrong, but it seems to me that the merge request changes the horizontal padding and not the vertical one. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Version Fixed In||5.21.3 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/breeze-gtk/commit/538055 |ma/breeze-gtk/commit/7be4c0 |e9f560b85e4a9aaac1242442b49 |4e4dca2ba61b5822d8d50b7d3ee |2d2a339 |3a87702 --- Comment #10 from Nate Graham --- Git commit 7be4c04e4dca2ba61b5822d8d50b7d3ee3a87702 by Nate Graham, on behalf of Jan Blackquill. Committed on 05/03/2021 at 16:20. Pushed by ngraham into branch 'Plasma/5.21'. Adjust menu heights to properly match Breeze QStyle, second time Looks like the menu height got adjusted again. (cherry picked from commit 538055e9f560b85e4a9aaac1242442b492d2a339) M +1-1src/gtk3/widgets/_menus.scss M +1-1src/gtk4/widgets/_menus.scss https://invent.kde.org/plasma/breeze-gtk/commit/7be4c04e4dca2ba61b5822d8d50b7d3ee3a87702 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/breeze-gtk/commit/538055 ||e9f560b85e4a9aaac1242442b49 ||2d2a339 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #9 from Nate Graham --- Git commit 538055e9f560b85e4a9aaac1242442b492d2a339 by Nate Graham, on behalf of Jan Blackquill. Committed on 05/03/2021 at 16:13. Pushed by ngraham into branch 'master'. Adjust menu heights to properly match Breeze QStyle, second time Looks like the menu height got adjusted again. M +1-1src/gtk3/widgets/_menus.scss M +1-1src/gtk4/widgets/_menus.scss https://invent.kde.org/plasma/breeze-gtk/commit/538055e9f560b85e4a9aaac1242442b492d2a339 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/16 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #7 from Nate Graham --- Can you submit those changes in a merge request so everyone else can benefit from them? -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158
--- Comment #6 from ConteZero ---
I've done some changes to the gtk.css code:
menubar > menuitem, .menubar > menuitem {
padding: 4px 6px 5px 6px; }
menu menuitem, .menu menuitem {
padding: 4px 4px 5px 4px; }
modelbutton.flat, popover.background checkbutton.flat,
popover.background radiobutton.flat,
.menuitem.button.flat,
button.button.sidebar-button,
notebook > header > tabs > arrow.button,
popover.background checkbutton.button,
popover.background radiobutton.button {
padding: 4px 8px 5px 8px; }
Now it uses asymmetric vertical padding and with this config I have a perfect
match between gtk3 and QT menu items height.
It might be useful if someone else could give it a try.
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #5 from Nate Graham --- Would you like to submit a merge request to fix it? Seems like you've already done most of the work. https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/ -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158
--- Comment #4 from ConteZero ---
I think it's related to changes referenced on
https://bugs.kde.org/show_bug.cgi?id=431819
As a temporary workaround I've added these lines on ~/.config/gtk-3.0/gtk.css
menubar > menuitem, .menubar > menuitem {
padding: 5px 6px; }
menu menuitem, .menu menuitem {
padding: 5px 4px; }
modelbutton.flat, popover.background checkbutton.flat,
popover.background radiobutton.flat,
.menuitem.button.flat,
button.button.sidebar-button,
notebook > header > tabs > arrow.button,
popover.background checkbutton.button,
popover.background radiobutton.button {
padding: 5px 8px; }
With this config the gtk3 menu items are only slightly taller (1 pixel), if I
use a 4px vertical padding then the menu items are slightly shorter (1 pixel).
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Priority|HI |VHI --- Comment #3 from Nate Graham --- Jan, can you please take a look? Thanks! -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added CC||model...@outlook.com.au --- Comment #2 from Nate Graham --- *** Bug 433687 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 --- Comment #1 from ConteZero --- I can confirm the bug on openSUSE Tumbleweed and Plasma 5.21.0 It affect all gtk3 applications that I've tested: Firefox, Thunderbird, Eclipse, Libreoffice, Handbrake. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 ConteZero changed: What|Removed |Added CC||contez...@technet.it -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 433158] Different menu item height between breeze and breeze-gtk
https://bugs.kde.org/show_bug.cgi?id=433158 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 CC||n...@kde.org Priority|NOR |HI Keywords||regression Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
