[Discover] [Bug 383036] version field on from-file installation broken

2017-08-03 Thread Aleix Pol 
https://bugs.kde.org/show_bug.cgi?id=383036

Aleix Pol  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dis
   ||cover/0a39fce84ac421d5875d7
   ||a182bc44394389a0457
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Aleix Pol  ---
Git commit 0a39fce84ac421d5875d7a182bc44394389a0457 by Aleix Pol.
Committed on 03/08/2017 at 10:53.
Pushed by apol into branch 'Plasma/5.10'.

Don't show the version if there's none on the ApplicationPage

Also removes fix that didn't seem to work for Harald.

M  +3-1discover/qml/ApplicationPage.qml
M  +0-1libdiscover/backends/PackageKitBackend/LocalFilePKResource.h

https://commits.kde.org/discover/0a39fce84ac421d5875d7a182bc44394389a0457

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 383036] version field on from-file installation broken

2017-08-03 Thread Aleix Pol 
https://bugs.kde.org/show_bug.cgi?id=383036

Aleix Pol  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dis
   ||cover/0a39fce84ac421d5875d7
   ||a182bc44394389a0457
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Aleix Pol  ---
Git commit 0a39fce84ac421d5875d7a182bc44394389a0457 by Aleix Pol.
Committed on 03/08/2017 at 10:53.
Pushed by apol into branch 'Plasma/5.10'.

Don't show the version if there's none on the ApplicationPage

Also removes fix that didn't seem to work for Harald.

M  +3-1discover/qml/ApplicationPage.qml
M  +0-1libdiscover/backends/PackageKitBackend/LocalFilePKResource.h

https://commits.kde.org/discover/0a39fce84ac421d5875d7a182bc44394389a0457

--- Comment #3 from Aleix Pol  ---
Git commit a33e952d4f91a02a01e4211f5e02f38d6198c89e by Aleix Pol.
Committed on 03/08/2017 at 11:00.
Pushed by apol into branch 'Plasma/5.10'.

Make it possible to prevent some resources from being Reviewed

Sometimes it just doesn't make sense

M  +1-1discover/qml/ApplicationPage.qml
M  +2-0libdiscover/ReviewsBackend/AbstractReviewsBackend.h
M  +5-0libdiscover/appstream/OdrsReviewsBackend.cpp
M  +1-0libdiscover/appstream/OdrsReviewsBackend.h
M  +5-0libdiscover/backends/DummyBackend/DummyReviewsBackend.cpp
M  +1-0libdiscover/backends/DummyBackend/DummyReviewsBackend.h
M  +5-0libdiscover/backends/KNSBackend/KNSReviews.cpp
M  +1-0libdiscover/backends/KNSBackend/KNSReviews.h
M  +5-0libdiscover/backends/SnapBackend/SnapReviewsBackend.cpp
M  +1-0libdiscover/backends/SnapBackend/SnapReviewsBackend.h

https://commits.kde.org/discover/a33e952d4f91a02a01e4211f5e02f38d6198c89e

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 383036] version field on from-file installation broken

2017-08-02 Thread Harald Sitter 
https://bugs.kde.org/show_bug.cgi?id=383036

--- Comment #1 from Harald Sitter  ---
(also why does from-file install have a 'Review' ability? :O)

-- 
You are receiving this mail because:
You are watching all bug changes.