[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #24 from Nate Graham  ---
I see you filed Bug 396149; thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #23 from Nate Graham  ---
Thanks for finding this issue!

Since the bug report you're commenting on was tracking the implementation of
the feature itself, and because that feature was indeed implemented and mostly
works, I'd prefer a new bug report to track the issue you've discovered. Would
you mind filing it? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[PK]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #22 from PK  ---
Created attachment 113696
  --> https://bugs.kde.org/attachment.cgi?id=113696=edit
discover uses stange icon for kolourpaint

Discover now respects my installed and preferred icon theme! Great! Only, for
the appliction KolourPaint discover chooses an icon that is not in my preferred
theme. I did "locate kolourpaint.svg" and I found the icon that Discover uses
in the folder /usr/share/icons/hycolor. So I renamed that folder, deleted the
cache, rebooted and still discover uses this icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[PK]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #21 from PK  ---
Oh, great! Thank you for your answer Nate...

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.13

--- Comment #20 from Nate Graham  ---
This feature will land in KDE Plasma 5.13, which hasn't been released yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[PK]

https://bugs.kde.org/show_bug.cgi?id=388261

PK  changed:

   What|Removed |Added

 CC||pieterkristen...@gmail.com

--- Comment #19 from PK  ---
When am I supposed to see my system icon-theme in plasma discover? It is end
May and I don't think it has happened already. 
Or, " the icon name is (not) offered in the metadata"... Would that be a common
thing? I am using Neon User edition.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #18 from Andrew Crouthamel  ---
Fair enough, I didn't realize they still don't provide appstream. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #17 from Aleix Pol  ---
Not snap yet, as snap doesn't support appstream information just yet. On snap
we show the icon the devs uploaded to the store.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #16 from Andrew Crouthamel  ---
Very cool, does this work for all three package methods? (distro, snap,
flatpak)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=388261

Aleix Pol  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dis
   ||cover/7b3e6de68efaeefa9eb9c
   ||b2ffe0fa8c443091202
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #15 from Aleix Pol  ---
Git commit 7b3e6de68efaeefa9eb9cb2ffe0fa8c443091202 by Aleix Pol.
Committed on 05/04/2018 at 00:20.
Pushed by apol into branch 'master'.

Prefer the icon from the local theme to upstream's

Overrides the project's icon by the one in the icon theme, provided the
icon
name is offered in the metadata.

M  +5-7libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +5-9libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp

https://commits.kde.org/discover/7b3e6de68efaeefa9eb9cb2ffe0fa8c443091202

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Andres Betts]

https://bugs.kde.org/show_bug.cgi?id=388261

Andres Betts  changed:

   What|Removed |Added

 CC||anditosan1...@gmail.com

--- Comment #14 from Andres Betts  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388261

f.alexander.wi...@gmail.com changed:

   What|Removed |Added

 CC||f.alexander.wi...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Igor Serwin]

https://bugs.kde.org/show_bug.cgi?id=388261

Igor Serwin  changed:

   What|Removed |Added

 CC||serwini...@gmail.com

--- Comment #13 from Igor Serwin  ---
I strongly agree with this suggestion. With this one change few issues will be
easily solved,problems with low res icon's and problem with inconsistent look
will disappear. Those two are most visible things for me and my friends who use
Discover everyday. I think it's worth sacrificing a little of app branding for
consistent qualitative look.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=388261

Andrew Crouthamel  changed:

   What|Removed |Added

 CC||croutham...@gmail.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #12 from Andrew Crouthamel  ---
+1 for this suggestion.

I'd much rather have my matching SVG's load from the my theme, than the
sub-HiDPI, non-matching icons load all stretched and pixelated from the
packagers. It just doesn't look nice.

Providing visual consistency will really help make the Plasma desktop look
beautiful. It's the little things like this, all added up that make a something
like Mac OS so well regarded for its design.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #11 from Nate Graham  ---
What's the bug in our applications? That Breeze and Oxygen icons are different,
or that packagers use Oxygen icons by default?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #10 from Aleix Pol  ---
That's not a side-effect, that's straight out a bug in our applications.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #9 from Nate Graham  ---
Created attachment 110983
  --> https://bugs.kde.org/attachment.cgi?id=110983=edit
Kolourpaint: Themed once installed, un-themed in Discover

Another example from Kolourpaint. This one surprised me since the Breeze icon
is nothing at all like the one shown in Discover. My son opened the app to do
some art and I didn't know what it even was just by looking at the icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #8 from Nate Graham  ---
Created attachment 110969
  --> https://bugs.kde.org/attachment.cgi?id=110969=edit
Icon differs between sources

Another side effect of not doing this: the icon can change when you switch the
source. For example, the KDEapps Flatpak repo uses Breeze icons, whereas KDE
Neon and Kubuntu packaging (and maybe everyone's packaging) uses Oxygen (or
some other theme) icons for KDE apps. Switching sources changes the icon, which
is really weird and jarring. See attached screen recording

This affects KDE software very strongly because we make use of icon themes much
more than GNOME and other DEs do. So by not doing this, we're mostly hurting
ourselves.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=388261

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #7 from Aleix Pol  ---
Mh, I'm not convinced TBH. The icon in Discover context is part of the
application branding. Overriding it is weird, especially on the software
center.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[AS]

https://bugs.kde.org/show_bug.cgi?id=388261

AS  changed:

   What|Removed |Added

 CC||funkyna...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #6 from Nate Graham  ---
I could go on attaching even more screenshots, but I think you get the idea. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #5 from Nate Graham  ---
Created attachment 109540
  --> https://bugs.kde.org/attachment.cgi?id=109540=edit
Kate: Themed once installed, un-themed in Discover

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #4 from Nate Graham  ---
This would also work around the issue of upstream sources that only provide
poor quality quality low resolution icons, as reported in
https://www.reddit.com/r/kde/comments/7ltc4h/discover_using_low_resolution_icons_for_apps_on/.
The icons from your theme are virtually guaranteed to be better, and most are
scalable SVGs too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #3 from Nate Graham  ---
Created attachment 109539
  --> https://bugs.kde.org/attachment.cgi?id=109539=edit
SMPlayer: Themed once installed, un-themed in Discover

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #2 from Nate Graham  ---
Created attachment 109538
  --> https://bugs.kde.org/attachment.cgi?id=109538=edit
Dolphin: Themed once installed, un-themed in Discover (also just plain wrong
upstream)

This one shows an upstream icon that's just plain wrong in my distro (Kubuntu
17.10): Dolphin is using Nautilus's old icon, for some reason. While this
should be fixed upstream, it would also be avoided if Discover could substitute
the Breeze icon for Dolphin from my active theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 388261] App icons should respect active icon theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388261

--- Comment #1 from Nate Graham  ---
Created attachment 109537
  --> https://bugs.kde.org/attachment.cgi?id=109537=edit
LibreOffice Writer: Themed once installed, un-themed in Discover

-- 
You are receiving this mail because:
You are watching all bug changes.