[Discover] [Bug 389533] Ensure that search field and its toolbar are always visible
https://bugs.kde.org/show_bug.cgi?id=389533
Marco Martin changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit|https://commits.kde.org/kir |https://commits.kde.org/dis
|igami/cae9d9cdbd716188030b1 |cover/f365fd5e36d937ff5defa
|20b14e342e0356d90f1 |41774e41131c362ec98
Status|REOPENED|RESOLVED
Version Fixed In|5.64|5.18
--- Comment #13 from Marco Martin ---
Git commit f365fd5e36d937ff5defa41774e41131c362ec98 by Marco Martin.
Committed on 26/11/2019 at 15:26.
Pushed by mart into branch 'master'.
use the new GlobalDrawer header property
Summary:
Depends on D25425
FIXED-IN: 5.18
Test Plan: {F7774329}
Reviewers: #discover_software_store, ngraham, apol
Reviewed By: #discover_software_store, ngraham, apol
Subscribers: apol, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25426
M +3-6discover/qml/DiscoverDrawer.qml
https://commits.kde.org/discover/f365fd5e36d937ff5defa41774e41131c362ec98
--
You are receiving this mail because:
You are watching all bug changes.
[Discover] [Bug 389533] Ensure that search field and its toolbar are always visible
https://bugs.kde.org/show_bug.cgi?id=389533 Nate Graham changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #12 from Nate Graham --- Re-opening because the feature got reverted because it broke other apps. There are new patches available to do it right (thanks Marco): https://phabricator.kde.org/D25425 and https://phabricator.kde.org/D25426. Those are targeting Plasma 5.18. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 389533] Ensure that search field and its toolbar are always visible
https://bugs.kde.org/show_bug.cgi?id=389533
Nate Graham changed:
What|Removed |Added
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In||5.64
Latest Commit||https://commits.kde.org/kir
||igami/cae9d9cdbd716188030b1
||20b14e342e0356d90f1
--- Comment #11 from Nate Graham ---
Git commit cae9d9cdbd716188030b120b14e342e0356d90f1 by Nate Graham.
Committed on 31/10/2019 at 20:36.
Pushed by ngraham into branch 'master'.
Ensure that GlobalDrawer topContent always stays on top
Summary:
Right now, if you define `topContent` for your GlobalDrawer, it's added to the
scrollview
so it can actually scroll out of sight, making it not always on top.
This patch moves the `topContent` above the scrollview so it always stays on
top.
Test Plan:
Discover's GlobalDrawer toolbar no longer strangely scrolls out of view:
{F7680325}
No regressions in Discover when the view is not scrollable
No regressions that I could detect in Kirigami Gallery, though this probably
needs lots
more testing to ensure that nothing has exploded
FIXED-IN: 5.64
Reviewers: #kirigami, mart, apol, ahiemstra
Reviewed By: ahiemstra
Subscribers: plasma-devel
Tags: #kirigami
Differential Revision: https://phabricator.kde.org/D25019
M +196 -195 src/controls/GlobalDrawer.qml
https://commits.kde.org/kirigami/cae9d9cdbd716188030b120b14e342e0356d90f1
--
You are receiving this mail because:
You are watching all bug changes.
[Discover] [Bug 389533] Ensure that search field and its toolbar are always visible
https://bugs.kde.org/show_bug.cgi?id=389533 Nate Graham changed: What|Removed |Added Summary|Make Search Field |Ensure that search field |Persistent in Every Screen |and its toolbar are always ||visible --- Comment #10 from Nate Graham --- The search field itself is now visible on all pages just like originally requested, but it can still scroll out of the view. I've submitted a Kirigami patch that fixes this: https://phabricator.kde.org/D25019 -- You are receiving this mail because: You are watching all bug changes.
