[Discover] [Bug 418019] Details of app are shown with broken layout in some cases
https://bugs.kde.org/show_bug.cgi?id=418019
Nate Graham changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/dis
||cover/9b0652d5c724cb806bce5
||cb9cbb8e7d74a75222c
Version Fixed In||5.19.0
Status|ASSIGNED|RESOLVED
--- Comment #3 from Nate Graham ---
Git commit 9b0652d5c724cb806bce5cb9cbb8e7d74a75222c by Nate Graham.
Committed on 06/03/2020 at 18:28.
Pushed by ngraham into branch 'master'.
Improve layout and appearance of app details view
Summary:
After porting to FormLayout in D27183, the layout can now be so wide due to the
URLs
that it switches to the compact/mobile view. This patch re-arranges things a
bit and
uses human-readable strings for the links instead of showing raw URLs. For
safety,
this requires D27663 to be implemented first.
FIXED-IN: 5.19.0
Depends on D27663
Test Plan:
Before: normal-sized window (shows the compact/mobile view): {F8131970}
Before wide window: {F8131971}
After: normal-sized or wide window: {F8131972}
Reviewers: #vdg, #discover_software_store, apol, ndavis
Reviewed By: #vdg, #discover_software_store, apol, ndavis
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27664
M +10 -8discover/qml/ApplicationPage.qml
https://commits.kde.org/discover/9b0652d5c724cb806bce5cb9cbb8e7d74a75222c
--
You are receiving this mail because:
You are watching all bug changes.
[Discover] [Bug 418019] Details of app are shown with broken layout in some cases
https://bugs.kde.org/show_bug.cgi?id=418019 Nate Graham changed: What|Removed |Added Assignee|lei...@leinir.dk|n...@kde.org Status|CONFIRMED |ASSIGNED --- Comment #2 from Nate Graham --- Patch: https://phabricator.kde.org/D27664 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 418019] Details of app are shown with broken layout in some cases
https://bugs.kde.org/show_bug.cgi?id=418019 Nate Graham changed: What|Removed |Added CC||n...@kde.org Keywords||regression, usability Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Nate Graham --- That's not a broken layout, it's the narrow/mobile vilew for a Form Layout. Fallout from https://cgit.kde.org/discover.git/commit/?id=40742348cf052310bb74fceaec33f906ee0e4f26 I guess we could avoid displaying the full URL string or something. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 418019] Details of app are shown with broken layout in some cases
https://bugs.kde.org/show_bug.cgi?id=418019 Patrick Silva changed: What|Removed |Added Summary|Details of app has broken |Details of app are shown |layout in some cases|with broken layout in some ||cases -- You are receiving this mail because: You are watching all bug changes.
