[Discover] [Bug 442604] "undefined" repos when I open Discover and go to Settings page for the first time

2021-09-22 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=442604

--- Comment #5 from Aleix Pol  ---
https://codereview.qt-project.org/c/qt/qtdeclarative/+/372646

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 442604] "undefined" repos when I open Discover and go to Settings page for the first time

2021-09-22 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=442604

Aleix Pol  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/discover/commit/57d8dcd4 |ma/discover/commit/793dc9e1
   |928746e01d21c0c53aad605e43c |908da487cfa42581a1c51af3893
   |893f2   |3cf98

--- Comment #4 from Aleix Pol  ---
Git commit 793dc9e1908da487cfa42581a1c51af38933cf98 by Aleix Pol Gonzalez, on
behalf of Aleix Pol.
Committed on 23/09/2021 at 01:31.
Pushed by apol into branch 'Plasma/5.23'.

Sources: Fix displaying sources

This is a work-around to 2 half-bugs:
- ListView doesn't really care for models with columns
- QConcatenateTablesProxyModel enforces that we see the minimum amount
of columns available in all of the models.

Empty models (like QStandardItemModel) will report 0 columns if they're
empty. This makes the resulting model to appear bogus to the view.
ListView doesn't seem to refresh the items when a new column is added
because it doesn't care about columns.

Result: this workaround after a bunch of wasted hours. :(


(cherry picked from commit 57d8dcd4928746e01d21c0c53aad605e43c893f2)

M  +13   -2libdiscover/resources/SourcesModel.cpp
M  +4-0libdiscover/utils.h

https://invent.kde.org/plasma/discover/commit/793dc9e1908da487cfa42581a1c51af38933cf98

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 442604] "undefined" repos when I open Discover and go to Settings page for the first time

2021-09-22 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=442604

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/discover/commit/57d8dcd4
   ||928746e01d21c0c53aad605e43c
   ||893f2
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Aleix Pol  ---
Git commit 57d8dcd4928746e01d21c0c53aad605e43c893f2 by Aleix Pol.
Committed on 23/09/2021 at 01:31.
Pushed by apol into branch 'master'.

Sources: Fix displaying sources

This is a work-around to 2 half-bugs:
- ListView doesn't really care for models with columns
- QConcatenateTablesProxyModel enforces that we see the minimum amount
of columns available in all of the models.

Empty models (like QStandardItemModel) will report 0 columns if they're
empty. This makes the resulting model to appear bogus to the view.
ListView doesn't seem to refresh the items when a new column is added
because it doesn't care about columns.

Result: this workaround after a bunch of wasted hours. :(

M  +13   -2libdiscover/resources/SourcesModel.cpp
M  +4-0libdiscover/utils.h

https://invent.kde.org/plasma/discover/commit/57d8dcd4928746e01d21c0c53aad605e43c893f2

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 442604] "undefined" repos when I open Discover and go to Settings page for the first time

2021-09-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=442604

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
   Priority|NOR |HI
   Keywords||regression

--- Comment #2 from Nate Graham  ---
Can confirm on Fedora 34.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 442604] "undefined" repos when I open Discover and go to Settings page for the first time

2021-09-17 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=442604

--- Comment #1 from Patrick Silva  ---
Created attachment 141652
  --> https://bugs.kde.org/attachment.cgi?id=141652=edit
screeen recording

-- 
You are receiving this mail because:
You are watching all bug changes.