[Discover] [Bug 474542] With a large window, clicking multiple apps on Discover's home page pushes each one as a new column

2023-09-26 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=474542

Marco Martin  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kirigami/-/commit/c8
   ||71893587f71aff9b0c8b26c26e5
   ||754fd09e251
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Marco Martin  ---
Git commit c871893587f71aff9b0c8b26c26e5754fd09e251 by Marco Martin.
Committed on 26/09/2023 at 17:25.
Pushed by mart into branch 'master'.

Restore push behavior, unbreak existing apps

The behavior of PageRow is alike a browser history of undo stack: the
top of the stack is considered the page the app is currently in, rather
than the total depth.
This logic broke in the refactor, causing many apps like multi level
KCMS or discover to do double pushes keeping creating new pages in the
row.
this does the minimal indexes fix to make the existing users behave
correctly.

M  +37   -4autotests/tst_pagerow.qml
M  +4-1src/columnview.cpp
M  +5-3src/controls/PageRow.qml

https://invent.kde.org/frameworks/kirigami/-/commit/c871893587f71aff9b0c8b26c26e5754fd09e251

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 474542] With a large window, clicking multiple apps on Discover's home page pushes each one as a new column

2023-09-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=474542

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
Summary|Description pages open next |With a large window,
   |to each other   |clicking multiple apps on
   ||Discover's home page pushes
   ||each one as a new column
 CC||matej.st...@protonmail.com,
   ||m...@ratijas.tk, n...@kde.org
   Keywords||regression

--- Comment #1 from Nate Graham  ---
Can confirm. If you keep clicking on apps, it pushes more pages!

Might be caused by recent ColumnView changes. CCing some folks.

-- 
You are receiving this mail because:
You are watching all bug changes.