[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476068

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #6 from Nate Graham  ---
Yep, that was it.

I ran into one gotcha: by default taglib only builds a static library (.a)
rather than a shared library (.so) which caused kfilemetadata to fail during
compilation because it couldn't link a static library into a dynamic one:

[ 93%] Linking CXX shared module
../../bin/kf6/kfilemetadata/writers/kfilemetadata_taglibwriter.so
/usr/bin/ld: /home/nate/kde/usr6/lib64/libtag.a(mpegfile.cpp.o): relocation
R_X86_64_32S against `.rodata' can not be used when making a shared object;
recompile with -fPIC
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status

It turns out that taglib has an off-by-default CMake option to build shared
libs, and after doing that I had to actually delete the buil static libs that
got installed earlier. After I did that, kfilemetadata and Elisa linkes against
the .so and all was well again.

I've added these to my kdesrc-buildrc file:

# For TagLib, because Fedora doesn't have a Qt6 build of it yet
module utfcpp
repository g...@github.com:nemtrif/utfcpp.git
end module

# For KFileMetadata and Elisa, because Fedora doesn't have a Qt6 build of it
yet
module taglib
repository g...@github.com:taglib/taglib.git
cmake-options -DBUILD_SHARED_LIBS=TRUE
end module

And ensured that I build those from source every day as well.

Thanks so much for pointing me on the right path, Jack!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476068

--- Comment #5 from Nate Graham  ---
Ah, that's definitely worth following up. I'm not building TagLib from source
right now. I'll give it a go and see if that helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-25 Thread Jack Hill
https://bugs.kde.org/show_bug.cgi?id=476068

--- Comment #4 from Jack Hill  ---
Btw check you have taglib-devel or libtag-devel installed too. I recently had
issues because I forgot to install that package so Elisa wasn't scanning files
properly. I didn't realise it for a while because the database was already
populated using the distro version of Elisa.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-25 Thread Jack Hill
https://bugs.kde.org/show_bug.cgi?id=476068

--- Comment #3 from Jack Hill  ---
On Wednesday, 25 October 2023 21:21:37 BST you wrote:
> https://bugs.kde.org/show_bug.cgi?id=476068
> 
> --- Comment #2 from Nate Graham  ---
> I tried with an MP3 file too; same issue.
> 
> Are you also building Elisa on top of Plasma 6? What's your Qt version?
> Mine's 6.5.2 right now.

I'm running it on Plasma 5 still but I can give it a test on Plasma 6 soon. Qt
is 6.6 here.

Could you run the taglibextractortest and taglibwritertest for KFileMetadata? I
can see they have a test for the lyrics field here
https://invent.kde.org/frameworks/kfilemetadata/-/blob/master/autotests/taglibextractortest.cpp?ref_type=heads#L204

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476068

--- Comment #2 from Nate Graham  ---
I tried with an MP3 file too; same issue. 

Are you also building Elisa on top of Plasma 6? What's your Qt version? Mine's
6.5.2 right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-25 Thread Jack Hill
https://bugs.kde.org/show_bug.cgi?id=476068

--- Comment #1 from Jack Hill  ---
I can't reproduce with that file. FWIW ogg containers use Vorbis comments to
store metadata. Can you try with an mp3 to see if it also happens with ID3
tags?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 476068] Lyrics tag in music files not honored/noticed

2023-10-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476068

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=476067

-- 
You are receiving this mail because:
You are watching all bug changes.