[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 David Rosca changed: What|Removed |Added Version Fixed In||3.0.1 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/fal ||kon/3787a606d3fc66d36301a34 ||457f3ca08c0893bd4 --- Comment #21 from David Rosca --- Git commit 3787a606d3fc66d36301a34457f3ca08c0893bd4 by David Rosca. Committed on 01/05/2018 at 11:02. Pushed by drosca into branch 'Falkon/3.0'. Rewrite internal sites to use user scripts instead of embedded code It is no longer needed to setup web channel on unsafe js world for internal pages, and thus it fixes issue where registering web channel could fail in some cases. FIXED-IN: 3.0.1 M +19 -16 src/lib/app/mainapplication.cpp M +2-0src/lib/data/html.qrc M +7-170 src/lib/data/html/restore.html C +21 -178 src/lib/data/html/restore.user.js [from: src/lib/data/html/restore.html - 053% similarity] M +33 -462 src/lib/data/html/speeddial.html A +502 -0src/lib/data/html/speeddial.user.js M +0-2src/lib/network/schemehandlers/falkonschemehandler.cpp M +9-1src/lib/plugins/speeddial.cpp M +12 -13 src/lib/tools/scripts.cpp M +2-1src/lib/tools/scripts.h M +4-29 src/lib/webengine/webpage.cpp M +0-5src/lib/webengine/webpage.h https://commits.kde.org/falkon/3787a606d3fc66d36301a34457f3ca08c0893bd4 -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #20 from Christian --- Sometimes when I close a page (maybe somewhat more complex page?) and it takes longer for Falkon to close it, the Speed Dial still shows up as blank despite the Fix. I don't know how it is programmed, but I think the Speed dial items should be drawn as part of the sequence that draws the empty tab with the Speed dial, and not after a certain programmed delay. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #19 from Richard Ullger --- I concur with Christian, applying the patch fixes the issue but introduces a delay in displaying the speeddials. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #18 from Christian --- I installed the patch. It seems that the speed dial items now appear, after a noticeable delay. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #17 from private2@yandex.com --- Created attachment 111901 --> https://bugs.kde.org/attachment.cgi?id=111901&action=edit Fix The attached patch should fixes the issue. Please try it! -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 Richard Ullger changed: What|Removed |Added CC||rull...@gmail.com --- Comment #16 from Richard Ullger --- This is 100% reproducible for me using the steps below. I'm running the kde_unstable repo in Arch Linux. qt5-webengine 5.11.0beta2-2 falkon 3.0.0-1 rebuilt for 5.11.0beta2 I have the following preferences set... After launch: Open homepage Homepage: falkon:speeddial On new tab: Open homepage 1. Ensure falkon is set as the default browser. 2. Quit all instances of falkon. 3. Click on a http(s) link to cause falkon to start up and display the page. 4. After the page has displayed click on the homepage button. A blank speeddial page is displayed. Clicking + to open a new tab displays the speeddial page correctly whether the new tab is opened before or after the homepage button is clicked while on the first tab. Opening a new tab correctly displaying the speeddial page and then clicking the homepage button on the first tab still displays a blank speeddial page. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #15 from Christian --- PS Clicking the green plus button for a new tab always gives me the speed dial. It just sometimes fails to appear when closing the last tab. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 Christian changed: What|Removed |Added CC||gen...@moin.fi --- Comment #14 from Christian --- I have the same issue as dsreyes1014 -I set the homepage to speeddial (falkon:speeddial) and "do not close window upon closing last tab", so I expect that there will be the speed dial when I close the last tab. Sometimes it shows up, sometimes it shows an empty screen with the speeddial background but no speed dials. Falkon version 3.0.0, qtwebengine version 5.9.4, using Gentoo. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #13 from private2@yandex.com --- Well, i have tried few lower values until i increased it to 1000, where i have a success. That's it. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #12 from David Rosca --- That looks correct, no idea then. Maybe try to change ms delay (setTimeout) for m_setupChannelTimer in webpage.cpp:114 to lower/higher value. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #11 from private2@yandex.com --- This is the output to me: WebPage(0x1a3e3e0) set 0 -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #10 from David Rosca --- Created attachment 111753 --> https://bugs.kde.org/attachment.cgi?id=111753&action=edit webchannel registration debug Can you please try with this patch and send output when the bug happens? -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #9 from private2@yandex.com --- I think that is something related to paths permissions, because: To do some quick tests, i'm just overriding the HOME variable, so if HOME is set to '/tmp/test' for example, the problem does not exists, but if HOME is set to any other directory different from '/tmp' or just by default, it exists. So, for me there is no bug here. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #8 from private2@yandex.com --- I'm also with 5.10.1... You may try with QupZilla Appimage, i've reproduced it also with it. Does the debug code will give you the needed information? -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #7 from David Rosca --- I can't reproduce it with QtWebEngine 5.10.1 -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #6 from dsreyes1...@gmail.com --- David reloading the page doesn't not help nor does clicking on homepage again. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #5 from private2@yandex.com --- Actually today it happens again. Almost 100% reproducible at https://twitter.com/IronMaiden, then just close it (you should have 'dontCloseWithOneTab=true' sett) -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #4 from private2@yandex.com --- David, i also was facing that as kind of regression of https://github.com/QupZilla/qupzilla/issues/2544, but currently i can't reproduce it, so that was the reason i posted the previous comment. Reloading the page was not helping to me. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #3 from David Rosca --- Does reloading the page helps? -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 --- Comment #2 from dsreyes1...@gmail.com --- Is there a release of stable coming out soon or should I just check for the fix in git? -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 private2@yandex.com changed: What|Removed |Added CC||private2@yandex.com --- Comment #1 from private2@yandex.com --- I think that's related to https://phabricator.kde.org/R875:674a0e78f69fb49c5512ddf03fe32597dc7ca209, so if i'm right, it's fixed already. -- You are receiving this mail because: You are watching all bug changes.
[Falkon] [Bug 391875] Setting Speeddial As Homepage Randomly Gives Empty Page
https://bugs.kde.org/show_bug.cgi?id=391875 dsreyes1...@gmail.com changed: What|Removed |Added CC||dsreyes1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
