[Falkon] [Bug 468046] GM.getValue / GM.setValue don't work as expected

2023-06-10 Thread Schimon Jehudah
https://bugs.kde.org/show_bug.cgi?id=468046

Schimon Jehudah  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Schimon Jehudah  ---
I was wrong. It appears that only GM.getValue or reading value doesn't (always)
work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 468046] GM.getValue / GM.setValue don't work as expected

2023-06-09 Thread Schimon Jehudah
https://bugs.kde.org/show_bug.cgi?id=468046

--- Comment #2 from Schimon Jehudah  ---
I think that the banner, currently, will cause harm, because once a new person
will use Falkon, he would see that the userscript that has the banner, doesn't
fully work with Falkon.
On the other hand, this person might be a C++ programmer that would contribute
to this extension.
The banner will be disabled unless you would tell me otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 468046] GM.getValue / GM.setValue don't work as expected

2023-06-09 Thread Schimon Jehudah
https://bugs.kde.org/show_bug.cgi?id=468046

--- Comment #1 from Schimon Jehudah  ---
I have made a update to a userscript[1] which adds dark view mode to it.
It uses GM.getValue / GM.setValue to save last used mode.

GM_getValue / GM_setValue[2] don't appear to save info or or retrieve values as
expected; and
GM.getValue / GM.setValue[3] doesn't appear to work
Both ways were tested with Tampermonkey and are working as expected.

This script adds a Falkon banner to bottom of every Web Feed page. See function
setBanner().
The banner was featured only in the openuserjs.org version[4] because they
don't require antifeature metablock.
However, I will remove this banner from the openuserjs.org until GM.getValue /
GM.setValue are supported.

[1]: https://greasyfork.org/en/scripts/465932-newspaper-native-rss-reader
[2]:
https://greasyfork.org/en/scripts/465932-newspaper-native-rss-reader/diff?v1=1202515=1202391
[3]:
https://greasyfork.org/en/scripts/465932-newspaper-native-rss-reader/diff?v1=1202515=1198552
[4]: https://openuserjs.org/scripts/sjehuda/Newspaper

-- 
You are receiving this mail because:
You are watching all bug changes.