[Falkon] [Bug 469602] Small enhancements adblock.html

2023-05-17 Thread Juraj
https://bugs.kde.org/show_bug.cgi?id=469602

--- Comment #4 from Juraj  ---
(In reply to Schimon Jehudah from comment #3)
> Please do let me know if you want to delegate to me tasks related to this.

OK, there are multiple internal html pages in Falkon.
- falkon:about - src/lib/data/html/about.html
- falkon:config - src/lib/data/html/config.html
- falkon:start - src/lib/data/html/start.html
- falkon:restore - src/lib/data/html/restore.html (when browser crashes and is
opened again, depends on some internal settings as well)

- src/lib/data/html/tabcrash.html - When rendering process is terminated signal
received from Qt (QWebEnginePage::renderProcessTerminated)
- src/lib/adblock/data/adblock.html - When some page is blocked by adblock,
should properly work with Falkon 23.04.x
- src/plugins/VerticalTabs/data/group.html - Vertical tabs, hold the "+" button
on the bottom for bit longer and menu "Add New Group" appears, click on it and
it will show this page; there is also an index.html in this folder which I
believe is unused.

I recommend using data from lates falkon code or release (23.04.x) and also
testing the dark theme variant.
The dark variant can be forced by changing the environmental variable:
> QTWEBENGINE_CHROMIUM_FLAGS=--force-dark-mode

PS: keep it simple :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 469602] Small enhancements adblock.html

2023-05-16 Thread Schimon Jehudah
https://bugs.kde.org/show_bug.cgi?id=469602

--- Comment #3 from Schimon Jehudah  ---
> Thank you for the idea, but this requires a bit more work.

Please do let me know if you want to delegate to me tasks related to this.

> I would prefer to have all html pages follow the same style and look similar 
> to some extend.

Yes, this is what I want too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 469602] Small enhancements adblock.html

2023-05-16 Thread Juraj
https://bugs.kde.org/show_bug.cgi?id=469602

Juraj  changed:

   What|Removed |Added

 CC||jurajora...@mailo.com

--- Comment #2 from Juraj  ---
Hello,

Thank you for the idea, but this requires a bit more work.
I would prefer to have all html pages follow the same style and look similar to
some extend.
Also think about the "dark" variant which was added in latest release.

Best regards,
Juraj.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 469602] Small enhancements adblock.html

2023-05-10 Thread Schimon Jehudah
https://bugs.kde.org/show_bug.cgi?id=469602

--- Comment #1 from Schimon Jehudah  ---
Created attachment 158844
  --> https://bugs.kde.org/attachment.cgi?id=158844=edit
Card style

-- 
You are receiving this mail because:
You are watching all bug changes.