[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 Volker Krause changed: What|Removed |Added Latest Commit|https://invent.kde.org/libr |https://invent.kde.org/libr |aries/kopeninghours/-/commi |aries/kopeninghours/-/commi |t/497444553d267b830494f0381 |t/bc12a820326f564e00c653300 |b7f820a46a3b2bc |8e027b321fa6644 --- Comment #6 from Volker Krause --- Git commit bc12a820326f564e00c6533008e027b321fa6644 by Volker Krause, on behalf of Fam Lam. Committed on 13/04/2024 at 08:46. Pushed by vkrause into branch 'release/24.02'. Keep year if months differ with day (undefined behaviour) (cherry picked from commit 497444553d267b830494f0381b7f820a46a3b2bc) M +4-0autotests/parsertest.cpp M +1-1src/lib/selectors.cpp https://invent.kde.org/libraries/kopeninghours/-/commit/bc12a820326f564e00c6533008e027b321fa6644 -- You are receiving this mail because: You are watching all bug changes.
[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 David Faure changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/libr ||aries/kopeninghours/-/commi ||t/497444553d267b830494f0381 ||b7f820a46a3b2bc --- Comment #5 from David Faure --- Git commit 497444553d267b830494f0381b7f820a46a3b2bc by David Faure, on behalf of Fam Lam. Committed on 20/01/2024 at 17:59. Pushed by dfaure into branch 'master'. Keep year if months differ with day (undefined behaviour) M +4-0autotests/parsertest.cpp M +1-1src/lib/selectors.cpp https://invent.kde.org/libraries/kopeninghours/-/commit/497444553d267b830494f0381b7f820a46a3b2bc -- You are receiving this mail because: You are watching all bug changes.
[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 --- Comment #4 from fam@live.nl --- Oh dang, my comment 1 is still correct, I wasn't thinking properly. The opening hours specification doesn't say that the same year should be assumed if contains a year, but doesn't contain a year. -- You are receiving this mail because: You are watching all bug changes.
[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 --- Comment #3 from fam@live.nl --- (In reply to fam.lam from comment #1) Please ignore comment 1, it is clearly wrong (can't find how to delete it though). The original description and comment 2 are still correct. -- You are receiving this mail because: You are watching all bug changes.
[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 --- Comment #2 from fam@live.nl --- In addition, I noticed that also "Jan 01-Jan 31" is changed to "Jan 01-31" in normalizedExpression(). (This is valid, no doubt about that, but it would be great if this was only done at simplifiedExpression) -- You are receiving this mail because: You are watching all bug changes.
[KOpeningHours] [Bug 452236] normalizeExpression output on monthday_range is simplified
https://bugs.kde.org/show_bug.cgi?id=452236 fam@live.nl changed: What|Removed |Added CC||fam@live.nl --- Comment #1 from fam@live.nl --- Actually when I look at the opening hours specification (https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification) I start to wonder if > 2022 Mar 31 - Apr 16 is really the same as > 2022 Mar 31 - 2022 Apr 16 2022 Mar-Apr is valid per [ ] - 2022 Mar 31 - 2022 Apr 16 is valid per [ ] - [ ] However, no-where in the specs it mentions how "2022 Mar 31 - Apr 16" should be parsed. So I could argue that this selector would also be valid on 2023 Jan 01 until 2023 Apr 16, 2024 Jan 01 until 2024 Apr 16, ..., in contrast to 2022 Mar 31 - 2022 Apr 16 (which is restricted tot the 2022 date range only) -- You are receiving this mail because: You are watching all bug changes.
