[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 James Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/netw ||ork/neochat/commit/6748a2d2 ||1d276caed4c011ed74f9da414bc ||6fbd9 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #8 from James Graham --- Git commit 6748a2d21d276caed4c011ed74f9da414bc6fbd9 by James Graham. Committed on 26/08/2022 at 19:33. Pushed by nvrwhere into branch 'master'. Fix the reply an edit text being shown in all chat rooms when multiple windows are open Fix the reply an edit text being shown in all chat rooms when multiple windows are open. This is done by changing chatBoxHelper from a singleton to being instantiated for each instance of roompage. M +6-6imports/NeoChat/Component/ChatBox/AttachmentPane.qml M +9-9imports/NeoChat/Component/ChatBox/ChatBar.qml M +5-5imports/NeoChat/Component/ChatBox/ChatBox.qml M +3-3imports/NeoChat/Component/ChatBox/ReplyPane.qml M +1-1imports/NeoChat/Menu/Timeline/FileDelegateContextMenu.qml M +2-2imports/NeoChat/Menu/Timeline/MessageDelegateContextMenu.qml M +12 -8imports/NeoChat/Page/RoomPage.qml M +1-1src/main.cpp https://invent.kde.org/network/neochat/commit/6748a2d21d276caed4c011ed74f9da414bc6fbd9 -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/496 -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 James Graham changed: What|Removed |Added CC||james.h.graham@protonmail.c ||om --- Comment #6 from James Graham --- I assume this is happening because they all pull the text from the same instance of chatBoxHelper -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 --- Comment #5 from Miepee --- Found these cases while toying around with this bug a little: Edit Case: - detach room A - open room B in main window - Edit a message of yours in room B - send the edit of the message in the detached window of room A => room A will have the message send as-is, while the main window with room B will now have the text stuck permanently. Arrow keys don't work, neither does backspace or the delete key. Happens only for this room B, afaik the only solution to fix this is to restart neochat. Attachment Case: - detach room A - open room B in main window - paste attachment into room B main window - send message in room A detached window => room A will have the attachment send. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 --- Comment #4 from Miepee --- Worth noting, that this also happens with the "edit" feature. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 --- Comment #3 from Miepee --- (In reply to Tobias Fella from comment #2) > That's rather bad, that probably means that an [invalid] reply would be sent > in those windows as well... Tested that out, seems like no reply seems to be send at all. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 Tobias Fella changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Tobias Fella --- That's rather bad, that probably means that an [invalid] reply would be sent in those windows as well... -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 454963] Reply quote is shown in all windows when one is detached
https://bugs.kde.org/show_bug.cgi?id=454963 Miepee changed: What|Removed |Added CC||janbidle...@protonmail.com --- Comment #1 from Miepee --- Can confirm this on NeoChat 22.04, Windows 10 12H1. -- You are receiving this mail because: You are watching all bug changes.
