[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=360537

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #13 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #12 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Natalie Clarius]

https://bugs.kde.org/show_bug.cgi?id=360537

Natalie Clarius  changed:

   What|Removed |Added

 CC||natalie_clar...@yahoo.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=360537

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||n...@kde.org

--- Comment #11 from Nate Graham  ---
Is this still a problem in Plasma 5.27? Or, even better, in Plasma 6?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Thomas Pfeiffer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #7 from Thomas Pfeiffer  ---
Oh okay, they do that directly? Fine, then.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #9 from Fuchs  ---
To get the OSD back, I created the following script (Adapt paths where needed,
should work in POSIX compliant shells) and bound it to XF86KbdLightOnOff.
Therefore now using the keyboard or the battery plasmoid slider (aside from
closing itself) works including displaying the OSD.

#!/bin/sh
# Get the maximum value
MAX=`/usr/bin/qdbus --system org.freedesktop.UPower
/org/freedesktop/UPower/KbdBacklight
org.freedesktop.UPower.KbdBacklight.GetMaxBrightness`
# Get the current value. Dbus currently (kernel 4.5) gives wrong values for
GetBrightness, so we fetch it via the proc interface
CUR=`grep status /proc/acpi/ibm/kbdlight | awk '{print $2}'`

# Calculate percentage
PER=$(($CUR * 100 / 2))

# Invoke OSD
/usr/bin/qdbus org.kde.plasmashell /org/kde/osdService
org.kde.osdService.keyboardBrightnessChanged $PER

exit 0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Thomas Pfeiffer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

Thomas Pfeiffer  changed:

   What|Removed |Added

 CC||colo...@autistici.org

--- Comment #5 from Thomas Pfeiffer  ---
(In reply to Kai Uwe Broulik from comment #4)
> I have yet to see a laptop that actually has this key...

What do other laptops emit when pressing the key combination to change keyboard
backlight brightness?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #10 from Fuchs  ---
Augh, obviously replace 2 above with $MAX, my bad. (And in this case maybe
check for non-null, even though this should™ not be possible)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #6 from Kai Uwe Broulik  ---
Keyboard brightness up / down

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #8 from Fuchs  ---
As a sidenote there is a BIOS setting on how the brightness key should behave,
I can't remember whether that is only related to the thinklight (which gets
turned on after 3 presses) or also the keyboard levels. I'll update the bug
report if there are any changes. 

As discussed on IRC, just to have this documented here as well: 

the keyboard event emitted unfortunately also has other side effects, e.g. when
using the slider of the battery plasmoid it closes it. So it would be great to
have that fixed upstream in kernel. Also the OSD is obviously not shown when
the key binding is disabled, this should be workaroundable with a little script
and dbus, I'll also update the bug report when I manage something. Won't have
time today / in the next two days though. Thanks so far for everybody involved.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Ever confirmed|0   |1
   Severity|normal  |major
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Kai Uwe Broulik  ---
Thanks a lot for your investigation!

While this is definitely a driver but and it's utterly stupid to emit key
events on non key presses, ie. you tell PowerDevil to change brightness, it
emits a keyboard event which tells PowerDevil to do something yet again.

But you convinced me that it's serious enough to disable the default key
binding for this keyboard shortcut as I have yet to see a laptop that actually
has this key...

Marking as confirmed and major so I don't forget.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #3 from Fuchs  ---
As discussed on IRC: 

I also checked why using the slider or dbus would trigger the buggy behaviour. 
As expected, the driver is silly enough to emit 

keycode 236 (keysym 0x1008ff04, XF86KbdLightOnOff)

even if you didn't touch the keyboard, it just does this on all keyboard
brightness changes. Huzzah.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #2 from Fuchs  ---
Ignore the last comment, actual issue is the following: 

per default the key triggers keycode 236 (keysym 0x1008ff04,
XF86KbdLightOnOff), which by default in KDE Plasma is configured to toggle the
keyboard light. However, at the same time the keyboard light is changed by the
BIOS. This seems to get plasma / powerdevil in a confused state so it doesn't
stop cycling through them. 

If somehow possible, I highly recommend disabling that default keybinding on
affected thinkpads. If not possible some logic will be needed to avoid that,
because otherwise owners of affected hardware will run into this issue with
recent kernels and KDE plasma, changing their keyboard brightness leading to an
endless cycle  (which, as a side effect, triggers the lovely pop up which won't
disappear either. In short: the session is rendered quite unusable) 

If I can somehow help resolving this issue  (xev or dbus monitor logs or
whatnot): let me know. 

Workaround for me: disable that keybinding in systemsettings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #1 from Fuchs  ---
Looking at the code so far, my best guess would be that it tries to round (with
the very limited amount of steps, 0,1,2) and horribly fails, which never lets
it rest at a certain value. If that is the case, I hope the logic can be
adapted to cope with that. Otherwise someone needs to dig a bit further.

-- 
You are receiving this mail because:
You are watching all bug changes.