[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #17 from beaiouns --- Works great here, the keyboard light comes back on when I open the lid now! -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Jakob Petsovits changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/powerdevil/-/commit/4bb7 |ma/powerdevil/-/commit/4ca0 |c6148b1ee0436227e70f510e98e |ce68a303090f0e76719ea021dd4 |06b158c01 |d96e9730b --- Comment #16 from Jakob Petsovits --- Git commit 4ca0ce68a303090f0e76719ea021dd4d96e9730b by Jakob Petsovits, on behalf of Anthony Vital. Committed on 13/04/2024 at 17:25. Pushed by jpetso into branch 'Plasma/6.0'. actions/handlebuttonevents: Require lid-open again to track kb brightness Out of the two checks in this line that were removed in commit d0b43050, one should have remained. We still need to make storing the old keyboard brightness conditional on an opened lid, otherwise restoring keyboard brightness can fail after closing and re-opening the lid. FIXED-IN: 6.0.4 (cherry picked from commit 4bb7c6148b1ee0436227e70f510e98e06b158c01) M +3-1daemon/actions/bundled/handlebuttonevents.cpp https://invent.kde.org/plasma/powerdevil/-/commit/4ca0ce68a303090f0e76719ea021dd4d96e9730b -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Jakob Petsovits changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/powerdevil/-/commit/4bb7 ||c6148b1ee0436227e70f510e98e ||06b158c01 Version Fixed In||6.0.4 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #15 from Jakob Petsovits --- Git commit 4bb7c6148b1ee0436227e70f510e98e06b158c01 by Jakob Petsovits, on behalf of Anthony Vital. Committed on 13/04/2024 at 17:13. Pushed by jpetso into branch 'master'. actions/handlebuttonevents: Require lid-open again to track kb brightness Out of the two checks in this line that were removed in commit d0b43050, one should have remained. We still need to make storing the old keyboard brightness conditional on an opened lid, otherwise restoring keyboard brightness can fail after closing and re-opening the lid. FIXED-IN: 6.0.4 M +3-1daemon/actions/bundled/handlebuttonevents.cpp https://invent.kde.org/plasma/powerdevil/-/commit/4bb7c6148b1ee0436227e70f510e98e06b158c01 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #14 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/343 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #13 from Jakob Petsovits --- (In reply to Anthony Vital from comment #12) > Here's a small patch that fixes the issue against the 6.0 branch (I have no > easy way to try the master branch, but it should be the same). > So the issue seems to be that after the lid is closed and the brightness set > to 0, powerdevil receives a signal keyboardBrightnessChanged, and saves this > value for restoration. This patch ensures we store this value only if the > lid is open. > This check existed in the 5.27 branch, I'm not sure why it was removed. Thanks for the patch, great find. I tested this on my ThinkPad, latest master branch, and it indeed makes a difference there as well. I did a little bit of digging in the commit history, my reading is that the removal of this condition was probably unintentional. It got removed together with another condition in the same line that did indeed have to disappear due to a refactoring. More details and perhaps also a confirmation of this theory in the merge request that will get linked by the bot in the next comment. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Anthony Vital changed: What|Removed |Added CC||anthony.vi...@gmail.com --- Comment #12 from Anthony Vital --- Created attachment 167914 --> https://bugs.kde.org/attachment.cgi?id=167914=edit kb brightness patch Here's a small patch that fixes the issue against the 6.0 branch (I have no easy way to try the master branch, but it should be the same). So the issue seems to be that after the lid is closed and the brightness set to 0, powerdevil receives a signal keyboardBrightnessChanged, and saves this value for restoration. This patch ensures we store this value only if the lid is open. This check existed in the 5.27 branch, I'm not sure why it was removed. Also I noticed everyone who reported this issue have a Dell computer, so this behaviour might be vendor specific. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #11 from Dm --- In SDDM everything works proper -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Dm changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #10 from Dm --- Having same problem after update to KDE 6 on Neon user Operating System: KDE neon 6.0 KDE Plasma Version: 6.0.2 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.5.0-26-generic (64-bit) Graphics Platform: Wayland Processors: 12 × Intel® Core™ i7-8750H CPU @ 2.20GHz Memory: 15.3 ГиБ of RAM Graphics Processor: Mesa Intel® UHD Graphics 630 Manufacturer: Dell Inc. Product Name: XPS 15 9570 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Nate Graham changed: What|Removed |Added Keywords|qt6 |regression Version|unspecified |6.0.0 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Nate Graham changed: What|Removed |Added CC||dvs-1...@yandex.ru --- Comment #9 from Nate Graham --- *** Bug 482541 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #8 from Jakob Petsovits --- (In reply to Nate Graham from comment #7) > It seems that there may be some kind of automatic keyboard backlight control > in firmware that's interfering with powerdevil's control of it. I'd say it's more likely that PowerDevil turns it off on lid-close and fails to bring it back for some reason. If it were a firmware thing, it probably wouldn't work on 5.27 either, but beaiouns reported that it was fine there and regressed on Plasma 6.0. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #7 from Nate Graham --- It seems that there may be some kind of automatic keyboard backlight control in firmware that's interfering with powerdevil's control of it. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Jakob Petsovits changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |REPORTED -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #6 from beaiouns --- (In reply to Werner Sembach [TUXEDO] from comment #4) > (In reply to beaiouns from comment #3) > > Yep that's how it was working in plasma 5, it seemed like the backlight > > would time out after 10 or so seconds, so if I don't type anything for a > > while then it would fade out until the next key press. I'm usually closing > > the lid for a while and then coming back to it, so I figured it had just > > timed out from not typing. That's also how it worked with the preinstalled > > Windows setup so I didn't really think about it. > > Does it stay off only if it had timed out, or also when you have closed the > notebook when it was still on? I just tried it and if I close the lid right after typing something, the keyboard light turns off. I had to hit function + f10 to get it to turn back on. If I leave the lid up, even after the screen saver kicks in, the keyboard will light up again as soon as I start typing my password to unlock it. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #5 from Werner Sembach [TUXEDO] --- (In reply to Nate Graham from comment #2) > Your step 3 should not be necessary; the keyboard brightness is supposed to > be restored automatically after opening the lid, without you having to hit a > key. Was this not happening in Plasma 5, and you were having to hit a key on > the keyboard to make the keyboard backlight illuminate again? > > If so, I wonder if that was in fact a bug all along that some > vendor-specific firmware was working around, and we broke their workaround > by fixing the general issue with > https://invent.kde.org/plasma/powerdevil/-/merge_requests/317 for Plasma 6. I don't really see how this could have broken this, all the patch is doing is avoiding to write 0, all other values are unaffected. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #4 from Werner Sembach [TUXEDO] --- (In reply to beaiouns from comment #3) > Yep that's how it was working in plasma 5, it seemed like the backlight > would time out after 10 or so seconds, so if I don't type anything for a > while then it would fade out until the next key press. I'm usually closing > the lid for a while and then coming back to it, so I figured it had just > timed out from not typing. That's also how it worked with the preinstalled > Windows setup so I didn't really think about it. Does it stay off only if it had timed out, or also when you have closed the notebook when it was still on? -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #3 from beaiouns --- Yep that's how it was working in plasma 5, it seemed like the backlight would time out after 10 or so seconds, so if I don't type anything for a while then it would fade out until the next key press. I'm usually closing the lid for a while and then coming back to it, so I figured it had just timed out from not typing. That's also how it worked with the preinstalled Windows setup so I didn't really think about it. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Nate Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC||jpe...@petsovits.com, ||n...@kde.org, ||w...@tuxedocomputers.com Resolution|--- |WAITINGFORINFO --- Comment #2 from Nate Graham --- Your step 3 should not be necessary; the keyboard brightness is supposed to be restored automatically after opening the lid, without you having to hit a key. Was this not happening in Plasma 5, and you were having to hit a key on the keyboard to make the keyboard backlight illuminate again? If so, I wonder if that was in fact a bug all along that some vendor-specific firmware was working around, and we broke their workaround by fixing the general issue with https://invent.kde.org/plasma/powerdevil/-/merge_requests/317 for Plasma 6. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 --- Comment #1 from beaiouns --- I noticed that the default keyboard shortcut "function + f10" cycles between 0%, 50% and 100% keyboard brightness, so that seems to be an easier workaround to turn the keyboard brightness back up after opening the lid, but if there's a way to get the 5.27 behavior back where it stays at the same level between closing and opening the lid, that would be best. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 482306] Keyboard brightness at 0% after closing lid
https://bugs.kde.org/show_bug.cgi?id=482306 Bug Janitor Service changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
