[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 EnzoR changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #21 from EnzoR --- Latest version 22.04 removed the Quit button altogether thus making impossible to trigger the behavior. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #20 from EnzoR --- Some programs have the File menu with an explicit Quit action (konsole, okular, kgpg, kcalc). Some programs also have the "hamburger" menu button that leads also to the File menu (falkon, dolphin). Some other have nothing but the window decorations/widgets (system settings, spectacle and (now) skanlite). So, unless I am missing something about general KDE UI guidelines, consistency is not there. Also because, IMHO, it can make little sense depending upon the type of user interaction. Those programs meant to rely on user text input often have a File menu (konsole, kate). Those meant to work on mouse and gestures don't and would requires an explicit Quit button (skanlite, system settings). Those meant to automatically exit after a single use don't need either (spectacle). Finally, all keyboard shortcut can be removed/redefined: ALT+F4 (KWin: close window), CTRL+Q (Navigation: quit), CTRL+W, CTRL+ESC (File: close). And all window decorations/widgets can be removed. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #19 from Eric Armbruster --- The close button has been removed to be consistent with Spectacle. I do not quite understand why you see the need for an additional close button. Even if you decide to remove the close action from the window titlebar or disable the titlebar completly and remove default close shortcut Ctrl+Q, you still have the option to close by pressing the window manager shortcut (Alt+F4). That should be more than enough options to close an application. If you manage to remove all your close options and want to close your application, well then enable at least one of them again, which you could do without problems from the shortcuts menu. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #18 from EnzoR --- Version 22.04 has no "CLOSE" button and the focus is not set to any specific element in the window. So hitting ENTER won't close the application. Good. But now I can make skanlite not closeable by the user if the window widgets are removed and the keyboard shortcut are redefined. Bad. IMHO, you could close this bug by just leaving the focus unspecified and still keeping the "CLOSE" button. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #17 from Eric Armbruster --- This should be fixed in 22.04 which just got released today. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #16 from EnzoR --- As of version 21.12.3 focus starts on the "Close" button. If I do a preview, the focus keeps staying there. Same if I select an area. Hitting "Enter" just closes the application. Focus should not stay anywhere by default: the application needs to close only on explicit user request: - "Close" button - Window menu --> close - ALT+F4 - CTRL+Q -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #15 from EnzoR --- Created attachment 145853 --> https://bugs.kde.org/attachment.cgi?id=145853=edit PKGBUILD for Archlinux skanlite https://github.com/archlinux/svntogit-packages/blob/packages/skanlite/trunk/PKGBUILD -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #14 from EnzoR --- It looks like there is no patch applied by Archlinux: https://github.com/archlinux/svntogit-packages/blob/packages/skanlite/trunk/PKGBUILD -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #13 from EnzoR --- Eric and myself have the same issue, though. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #12 from EnzoR --- Window button can be removed and shortcuts redefined. Explicit button is the only guaranteed way of closing it. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #11 from Kåre Särs --- This bug is really strange! Me and Alexander, cannot reproduce... I have tested both on Wayland and X11 Are there any Archlinux specific patches? The button removal is mainly to get it more in line with Spectacle's UI. Alt-F4 and Ctrl-Q quits the application and you have the normal close button on the Window, so you might not really need the separate close-button. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #10 from EnzoR --- Maybe I am wrong, but the "Close" button should stay there. It simply should never get focus automatically: the user is the only one who knows whether the task is over or not. And she/he can communicate this by explicitly clicking on the "Close" button. IMHO, there should be no automatic focus or focus shift. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 Eric Armbruster changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||eric1.armbrus...@gmail.com Ever confirmed|0 |1 --- Comment #9 from Eric Armbruster --- I can reproduce this bug in the 21.12. https://invent.kde.org/graphics/skanlite/-/merge_requests/28 would partially fix this bug as well by removing the close button. In my MR I have called setAutoDefault(false); on the other buttons to prevent them from getting the focus after removing the close button. Auto default seems to be enabled by default for these buttons, see https://doc.qt.io/qt-5/qpushbutton.html#autoDefault-prop. I guess a separate MR for libksane would be required to make Scan the default button, if this is desired. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #8 from Enzo --- All is confirmed. As soon as I open the application it has the focus on "Close" and it is kept there. If I click on "Help" or "About" buttons the focus goes there but the it returns back to "Close". Same goes for "Preview" and "Scan". "Reselect scanner device" and "Settings" move the focus away but it goes back to "Close" as soon as I move the focus away from the application. Skanlite: 21.12.1 (21.12.1-1) KDE Frameworks: 5.90.0 (I don't know how to check Qt version for this program). -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #7 from Alexander Stippich --- I cannot reproduce with 21.12. either. Focus is on the Scan button for me after a scan has finished -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #6 from Kåre Särs --- That is strange, I'm using the KDE Gear 21.12.0, KF5 5.89.0 and Qt 5.15.3 version on KDE Neon and I can't even get the focus to the close button (Esc closes the window so not a problem). -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #5 from Enzo --- 4. It stays on "Close" even after an explicit scan. It looks like the default action for this program is to "Close" since its very startup. It's not clear to me the objective of that "focus handling rework". Maybe my original "suggestion" (https://bugs.kde.org/show_bug.cgi?id=444605#c0) isn't that great but I'd say the current default action isn't either. -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #4 from Enzo --- Yes. In v21.12.1 (ArchLinux package is labelled as 21.12.1-1): 1. The focus starts on the "Close" button and 2. remains there once I click on the preview area. 3. It stays on the "Close" button even after I explicitly I do a "Preview". -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #3 from Alexander Stippich --- Is this still occuring with Skanlite 21.12? -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 --- Comment #2 from Enzo --- Latest in Arch Linux: 21.08.2 -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 444605] Default focus is put on button "Close": hitting ENTER closes the program
https://bugs.kde.org/show_bug.cgi?id=444605 Alexander Stippich changed: What|Removed |Added CC||a.stipp...@gmx.net --- Comment #1 from Alexander Stippich --- Which version are you using? The focus handling has been reworked in git master or the next release of Skanlite in KDE Gear 21.12 -- You are receiving this mail because: You are watching all bug changes.
