[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 Alexander Reinholdt changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/netw ||ork/smb4k/commit/312a97e434 ||766a77ccadc38fd9f780b17ebdb ||9b7 --- Comment #8 from Alexander Reinholdt --- Git commit 312a97e434766a77ccadc38fd9f780b17ebdb9b7 by Alexander Reinholdt. Committed on 27/10/2020 at 05:48. Pushed by areinholdt into branch 'master'. Improved the way shares are bookmarked in the mount dialog. During this modification, also some members in class Smb4KBookmark were renamed and the code adjusted accordingly. Also, several bugs were identified and fixed. M +6-6core/smb4kbookmark.cpp M +8-8core/smb4kbookmark.h M +62 -22 core/smb4kbookmarkhandler.cpp M +19 -10 core/smb4kbookmarkhandler.h M +480 -254 core/smb4kbookmarkhandler_p.cpp M +13 -105 core/smb4kbookmarkhandler_p.h M +6-4core/smb4kmounter.cpp M +347 -79 core/smb4kmounter_p.cpp M +35 -36 core/smb4kmounter_p.h M +3-3plasmoid/package/contents/ui/BookmarkItemDelegate.qml M +17 -17 plasmoid/package/contents/ui/BookmarksPage.qml M +1-1plasmoid/package/contents/ui/NetworkBrowserPage.qml M +18 -18 plasmoid/plugin/smb4kbookmarkobject.cpp M +12 -12 plasmoid/plugin/smb4kbookmarkobject.h M +29 -35 plasmoid/plugin/smb4kdeclarative.cpp M +14 -6plasmoid/plugin/smb4kdeclarative.h M +1-1plasmoid/plugin/smb4kdeclarative_p.h M +63 -83 smb4k/smb4kbookmarkmenu.cpp M +4-6smb4k/smb4kbookmarkmenu.h https://invent.kde.org/network/smb4k/commit/312a97e434766a77ccadc38fd9f780b17ebdb9b7 -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #7 from Bernhard Lindner --- I guess this would improve usage definitely. BTW my co-worker (who is software developer as well) also didn't understand the GUI the right way. So it isn't only me :-) -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #6 from Alexander Reinholdt --- Thank you for the explanation. Maybe it would be best to implement a combination of the three ways you mentioned. So, it would also not be necessary anymore to show the 'Add Bookmark' dialog when bookmarking a share via the mount dialog. -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #5 from priv...@bernhard-lindner.de --- Hm. I think this is a misunderstanding. I assumed workgroup and group is the same thing. If workgroup (a network setting?) is different from group (only a bookmark category?) I was simply confused by the GUI of smb4k. When creating a shared folder (including the optional bookmark) I can enter "workgroup", but no "group". When managing bookmarks I can change the "group" but not the "workgroup". Can this be improved? I could think of three improvements: 1. When creating a shared folder and (by ticking the checkbox) the optional bookmark, a "group" line-input could be shown. 2. When managing bookmarks there could be a workgroup line-input along with the line-inputs for IP address and group. 3. If a workgroup was entered but no group, smb4k could use the workgroup for categorizing the bookmarks (I guess users that entered a workgroup do not want to repeat the same string as a group to get expected bookmark categorization). -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #4 from Alexander Reinholdt --- Thank you for reporting this issue! I tried to reproduce it with the latest development version (the code of the bookmark handling did not change (much)), but I did not succeed. I opened the 'Add Bookmark' dialog in the network neighborhood browser and added the group 'test' to the bookmark (see first attachment). The bookmark appears correctly under the group 'test' in the bookmark menu (second attachment) and in the bookmark editor (third attachment). If you did something else, could you please add information on what you exactly did, so that I can track down the issue. -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #2 from Alexander Reinholdt --- Created attachment 132510 --> https://bugs.kde.org/attachment.cgi?id=132510=edit Bookmark in bookmark menu -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #3 from Alexander Reinholdt --- Created attachment 132511 --> https://bugs.kde.org/attachment.cgi?id=132511=edit Bookmark in editor -- You are receiving this mail because: You are watching all bug changes.
[Smb4k] [Bug 427478] New bookmarks discard workgroup
https://bugs.kde.org/show_bug.cgi?id=427478 --- Comment #1 from Alexander Reinholdt --- Created attachment 132509 --> https://bugs.kde.org/attachment.cgi?id=132509=edit Add bookmark in Smb4K -- You are receiving this mail because: You are watching all bug changes.
