[Spectacle] [Bug 389695] Save action should show notification popup just like Save & Exit

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=389695

Henrik Fehlauer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/spe
   ||ctacle/7034b50c5c9ef9c97ec0
   ||b7741f3667a93d9a567a
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Henrik Fehlauer  ---
Git commit 7034b50c5c9ef9c97ec0b7741f3667a93d9a567a by Henrik Fehlauer.
Committed on 14/02/2018 at 22:46.
Pushed by rkflx into branch 'master'.

Add action to open screenshots folder to tools menu

Summary:
With {nav Quit after Save or Copy} checked, there is a desktop
notification when saving which allows to open the folder containing the
saved screenshot. However, when the user opts to let the window stay
open, only the title will reflect the filename of the saved screenshot.
It's quite hard to know in which folder it was saved and not that easy
to open that folder.

By introducing {nav Tools > Open Screenshots Folder}, usability in that
regard is much-improved. When no screenshot has been saved yet, it will
open the last {nav Save As} folder or the default {nav Save} location
depending on the button state. As soon as a screenshot is saved, the
new action will highlight the new screenshot in the filemanager.

Depends on D10467
Ref T7841

Test Plan:
For {nav Save} and {nav Save As} each, click on new menu entry after
starting Spectacle as well as after saving. Also test everything with
`fish:/` (but beware of Bug 390297).

{F5705490}

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham

Maniphest Tasks: T7841

Differential Revision: https://phabricator.kde.org/D10470

M  +1-1doc/index.docbook
M  +11   -1src/ExportManager.cpp
M  +3-1src/ExportManager.h
M  +29   -1src/Gui/KSMainWindow.cpp
M  +1-0src/Gui/KSMainWindow.h

https://commits.kde.org/spectacle/7034b50c5c9ef9c97ec0b7741f3667a93d9a567a

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389695] Save action should show notification popup just like Save & Exit

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389695

--- Comment #5 from Nate Graham  ---
With https://phabricator.kde.org/D10301, #s 1 and 2 are probably fine for now,
so feel free to make it a BUG:

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389695] Save action should show notification popup just like Save & Exit

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=389695

--- Comment #4 from Henrik Fehlauer  ---
Not sure about that. For #2, you can already configure the notification
specific to Spectacle from the notification itself and via systemsettings.

For #1, I would not want to turn in on by default. We could add a second type
of notification turned off by default, but then I guess nobody would ever use
it. Combining #1 und #2 into a single option is also not really what I want.

Let me know if I should make my patch for #3 a "BUG" or a "CCBUG".

Also, #3 is basically ready. I need to adapt the docbook, but I'll do that once
D10295 landed and you rebased D10301 on that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389695] Save action should show notification popup just like Save & Exit

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389695

Nate Graham  changed:

   What|Removed |Added

Summary|Save action should show |Save action should show
   |Plasma popup just like Save |notification popup just
   |& Exit  |like Save & Exit

-- 
You are receiving this mail because:
You are watching all bug changes.