[Spectacle] [Bug 394182] Customized screenshot directory is not respected in certain actions

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=394182

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||18.12.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394182] Customized screenshot directory is not respected in certain actions

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=394182

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/spe
   ||ctacle/74a2df918f87d81eba16
   ||117bb6ae242f6ab07937
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Nate Graham  ---
Git commit 74a2df918f87d81eba16117bb6ae242f6ab07937 by Nate Graham, on behalf
of Kyle Utecht.
Committed on 15/10/2018 at 19:52.
Pushed by ngraham into branch 'master'.

clarify logic for openScreenshotsFolder, refactor preferences access, and
clarify method names

Summary:
New openScreenshotsFolder logic is to highlight recently saved file, then
default save location
(save mode) or last saved file's folder (save as mode) with failsafe as default
save location.
SpectacleConfig now stores the last saved files and can determine the last
saved file location from the
file name through separate method. Removed extraneous methods and variables
from ExportManager.
ExportManager now uses SpectacleConfig to access save location preferences.

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D15908

M  +8-26   src/ExportManager.cpp
M  +1-6src/ExportManager.h
M  +21   -14   src/Gui/KSMainWindow.cpp
M  +2-2src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +30   -6src/SpectacleConfig.cpp
M  +11   -5src/SpectacleConfig.h

https://commits.kde.org/spectacle/74a2df918f87d81eba16117bb6ae242f6ab07937

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394182] Customized screenshot directory is not respected in certain actions

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=394182

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394182] Customized screenshot directory is not respected in certain actions

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=394182

Henrik Fehlauer  changed:

   What|Removed |Added

   Keywords||junior-jobs
 Status|UNCONFIRMED |CONFIRMED
 CC||rk...@lab12.net
 Ever confirmed|0   |1

--- Comment #1 from Henrik Fehlauer  ---
Well, you spotted a valid inconsistency in the UI.

Technically, your are only setting the default location for the Save button,
and the "Open screenshot folder" action as well as the "Save As" action default
to the regular XDG Pictures location in case you did not save a screenshot
before (the last used location should then be remembered for the next
invocation).

As the Save location setting defaults to the same XDG Pictures folder, I think
it makes sense to use this setting also for the other actions as a default if
the user has customized it.

Marking this as a junior job to indicate this is an easy bug to get started
with.

-- 
You are receiving this mail because:
You are watching all bug changes.