[Spectacle] [Bug 394183] Allow "/" in customized screenshot directory settings to dive into auto-created monthly subdirectories /%Y/%M/

2018-05-28 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=394183

Henrik Fehlauer  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/spe |https://commits.kde.org/spe
   |ctacle/0dcd790a03b0a25babbd |ctacle/1612995b54038225e345
   |2a36f59ea809caf207ac|064754e6ede2e589fd9f

--- Comment #4 from Henrik Fehlauer  ---
Git commit 1612995b54038225e345064754e6ede2e589fd9f by Henrik Fehlauer, on
behalf of Marco Scarpetta.
Committed on 28/05/2018 at 22:46.
Pushed by rkflx into branch 'master'.

Allow saving screenshots in custom auto-generated subdirectories

Summary:
This patch allow the use of "/" in the filename field of the config dialog to
save screenshots in auto-generated subdirectories inside the default save
directory.

Test Plan: Tested for local and remote (Google Drive) save locations.

Reviewers: #spectacle, rkflx

Reviewed By: #spectacle, rkflx

Subscribers: ngraham, rkflx, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D12993

M  +45   -3src/ExportManager.cpp
M  +6-0src/Gui/SettingsDialog/SaveOptionsPage.cpp

https://commits.kde.org/spectacle/1612995b54038225e345064754e6ede2e589fd9f

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394183] Allow "/" in customized screenshot directory settings to dive into auto-created monthly subdirectories /%Y/%M/

2018-05-28 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=394183

Henrik Fehlauer  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/spe
   ||ctacle/0dcd790a03b0a25babbd
   ||2a36f59ea809caf207ac
 Resolution|--- |FIXED

--- Comment #3 from Henrik Fehlauer  ---
Git commit 0dcd790a03b0a25babbd2a36f59ea809caf207ac by Henrik Fehlauer.
Committed on 28/05/2018 at 22:42.
Pushed by rkflx into branch 'master'.

Allow saving screenshots in custom auto-generated subdirectories

Summary:
This patch allow the use of "/" in the filename field of the config dialog to
save screenshots in auto-generated subdirectories inside the default save
directory.

Test Plan: Tested for local and remote (Google Drive) save locations.

Reviewers: #spectacle, rkflx

Reviewed By: #spectacle, rkflx

Subscribers: ngraham, rkflx, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D12993

M  +45   -3src/ExportManager.cpp
M  +6-0src/Gui/SettingsDialog/SaveOptionsPage.cpp

https://commits.kde.org/spectacle/0dcd790a03b0a25babbd2a36f59ea809caf207ac

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394183] Allow "/" in customized screenshot directory settings to dive into auto-created monthly subdirectories /%Y/%M/

2018-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394183

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394183] Allow "/" in customized screenshot directory settings to dive into auto-created monthly subdirectories /%Y/%M/

2018-05-21 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=394183

--- Comment #2 from Henrik Fehlauer  ---
Patch available in https://phabricator.kde.org/D12993.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 394183] Allow "/" in customized screenshot directory settings to dive into auto-created monthly subdirectories /%Y/%M/

2018-05-13 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=394183

Henrik Fehlauer  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||rk...@lab12.net
   Keywords||junior-jobs

--- Comment #1 from Henrik Fehlauer  ---
Nice idea, makes sense to me.

To make this discoverable, I guess it's enough to add a help text to the config
dialog similar to what's done for the other placeholders.

However, note that some sanitizing still needs to happen, e.g. for window
titles containing "/". Only "/" explicitly added in the config dialog should
result in the creation of a directory.

-- 
You are receiving this mail because:
You are watching all bug changes.