[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482605

--- Comment #9 from Noah Davis  ---
(In reply to Jet from comment #6)
> if i hold shift, but not move the cursor, it wont
> appear until i do move it. I would expect the magnifier view to update
> independent of cursor movement

It should appear next to the mouse cursor without needing to move the cursor.
At least that's how it works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=482605

Nate Graham  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #8 from Nate Graham  ---
It sounds like it was in fact working as expected and you need to hold the
Shift key to use it. This will be customizable in the 24.05 release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482605

--- Comment #7 from Noah Davis  ---
Git commit 37dc6a8839f56cc6daca1f125d1b83b7f6251508 by Noah Davis.
Committed on 08/03/2024 at 14:01.
Pushed by ndavis into branch 'master'.

Change showMagnifier setting to toggle between Never, Always and While holding
the Shift key

Previously, it showed the magnifier only while the shift key was held or not at
all.

M  +1-1src/Gui/ImageCaptureOverlay.qml
M  +4-2src/Gui/SelectionEditor.cpp
M  +27   -25   src/Gui/SettingsDialog/GeneralOptions.ui
M  +8-3src/Gui/SettingsDialog/spectacle.kcfg
M  +6-2src/Gui/ShortcutsTextBox.qml

https://invent.kde.org/graphics/spectacle/-/commit/37dc6a8839f56cc6daca1f125d1b83b7f6251508

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-07 Thread Jet
https://bugs.kde.org/show_bug.cgi?id=482605

--- Comment #6 from Jet  ---
(In reply to Noah Davis from comment #5)
> (In reply to Jet from comment #4)
> > (In reply to Nate Graham from comment #3)
> > > Does it work if you hold down the Shift key while dragging?
> > 
> > Well yes it does, but it didn't require holding shift before, is this
> > intended?
> 
> Yes, mainly because that was how it was originally supposed to work in
> 22.12. You can also see in the help box for the rectangle selection that the
> magnifier is only supposed to show while shift is held, but the behavior was
> unintentionally changed somewhere between 23.04 and 24.02. The next version
> of Spectacle will have a better version of the setting with more explicit
> behavior: https://invent.kde.org/graphics/spectacle/-/merge_requests/338

Well in that case, i noticed that it isn't explained very well in the settings
panel, and that if i hold shift, but not move the cursor, it wont appear until
i do move it. I would expect the magnifier view to update independent of cursor
movement

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-07 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482605

--- Comment #5 from Noah Davis  ---
(In reply to Jet from comment #4)
> (In reply to Nate Graham from comment #3)
> > Does it work if you hold down the Shift key while dragging?
> 
> Well yes it does, but it didn't require holding shift before, is this
> intended?

Yes, mainly because that was how it was originally supposed to work in 22.12.
You can also see in the help box for the rectangle selection that the magnifier
is only supposed to show while shift is held, but the behavior was
unintentionally changed somewhere between 23.04 and 24.02. The next version of
Spectacle will have a better version of the setting with more explicit
behavior: https://invent.kde.org/graphics/spectacle/-/merge_requests/338

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-07 Thread Jet
https://bugs.kde.org/show_bug.cgi?id=482605

--- Comment #4 from Jet  ---
(In reply to Nate Graham from comment #3)
> Does it work if you hold down the Shift key while dragging?

Well yes it does, but it didn't require holding shift before, is this intended?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=482605

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Nate Graham  ---
Does it work if you hold down the Shift key while dragging?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482605] Magnifier no longer works

2024-03-07 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=482605

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
Summary|Maginifier no longer works  |Magnifier no longer works

-- 
You are receiving this mail because:
You are watching all bug changes.