[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/pim/ ||akregator/commit/b665d515cb ||025cbad11ff129aed8fe0467d9f ||476 Status|ASSIGNED|RESOLVED --- Comment #11 from Albert Astals Cid --- Git commit b665d515cb025cbad11ff129aed8fe0467d9f476 by Albert Astals Cid, on behalf of Lukáš Turek. Committed on 08/02/2021 at 23:30. Pushed by aacid into branch 'master'. Fix Bug 397752 - HTML articles appear very small GrantleeViewFormatter converts user configured font size from points to pixels, but there's no such conversion in AkregatorPart, where QWebEngineSettings::setFontSize also expects the font size in pixels. As a result fonts on sites using relative units (em or rem) are small, unless DPI is close to 72. The point to pixel conversion should be either in both places, or none. I chose the latter option, because then the font sizes in Akregator match values in Falkon. M +1-1src/formatter/grantleeviewformatter.cpp https://invent.kde.org/pim/akregator/commit/b665d515cb025cbad11ff129aed8fe0467d9f476 -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #10 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/pim/akregator/-/merge_requests/8 -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 Christoph Feck changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |REPORTED --- Comment #9 from Christoph Feck --- New information was added with comment 7 and earlier; changing status for inspection. -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 --- Comment #8 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 --- Comment #7 from Lukáš Turek <8...@8an.cz> --- I have a 1920x1200 display with DPI set to 110, which is still much more than 72 DPI where pixels and points match. I set Medium font size in Akregator to 16, which is the desired value in pixels, roughly matching 10pt set in KDE. QWebEngineSettings::setFontSize also expects the font size in pixels, so the conversion should be either in both places, or none. I chose the latter option, because the font sizes in Akregator then match values in Falkon. -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752
Laurent Montel changed:
What|Removed |Added
CC||mon...@kde.org
--- Comment #6 from Laurent Montel ---
(In reply to Lukáš Turek from comment #1)
> I have the same problem, but only on some feeds (websites): those that don't
> set fixed font size (in pt or px), but use relative units (em or rem).
>
> I think it happens because QWebEngineSettings::DefaultFontSize expects the
> size in pixels, not points. However, GrantleeViewFormatter converts the
> configured Medium Font Size from points to pixels. This inconsistency means
> that depending on what Medium Font Size you set, you will either have normal
> fonts on websites and huge fonts in feeds, or tiny fonts on websites and
> normal fonts in feeds.
>
> The simplest fix would be to drop the conversion in GrantleeViewFormatter,
> but that would change font size in feeds for current users.
"src/akregator_part.cpp:684:
QWebEngineSettings::defaultSettings()->setFontSize(QWebEngineSettings::DefaultFontSize,
Settings::mediumFontSize());"
=> we use correct settings in QWebEngineSettings::defaultSettings() we don't
convert it.
In grantlee html file wr use
"grantleeObject.insert(QStringLiteral("mediumFontSize"),
pointsToPixel(Settings::mediumFontSize()));"
because
"rc/formatter/html/5.2/combinedview.html:9:font-size: {{ mediumFontSize}}px
! important;
src/formatter/html/5.2/combinedview.html:65:font-size:
{{mediumFontSize}}px;
src/formatter/html/5.2/combinedview.html:70:font-size: {{
mediumFontSize}}px;
src/formatter/html/5.2/defaultnormalvisitfeed.html:8:font-size: {{
mediumFontSize}}px ! important;
src/formatter/html/5.2/defaultnormalvisitfolder.html:8:font-size: {{
mediumFontSize}}px ! important;
src/formatter/html/5.2/normalview.html:8:font-size: {{ mediumFontSize}}px !
important;
src/formatter/html/5.2/normalview.html:50:font-size: {{ mediumFontSize}}px;
src/formatter/html/5.2/normalview.html:55:font-size: {{ mediumFontSize}}px;
"
we use px on html directly.
Which resolution do you use ? 4K ?
--
You are receiving this mail because:
You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 --- Comment #5 from Justin Zobel --- (In reply to Lukáš Turek from comment #3) > Created attachment 133639 [details] > Remove pointsToPixel conversion Lukáš can you please submit this as a merge request to https://invent.kde.org/pim/akregator -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 --- Comment #4 from Lukáš Turek <8...@8an.cz> --- I didn't test 20.08.3 yet, but the attached patch fixes the problem for me in 20.04.3 and it would apply to current GIT. -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 --- Comment #3 from Lukáš Turek <8...@8an.cz> --- Created attachment 133639 --> https://bugs.kde.org/attachment.cgi?id=133639=edit Remove pointsToPixel conversion -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 Justin Zobel changed: What|Removed |Added CC||justin.zo...@gmail.com Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Justin Zobel --- Thanks for the report. As it's been a little while since this report was received can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved. I've set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks. -- You are receiving this mail because: You are watching all bug changes.
[akregator] [Bug 397752] HTML articles appear very small
https://bugs.kde.org/show_bug.cgi?id=397752 Lukáš Turek <8...@8an.cz> changed: What|Removed |Added CC||8...@8an.cz --- Comment #1 from Lukáš Turek <8...@8an.cz> --- I have the same problem, but only on some feeds (websites): those that don't set fixed font size (in pt or px), but use relative units (em or rem). I think it happens because QWebEngineSettings::DefaultFontSize expects the size in pixels, not points. However, GrantleeViewFormatter converts the configured Medium Font Size from points to pixels. This inconsistency means that depending on what Medium Font Size you set, you will either have normal fonts on websites and huge fonts in feeds, or tiny fonts on websites and normal fonts in feeds. The simplest fix would be to drop the conversion in GrantleeViewFormatter, but that would change font size in feeds for current users. -- You are receiving this mail because: You are watching all bug changes.
