[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=390063

--- Comment #7 from thomasvondere...@gmx.de ---
Thank you! Wonderful! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

[Tuomas Nurmi]

https://bugs.kde.org/show_bug.cgi?id=390063

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/6b10
   ||f5d938634570dc3cc11ce308e82
   ||ae9a5e019

--- Comment #6 from Tuomas Nurmi  ---
Git commit 6b10f5d938634570dc3cc11ce308e82ae9a5e019 by Tuomas Nurmi.
Committed on 22/05/2024 at 17:33.
Pushed by nurmi into branch 'master'.

Don't feed analyzer new data if it is minimized or hidden

M  +1-0ChangeLog
M  +1-0src/MainWindow.h
M  +7-1src/context/applets/analyzer/plugin/AnalyzerBase.cpp
M  +4-1src/context/applets/analyzer/plugin/AnalyzerBase.h
M  +4-0src/context/applets/analyzer/plugin/BlockAnalyzer.cpp

https://invent.kde.org/multimedia/amarok/-/commit/6b10f5d938634570dc3cc11ce308e82ae9a5e019

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=390063

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/multimedia/amarok/-/merge_requests/98

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=390063

--- Comment #4 from thomasvondere...@gmx.de ---
Thank you for reopening the bug!

And thank you for improving the description of the bug! It's clearer now.

Now one question remains for me: Now that we agree, that the Analyzer should be
disabled when the Context View is disabled  shouldn't the Analyzer also
pause, when Amarok is idle and minimized? 

Why waste precious resources in this case?

Should I open an additional bug report for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

[Myriam Schweingruber]

https://bugs.kde.org/show_bug.cgi?id=390063

Myriam Schweingruber  changed:

   What|Removed |Added

 Resolution|INVALID |---
Summary|Amarok Analyzer takes up|Anazyler should be disabled
   |CPU even if Amarok is idle  |when the Context View is
   |and minimzed|disabled, instead keeps
   ||running
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #3 from Myriam Schweingruber  ---
Right, changing description of the bug, then, as the initial one is not really
clear.

-- 
You are receiving this mail because:
You are watching all bug changes.