[ark] [Bug 222392] Ark does not properly stop an archive creation

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

Elvis Angelaccio  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/ark/
   ||074d52778f68c2b1456ba54633b
   ||ace8e37cb
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In|15.12   |16.08.0

--- Comment #38 from Elvis Angelaccio  ---
Git commit 074d52778f68c2b1456ba54633bace8e37cb by Elvis Angelaccio.
Committed on 30/04/2016 at 11:02.
Pushed by elvisangelaccio into branch 'master'.

Don't block the main thread while running CliInterface jobs

Currently we freeze the GUI thread while running CliInterface jobs,
because there is a nested event loop in runProcess(),
which doesn't run anymore in a separate thread.

We can simply drop this event loop and rework the CliInterface logic,
such that the emit signal is not emitted anymore when runProcess() returns,
but in processFinished() instead.

This exposed a crash when closing the main window while a pending job was
running. The fix is simply to not emit finished() if the m_abortingOperation
flag is set.
Related: bug 193908
FIXED-IN: 16.08.0

Differential Revision: D1510

M  +4-8kerfuffle/archiveinterface.h
M  +116  -86   kerfuffle/cliinterface.cpp
M  +13   -3kerfuffle/cliinterface.h
M  +0-1part/jobtracker.cpp
M  +0-1plugins/cliunarchiverplugin/cliplugin.cpp

http://commits.kde.org/ark/074d52778f68c2b1456ba54633bace8e37cb

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 222392] Ark does not properly stop an archive creation

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

--- Comment #37 from Elvis Angelaccio  ---
Git commit 8c21ca3ae9326d772e2f037c4f79ba9ca10af6ad by Elvis Angelaccio.
Committed on 23/04/2016 at 13:20.
Pushed by elvisangelaccio into branch 'Applications/16.04'.

libarchive: properly stop all jobs

We use the m_abortOperation flag in the same way ListJob does (see commit
acb455da04).

We also need to remove the disconnect() in the Job destructor, which makes Ark
crash if we stop an AddToArchive job. This disconnect() looks like a relic of
the
past (see e.g. commit 15fce6f5) and doesn't seem really necessary.

Note that the CliInterface jobs still need to be fixed. So do batch extract
jobs, which are KCompositeJobs and currently ignore the kill button in the
systray.

Differential Revision: D1466

M  +0-2kerfuffle/jobs.cpp
M  +3-1plugins/libarchive/libarchiveplugin.cpp
M  +1-1plugins/libarchive/libarchiveplugin.h
M  +12   -3plugins/libarchive/readwritelibarchiveplugin.cpp

http://commits.kde.org/ark/8c21ca3ae9326d772e2f037c4f79ba9ca10af6ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 222392] Ark does not properly stop an archive creation

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

--- Comment #36 from Elvis Angelaccio  ---
The backtrace in duplicate #358937 is likely more updated than the OP's.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 222392] Ark does not properly stop an archive creation

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||mikae...@yahoo.com

--- Comment #35 from Elvis Angelaccio  ---
*** Bug 358937 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 222392] Ark does not properly stop an archive creation

[Julio J . via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

Julio J.  changed:

   What|Removed |Added

 CC|julioelpo...@gmail.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 222392] Ark does not properly stop an archive creation

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=222392

Elvis Angelaccio  changed:

   What|Removed |Added

   Assignee|rak...@freebsd.org  |elvis.angelac...@kdemail.ne
   ||t

-- 
You are receiving this mail because:
You are watching all bug changes.