[choqok] [Bug 251164] Copy shortcut does not work

2018-06-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=251164

Christoph Feck  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED
   Assignee|braxtonsal...@gmail.com |mehrdad.mom...@gmail.com

--- Comment #14 from Christoph Feck  ---
Assignee not responding.

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=251164

--- Comment #13 from Christoph Feck  ---
Braxton, any update?

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-04-26 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=251164

--- Comment #12 from Christoph Feck  ---
If you have an updated patch, please add here or to
https://phabricator.kde.org/differential/diff/create/

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=251164

--- Comment #11 from Christoph Feck  ---
Is there a reason why you only set the first shortcut? There is also a
QAction::setShortcuts() method that accepts the complete list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-17 Thread Braxton Salyer
https://bugs.kde.org/show_bug.cgi?id=251164

Braxton Salyer  changed:

   What|Removed |Added

 Attachment #111468|0   |1
is obsolete||

--- Comment #10 from Braxton Salyer  ---
Created attachment 111469
  --> https://bugs.kde.org/attachment.cgi?id=111469&action=edit
Patch the bug by adding Copy and Select-All Shortcuts

Sorry, forgot to click the "Patch" checkbox the first time ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-17 Thread Braxton Salyer
https://bugs.kde.org/show_bug.cgi?id=251164

Braxton Salyer  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|mehrdad.mom...@gmail.com|braxtonsal...@gmail.com

--- Comment #9 from Braxton Salyer  ---
Created attachment 111468
  --> https://bugs.kde.org/attachment.cgi?id=111468&action=edit
Patch the bug by adding Copy and Select-All Shortcuts

Got Choqok working from source. turns out it was a (sort of) environment issue.


Anyways the possible patch a mentioned before works.
This patch adds Copy and Select-All Shortcuts to Choqok.

I'm also going to submit this on phabricator

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-17 Thread Braxton Salyer
https://bugs.kde.org/show_bug.cgi?id=251164

--- Comment #8 from Braxton Salyer  ---
(In reply to Anders Lund from comment #7)
> I believe kirigami was not even thought of at the time of reporting - but
> nice 
> if a port can solve this ;)
> 
> Anders

ahh that's true. I might not have looked at the dates when I posted my reply
haha

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-17 Thread Anders Lund
https://bugs.kde.org/show_bug.cgi?id=251164

--- Comment #7 from Anders Lund  ---
I believe kirigami was not even thought of at the time of reporting - but nice 
if a port can solve this ;)

Anders

-- 
You are receiving this mail because:
You are watching all bug changes.

[choqok] [Bug 251164] Copy shortcut does not work

2018-03-16 Thread Braxton Salyer
https://bugs.kde.org/show_bug.cgi?id=251164

Braxton Salyer  changed:

   What|Removed |Added

 CC||braxtonsal...@gmail.com

--- Comment #6 from Braxton Salyer  ---
I think this may currently be a design decision from the choqok team until the
app gets ported to kirigami, as it clearly used to rely on kde4libs and simply
has the relevant code commented out.

That said, for some reason, this segfaults for me when I build from source
BEFORE I make any changes, but I have come up with a possible? fix for this
particular thing if someone else wants to try it out:

in cmakelists.txt insert at line 60

KF5::ConfigGui

in /libchoqok/ui/textbrowser.cpp insert at line 37

#include 

replace line 122 w/

copy->setShortcut( KStandardShortcut::copy().at(0) );

replace line 133 w/

selectAll->setShortcut( KStandardShortcut::selectAll().at(0) );

-- 
You are receiving this mail because:
You are watching all bug changes.