[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Sergio Martins]

https://bugs.kde.org/show_bug.cgi?id=385476

Sergio Martins  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Sergio Martins]

https://bugs.kde.org/show_bug.cgi?id=385476

--- Comment #4 from Sergio Martins  ---
The fixit had some bugs, it's a bit complicated to cover all edge-cases, so I
decided to just use the simplest implementation, so it can be a level 0 check.

Thanks for your suggestion, auto connected slots should really die

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Sergio Martins]

https://bugs.kde.org/show_bug.cgi?id=385476

--- Comment #3 from Sergio Martins  ---
commit 23dba8277d0595f08d2ece41c5366f248b7719ff (HEAD -> master, origin/master)
Author: Sergio Martins 
Date:   Fri Dec 15 16:34:38 2017 +

new check: Introducing connect-by-name

"auto connections" aka "connect by name" aka "slots named on_object_signal"
are very flimsy
as code easily breaks if someone renames an object later.

Nowadays it's highly discouraged and unpopular.

Thanks to Nyall for the suggestion.

CCBUG: 385475
CCBUG: 385476

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Sergio Martins]

https://bugs.kde.org/show_bug.cgi?id=385476

Sergio Martins  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385476

eric.lemaniss...@gmail.com changed:

   What|Removed |Added

 CC||eric.lemaniss...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Sergio Martins]

https://bugs.kde.org/show_bug.cgi?id=385476

Sergio Martins  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
   Assignee|unassigned-b...@kde.org |smart...@kde.org

--- Comment #2 from Sergio Martins  ---
thanks!

I'll have a look sometime this week, currently traveling

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 385476] Warn on use of Qt autoconnected slots

[Nyall Dawson]

https://bugs.kde.org/show_bug.cgi?id=385476

--- Comment #1 from Nyall Dawson  ---
Patch submitted as https://phabricator.kde.org/D8187

-- 
You are receiving this mail because:
You are watching all bug changes.