[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Maik Qualmann changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||6.2.0 Latest Commit|https://commits.kde.org/dig |https://commits.kde.org/dig |ikam/65d063b749c66fdf012581 |ikam/fe9d5f511d0c4c1083c0c1 |b70e4bf7fe2c7186b8 |e6b0c6f37f2ab91b1d Status|REOPENED|RESOLVED --- Comment #19 from Maik Qualmann --- Git commit fe9d5f511d0c4c1083c0c1e6b0c6f37f2ab91b1d by Maik Qualmann. Committed on 15/04/2019 at 17:32. Pushed by mqualmann into branch 'master'. polish und corrections on resize tool FIXED-IN: 6.2.0 M +247 -291 core/dplugins/editor/transform/resize/resizetool.cpp M +4-3core/dplugins/editor/transform/resize/resizetool.h https://commits.kde.org/digikam/fe9d5f511d0c4c1083c0c1e6b0c6f37f2ab91b1d -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #18 from Maik Qualmann --- Git commit fc620b3a5766ba4e5085a99da33839c82139470c by Maik Qualmann. Committed on 15/04/2019 at 17:29. Pushed by mqualmann into branch 'master'. apply patch #119317 from Sambhav Dusad to add features to the resize tool M +2-1NEWS M +455 -46 core/dplugins/editor/transform/resize/resizetool.cpp M +4-0core/dplugins/editor/transform/resize/resizetool.h https://commits.kde.org/digikam/fc620b3a5766ba4e5085a99da33839c82139470c -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Sambhav Dusad changed: What|Removed |Added Attachment #119127|0 |1 is obsolete|| --- Comment #17 from Sambhav Dusad --- Created attachment 119317 --> https://bugs.kde.org/attachment.cgi?id=119317=edit Adds all the needed functionality in editor resize patch. I have modified the previous patch and this should solve all the previous errors or rounding and decimal places. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #16 from Maik Qualmann --- - When entering cm / mm / inch, it must be possible to enter decimal digits. - The range limits vary and are not set correctly when the units are changed. - When the units are changed, the result is constantly changing due to rounding errors and because no decimal digits are supported. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Sambhav Dusad changed: What|Removed |Added Attachment #118984|0 |1 is obsolete|| Attachment #119102|0 |1 is obsolete|| --- Comment #15 from Sambhav Dusad --- Created attachment 119127 --> https://bugs.kde.org/attachment.cgi?id=119127=edit Adds all the needed functionality in editor resize patch. I think this patch resolves all the previous errors. Please review it. Thanks for all the suggestions. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #14 from Sambhav Dusad --- Created attachment 119102 --> https://bugs.kde.org/attachment.cgi?id=119102=edit When changing units, previous value should be kept. But I can't access d->wInput->value() OR d->hInput->value() from slotUnitsChanged. And I can access d->resolution->value() from the same slot. Where am I doing wrong? Thanks -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Sambhav Dusad changed: What|Removed |Added Attachment #118326|0 |1 is obsolete|| --- Comment #13 from Sambhav Dusad --- Created attachment 118984 --> https://bugs.kde.org/attachment.cgi?id=118984=edit This patch adds combobox for units. user can also change resolution of the image in pixel/inch -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Maik Qualmann changed: What|Removed |Added Attachment #118202|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #12 from Sambhav Dusad --- Created attachment 118326 --> https://bugs.kde.org/attachment.cgi?id=118326=edit This patch adds different units like cm, inches, mm for image resizing. It also adds preset resolution combobox to image editor resize plugin. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Sambhav Dusad changed: What|Removed |Added Attachment #118016|0 |1 is obsolete|| Attachment #118052|0 |1 is obsolete|| Attachment #118067|0 |1 is obsolete|| Attachment #118166|0 |1 is obsolete|| --- Comment #11 from Sambhav Dusad --- Created attachment 118202 --> https://bugs.kde.org/attachment.cgi?id=118202=edit Added preset resolutions to the editor resize plugin. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #10 from Sambhav Dusad --- Created attachment 118166 --> https://bugs.kde.org/attachment.cgi?id=118166=edit Preserve Aspect Ratio by width or height added. The sliders are enabled even when Use Custom is not checked. Sorry for the inconvenience. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #9 from Maik Qualmann --- Hi Sambhav, I polished the code of the resize BQM plugin a bit. I noticed that the function "Use Pixels" does not work. Please look again at the code and check all options. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|FIXED |--- Version Fixed In|6.1.0 | Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 caulier.gil...@gmail.com changed: What|Removed |Added Version Fixed In||6.1.0 Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #8 from caulier.gil...@gmail.com --- Git commit 8689c3e549e3749547cde4b65f5e2f9c011f35f8 by Gilles Caulier. Committed on 14/02/2019 at 13:39. Pushed by cgilles into branch 'development/dplugins'. apply patch #118067 M +72 -48 core/dplugins/bqm/transform/resize/resize.cpp https://commits.kde.org/digikam/8689c3e549e3749547cde4b65f5e2f9c011f35f8 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #7 from Sambhav Dusad --- Created attachment 118067 --> https://bugs.kde.org/attachment.cgi?id=118067=edit Units are changed to radio buttons and Aspect Ratio Preserve checkbox added. QGridLayout is used to style the items. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|FIXED |--- Version Fixed In|6.1.0 | Status|RESOLVED|REOPENED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 --- Comment #6 from Sambhav Dusad --- Yeah, I already changed it and added radiobuttons. I was modifying the code more. So, thought of submitting the patch later Best, Sambhav Dusad On Thu 14 Feb, 2019, 01:46 Maik Qualmann, wrote: > https://bugs.kde.org/show_bug.cgi?id=279216 > > Maik Qualmann changed: > >What|Removed |Added > > > CC||metzping...@gmail.com >Version Fixed In||6.1.0 > > --- Comment #5 from Maik Qualmann --- > Hi Sambhav, > > please check the enabled state. If percent or centimeters are used, the > other > CheckBox must be disabled. Or use a QRadioButton group. Also, the value > slider > must be enabled if only percent or centimeter is checked. > > Maik > > -- > You are receiving this mail because: > You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com Version Fixed In||6.1.0 --- Comment #5 from Maik Qualmann --- Hi Sambhav, please check the enabled state. If percent or centimeters are used, the other CheckBox must be disabled. Or use a QRadioButton group. Also, the value slider must be enabled if only percent or centimeter is checked. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/dig ||ikam/65d063b749c66fdf012581 ||b70e4bf7fe2c7186b8 Status|REPORTED|RESOLVED --- Comment #4 from caulier.gil...@gmail.com --- Git commit 65d063b749c66fdf012581b70e4bf7fe2c7186b8 by Gilles Caulier. Committed on 13/02/2019 at 11:56. Pushed by cgilles into branch 'development/dplugins'. BQM resize tool: apply patch #118016 from Sambhav Dusad to add advanced settings. M +4-693 NEWS M +128 -24 core/dplugins/bqm/transform/resize/resize.cpp M +3-0core/dplugins/bqm/transform/resize/resizeplugin.cpp C +0-1project/NEWS.6.0.0 [from: NEWS - 099% similarity] https://commits.kde.org/digikam/65d063b749c66fdf012581b70e4bf7fe2c7186b8 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 Sambhav Dusad changed: What|Removed |Added Attachment #118003|0 |1 is obsolete|| --- Comment #3 from Sambhav Dusad --- Created attachment 118016 --> https://bugs.kde.org/attachment.cgi?id=118016=edit Changed the wrong code and added more functionality. The user can now choose from pixel, percent, cms, and inches as image units. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 279216] "Resize image" feature is missing some useful options [patch]
https://bugs.kde.org/show_bug.cgi?id=279216 caulier.gil...@gmail.com changed: What|Removed |Added Summary|"Resize image" feature is |"Resize image" feature is |missing some useful options |missing some useful options ||[patch] -- You are receiving this mail because: You are watching all bug changes.
