[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=317210

Mario Frank  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.5.0
  Latest Commit||https://commits.kde.org/dig
   ||ikam/834221c8d1300bbdd4ae78
   ||e345cdc0fce3e92be8

--- Comment #39 from Mario Frank  ---
Git commit 834221c8d1300bbdd4ae78e345cdc0fce3e92be8 by Mario Frank.
Committed on 09/02/2017 at 20:51.
Pushed by mfrank into branch 'master'.

Updated the news. The newly introduced garbage collection gets rid of
thumbnails in DB that are not referenced by any image any more.
FIXED-IN: 5.5.0

M  +2-1NEWS

https://commits.kde.org/digikam/834221c8d1300bbdd4ae78e345cdc0fce3e92be8

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #38 from caulier.gil...@gmail.com ---
New 5.5.0 AppImage is done with garbage database collector patches.
Uploading to GDrive is under progress. It will be online in few minutes at
usual
place :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

New database Garbage Collector options are there :

https://www.flickr.com/photos/digikam/32549923912/in/dateposted-public/
https://www.flickr.com/photos/digikam/32549923632/in/dateposted-public/

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=317210

Mario Frank  changed:

   What|Removed |Added

 CC||mario.fr...@uni-potsdam.de

--- Comment #37 from Mario Frank  ---
Hi, I just uploaded a patch in https://bugs.kde.org/show_bug.cgi?id=374591 that
introduces garbage collection as maintenance stage. This cleans the core,
thumbs and recognition db from stale entries. But be advised: The patch is
still in testing phase. I did some tests on my own databases and had no
problems. But just to be sure, backup your databases before you test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #36 from swatilodh...@gmail.com ---
I think that what happens now is partially right. 'Cause when an item is "Moved
to trash", it is just removed and not permanently deleted. So it is right to
exist in table with album=NULL

The issue lies when that item is "permanently" deleted and there's no change in
the Images table.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #35 from caulier.gil...@gmail.com ---
What's happen if you delete an album as well ? All item entries in DB are
properly removed ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #34 from caulier.gil...@gmail.com ---
It's clear. The table in DB must be cleaned properly. That all..

Probably the same dysfunction must exist with sqlite.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #33 from swatilodh...@gmail.com ---
Using digiKam 5.0.0, I did the following with MySQL DB:

1)Add photos in a new album.
2)In thumbnails view, move multiple images to Trash.

In UI: The images are no more visible in Thumbnails view.

In DB: 
After adding images, they're visible correctly in Images table.
After deletion, images still present in DB but with album column = "NULL". If
we restore these images, then NULL entries remains in the table, and new rows
are added for those images.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #32 from caulier.gil...@gmail.com ---
Swati,

For this file, outside the fact that a DB garbage collector need to be write to
clean up the database (there is one other bug entry about this topic), it must
miss a call to a sql query somewhere in thumbnails database interface when file
is removed from the collection. 

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[Greg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #31 from Greg  ---
Thumbnails remain after file deletion in version 5.0.0.0.Beta5 on Fedora Linux
24:
Version : 5.0.0
Release : 0.10.beta5.fc24

For example, I have 127 images in a directory. Thumbnails of all original
photos appear. After I process each image, I save a new version, e.g.,
pix-01.jpg saved as pix-01_v1.jpg. Later I remove the original photos, select
pix-01.jpg and move it to Trash. 

The original file is moved to Trash, but the thumbnail remains in Album view.
When I try to delete the file a second time, an error message appears:

  File pix-01.jpg does not exist

When I try View -> Refresh, placeholder images (a bare tree at sunset?) appear
for thumbnails. Thumbnails and associated metadata seem to remain in any case.

Also, additional directories appear within my current directory in the Album
menu (left sidebar). They show different numbers of images. Now the left
sidebar shows four subdirectories ("albums") in the album I'm using, but
actually there are none.

The bug and another one (missing sidebar menu icons) appeared after I upgraded
Fedora 23 to 24 and then digiKam from version 4.x to 5.0.0.Beta5).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[Greg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

Greg  changed:

   What|Removed |Added

 CC||g...@ares.eonet.ne.jp

--- Comment #30 from Greg  ---
Thumbnails remain after file deletion in version 5.0.0.0.Beta5 on Fedora Linux
24:
Version : 5.0.0
Release : 0.10.beta5.fc24

For example, I have 127 images in a directory. Thumbnails of all original
photos appear. After I process each image, I save a new version, e.g.,
pix-01.jpg saved as pix-01_v1.jpg. Later I remove the original photos, select
pix-01.jpg and move it to Trash. 

The original file is moved to Trash, but the thumbnail remains in Album view.
When I try to delete the file a second time, an error message appears:

  File pix-01.jpg does not exist

When I try View -> Refresh, placeholder images (a bare tree at sunset?) appear
for thumbnails. Thumbnails and associated metadata seem to remain in any case.

Also, additional directories appear within my current directory in the Album
menu (left sidebar). They show different numbers of images. Now the left
sidebar shows four subdirectories ("albums") in the album I'm using, but
actually there are none.

The bug and another one (missing sidebar menu icons) appeared after I upgraded
Fedora 23 to 24 and then digiKam from version 4.x to 5.0.0.Beta5).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[DrSlony via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #29 from DrSlony  ---
Yes, looks like just a refresh problem.

I tried to reproduce the problem from a console now by just copying an existing
album under a new name, starting digiKam and deleting photos from the new
album, but the thumbs were correctly removed from digiKam, so I couldn't
reproduce. I will run it from a console the next time I import and delete and
report back to you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #28 from caulier.gil...@gmail.com ---
Can you run digiKam from a console and post here the trace of operations when
you try again a similar deletion of files ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #27 from caulier.gil...@gmail.com ---
SO it's just a refresh problem. Right ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[DrSlony via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #26 from DrSlony  ---
Using the SQLite database.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[DrSlony via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #25 from DrSlony  ---
Using 7fb769c27cf48408cf45cad65ba4330940663c05

I imported over 100 photos. Back in the main digiKam window, once importing
finished, I went to the new album, clicked on the last thumb, jumped 50 photos
back using the "left arrow" key, then I held shift and clicked on the first
photo in the album, to select the first >50, then I shift+deleted them. The
confirmation popped up, I agreed, and digiKam deleted the photos... only the
thumbnails have not disappeared.
https://i.imgur.com/8bHLn3j.png

Clicking F5 reloaded the album and then the deleted photos disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #24 from swatilodh...@gmail.com ---
(In reply to caulier.gilles from comment #23)

I understand you now. I think I misinterpreted the issue faced by the user. I
just checked if thumbnail is removed the DK interface. The file still exists in
my Image table. 

I apologize for the mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

--- Comment #23 from caulier.gil...@gmail.com ---
When you said that the thumbnail do not exists, you want mean in thumbnail DB ?

It's true for all DB type ?

I'm surprised because a garbage collector to clean up DB entries about non
valid items have never been implemented, as i know...

Perhaps with an item removed from DK interface it will work, but what about to
remove file form hard drive by another application while DK session is down.
I'm sure that nothing is removed from the DB. But this case is fully relevan of
a future garbage collector tool for DB maintenance (i think another bugzilla
entry exist about this topic).

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 317210] THUMBDB : delete image removes file, but does not remove thumbnails

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=317210

swatilodh...@gmail.com changed:

   What|Removed |Added

 CC||swatilodh...@gmail.com

--- Comment #22 from swatilodh...@gmail.com ---
I use digikam5.0.0-beta6

Steps to reproduce:
1)Create a new folder and add some images.
2)Go to the thumbnail view.
3) Move an image to trash.

Actual results
The image is removed from file system and the thumbnail doesn't exist anymore
in digiKam.

Expected results
Same as actual results.

-- 
You are receiving this mail because:
You are watching all bug changes.