[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

caulier.gil...@gmail.com changed:

   What|Removed |Added

   Version Fixed In||5.7.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

Simon  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||freisi...@gmail.com

--- Comment #62 from Simon  ---
The mxe problems (symlinking) aren't resolved, but that's not what this bug
report was originally about and it's not like I am currently working on that,
so yes -> closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #61 from Maik Qualmann  ---
Simon,

can this bug be closed?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Usability   |Usability-Themes

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #60 from Simon  ---
Just committed the fix and forgot to CCBUG:
https://cgit.kde.org/digikam-software-compilation.git/commit/?id=e0d7485484b60a469469ddbc8f2ce2c51120142e

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #59 from caulier.gil...@gmail.com ---
Arf, i write my comment to faster. MXE switch to 0.3.2 now. So you patch about
native MXE lensfun is fine (:=)))...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #58 from caulier.gil...@gmail.com ---
Simon,

As i said in MXE mailing list, i agree to use lensfun from MXE, only if MXE
switch to 0.3.2. The current one is 0.3.0 as i know. Else this will be a
regression about lens database.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #57 from Simon  ---
Created attachment 104630
  --> https://bugs.kde.org/attachment.cgi?id=104630=edit
Use mxe lensfun

The attached patch fixes my problems with lensfun. Can be committed once
https://github.com/mxe/mxe/pull/1721 is merged.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #56 from Simon  ---
Ok, I will put that on my list of things to look at.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #55 from caulier.gil...@gmail.com ---
Simon,

KF5 5.32 is just released. In log i can see :

Breeze Icons : too many icon changes to list them here.

I recommend to take a look if other icons in DK can be used to improve
usability, in case of.

I don't yet switched AppImage build rules from 5.31 to 5.32. I must check if
all compile fine under Centos 6.8.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #54 from Simon  ---
Git commit 94f167d030531e555ed93685101f006d1cbb by Simon Frei.
Committed on 12/02/2017 at 09:31.
Pushed by sfrei into branch 'master'.

Replace icons
Related: bug 376375
FIXED-IN: 5.5.0

M  +2-1NEWS
M  +2-2app/filters/filtersidebarwidget.cpp
M  +1-1app/main/digikamapp.cpp
M  +1-1app/utils/contextmenuhelper.cpp
M  +1-1app/utils/digikammodelcollection.cpp
M  +1-1app/views/digikamview.cpp
M  +2-2app/views/leftsidebarwidgets.cpp
M  +1-1app/views/tableview/tableview_column_digikam.cpp
M  +1-1app/views/tableview/tableview_column_geo.cpp
M  +1-1app/views/tableview/tableview_column_item.cpp
M  +1-1libs/dialogs/deletedialog.cpp
M  +1-1libs/dimg/filters/bw/bwsepiasettings.cpp
M  +1-1libs/dimg/filters/fx/colorfxsettings.cpp
M  +1-1libs/imageproperties/imagepropertiesgpstab.cpp
M  +1-1libs/imageproperties/imagepropertiessidebar.cpp
M  +1-1libs/imageproperties/imagepropertiessidebarcamgui.cpp
M  +1-1libs/imageproperties/imagepropertiestab.cpp
M  +1-1libs/models/albummodel.cpp
M  +2-2libs/template/templatepanel.cpp
M  +2-2libs/template/templateviewer.cpp
M  +1-1libs/widgets/itemview/itemviewimagedelegate.cpp
M  +4-4libs/widgets/mainview/dxmlguiwindow.cpp
M  +1-1showfoto/thumbbar/itemviewshowfotodelegate.cpp
M  +1-1tests/geolocation/geoiface/demo/mainwindow.cpp
M  +2-2utilities/assistants/calendar/wizard/calmonthwidget.cpp
M  +1-1utilities/assistants/common/dimageslist.cpp
M  +2-2utilities/assistants/expoblending/blendingdlg/bracketstack.cpp
M  +1-1utilities/assistants/expoblending/blendingdlg/enfusestack.cpp
M  +1-1utilities/fuzzysearch/findduplicatesalbumitem.cpp
M  +1-1utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +1-1utilities/geolocation/editor/items/gpsimageitemdelegate.cpp
M  +1-1utilities/geolocation/geoiface/mapwidget.cpp
M  +2-2utilities/imageeditor/editor/editortooliface.cpp
M  +2-2utilities/imageeditor/editor/editorwindow.cpp
M  +1-1utilities/importui/backend/cameracontroller.cpp
M  +1-1utilities/importui/dialogs/cameramessagebox.cpp
M  +1-1utilities/importui/items/itemviewimportdelegate.cpp
M  +1-1utilities/importui/main/importui.cpp
M  +1-1utilities/metadataedit/exif/exifeditwidget.cpp
M  +1-1utilities/metadataedit/iptc/iptceditwidget.cpp
M  +1-1utilities/presentation/dialogs/presentation_mainpage.cpp
M  +2-2utilities/queuemanager/views/queuelist.cpp
M  +1-1utilities/setup/setupicc.cpp

https://commits.kde.org/digikam/94f167d030531e555ed93685101f006d1cbb

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #53 from caulier.gil...@gmail.com ---
Hi Simon,

Yes, let's go to apply patch #103990 and close #376375

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

Simon  changed:

   What|Removed |Added

 Attachment #103115|0   |1
is obsolete||

--- Comment #52 from Simon  ---
Created attachment 103990
  --> https://bugs.kde.org/attachment.cgi?id=103990=edit
Replace icons

I just by accident saw that the bundled breeze icons is 5.30 now
(https://bugs.kde.org/show_bug.cgi?id=376369#c8). So the original patch can be
used now, as the relevant icons are no longer symlinks
(https://bugs.kde.org/attachment.cgi?id=103115). Shall I commit?

This is independent from my entire mxe problem, which I am still hoping to
resolve, but don't have time right now to sort it out.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #51 from caulier.gil...@gmail.com ---
Git commit 8aba3ee99e1162f40dbb69871899f7ff6406aa14 by Gilles Caulier.
Committed on 31/01/2017 at 19:10.
Pushed by cgilles into branch 'master'.

add missing digiKam icons located on hicolor

M  +7-0project/bundles/appimage/04-build-appimage.sh

https://commits.kde.org/digikam-software-compilation/8aba3ee99e1162f40dbb69871899f7ff6406aa14

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #50 from caulier.gil...@gmail.com ---
Simon, 

I found a problem with RCC files generated which do not include all icons from
DK installed on /usr/share/icons/hicolors. I will fix it

Gillles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #49 from caulier.gil...@gmail.com ---
Git commit 2d99c9ef775eb8b50bc63acecc4856905ece863c by Gilles Caulier.
Committed on 29/01/2017 at 10:10.
Pushed by cgilles into branch 'master'.

update code to build rcc file from last Breeze repository to build icon set as
RCC

M  +39   -56   project/bundles/appimage/icon-rcc/main.cpp
M  +39   -56   project/bundles/macports/icon-rcc/main.cpp
M  +39   -56   project/bundles/mxe/icon-rcc/main.cpp

https://commits.kde.org/digikam-software-compilation/2d99c9ef775eb8b50bc63acecc4856905ece863c

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #48 from caulier.gil...@gmail.com ---
The only way where i suspect your problem with glib debug dll, is certainly a
MXE linux dependency to run. We have certainly a difference between your system
and mine (Linux Mageia 5.1). If you nned to know which package version i use,
let's me hear.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #47 from Simon  ---
Hi Gilles

I will do, but as I don't have a clear way to reproduce it (that is kind
of the problem) I first want to detail the problem as much as possible
and ask for help on their mailing list. I will let you know when I will
do this.

Cheers,
Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #46 from caulier.gil...@gmail.com ---
Simon,

Me and Maik, we are able to rebuild MXE targets from scratch.

It's alwyas the case for you ? If yes, please report the dysfunction to MXE
project from github issues tracker :

https://github.com/mxe/mxe/issues

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #45 from caulier.gil...@gmail.com ---
Simon,

I don't understand why it do not work for you in 64 bits shared.

I recommend to post a dile in MXE bugzilla. The team respond quickly in
general...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #44 from caulier.gil...@gmail.com ---
No problem to build and link lensfun with MXE 64 bits :

[100%] Built target ext_opencv
== Using MXE wrapper:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/bin/x86_64-w64-mingw32.shared-cmake
== Skip using MXE toolchain:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/share/cmake/mxe-conf.cmake
Scanning dependencies of target ext_lensfun
[ 50%] Performing before_download step for 'ext_lensfun'
[ 50%] Creating directories for 'ext_lensfun'
WARNING: timestamping does nothing in combination with -O. See the manual
for details.

--2017-01-21 19:54:28-- 
http://downloads.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz
Resolving downloads.sourceforge.net (downloads.sourceforge.net)...
216.34.181.59
Connecting to downloads.sourceforge.net
(downloads.sourceforge.net)|216.34.181.59|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location:
https://vorboss.dl.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz
[following]
--2017-01-21 19:54:29-- 
https://vorboss.dl.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz
Resolving vorboss.dl.sourceforge.net (vorboss.dl.sourceforge.net)...
5.10.152.194
Connecting to vorboss.dl.sourceforge.net
(vorboss.dl.sourceforge.net)|5.10.152.194|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 784825 (766K) [application/x-gzip]
Saving to:
‘/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz’

 0K .. .. .. .. ..  6%  228K 3s
50K .. .. .. .. .. 13%  443K 2s
   100K .. .. .. .. .. 19% 86.6K 4s
   150K .. .. .. .. .. 26%  158K 3s
   200K .. .. .. .. .. 32%  658K 3s
   250K .. .. .. .. .. 39% 92.4K 3s
   300K .. .. .. .. .. 45% 52.3K 3s
   350K .. .. .. .. .. 52%  367K 3s
   400K .. .. .. .. .. 58% 69.7K 3s
   450K .. .. .. .. .. 65%  640K 2s
   500K .. .. .. .. .. 71% 88.2K 2s
   550K .. .. .. .. .. 78%  328K 1s
   600K .. .. .. .. .. 84% 50.3K 1s
   650K .. .. .. .. .. 91%  600K 1s
   700K .. .. .. .. .. 97% 40.6K 0s
   750K .. .. 100% 2.07M=6.8s

2017-01-21 19:54:39 (113 KB/s) -
‘/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz’ saved
[784825/784825]

[ 50%] Performing download step (verify and extract) for 'ext_lensfun'
-- verifying file...

file='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz'
-- verifying file... done
-- extracting...

src='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz'

dst='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.build/ext_lensfun/ext_lensfun-prefix/src/ext_lensfun'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[100%] No update step for 'ext_lensfun'
[100%] Performing patch step for 'ext_lensfun'
patching file CMakeLists.txt
[100%] Performing configure step for 'ext_lensfun'
MXE target : 64 bits shared
Installing to /mnt/devel/GIT/5.x/project/bundles/mxe/build.win64 for target
x86_64-w64-mingw32.shared with build mode RelWithDebInfo and configure options
-DBUILD_TESTING=false
== Using MXE wrapper:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/bin/x86_64-w64-mingw32.shared-cmake
== Using MXE toolchain:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/share/cmake/mxe-conf.cmake
== Using MXE runresult:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/share/cmake/modules/TryRunResults.cmake
loading initial cache file
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/share/cmake/modules/TryRunResults.cmake
-- The C compiler identification is GNU 4.9.4
-- The CXX compiler identification is GNU 4.9.4
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/bin/x86_64-w64-mingw32.shared-gcc
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/bin/x86_64-w64-mingw32.shared-gcc
-- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/bin/x86_64-w64-mingw32.shared-g++
-- Check for working CXX compiler:

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #43 from Simon  ---
That doesn't change anything. For completeness the full log of makeall.sh:
http://pastebin.com/Q8KM5GPK The problem is still the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #42 from caulier.gil...@gmail.com ---
Simon,

If you have enough free space on your disk, please use make_all.sh sxript. It
will build the 32 and the 64 bits for you in different dir and make the
installers. Take a care, this remove all previous build.

I just run it while this night, it take 4h30 to do all, and it work as
expected.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #41 from Simon  ---
Hi Gilles,

Thanks for your efforts. The downloading issue is gone, but the issue with
Install configuration: "Release"
and glib2 dll (not sure whether the two are even connected) remains. Any ideas
how I can debug this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #40 from caulier.gil...@gmail.com ---
Simon,

compilation and linking of Lensfun under MXE 64 bits is fine too...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #39 from caulier.gil...@gmail.com ---
Git commit 9ba5ed5039fbbee7d3838c891d8e46d8d6c10d5c by Gilles Caulier.
Committed on 20/01/2017 at 15:09.
Pushed by cgilles into branch 'master'.

use native download with Lensfun under MXE

M  +8-3project/bundles/3rdparty/ext_lensfun/CMakeLists.txt

https://commits.kde.org/digikam-software-compilation/9ba5ed5039fbbee7d3838c891d8e46d8d6c10d5c

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=374313

Rex Dieter  changed:

   What|Removed |Added

 CC|rdie...@math.unl.edu|

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #38 from caulier.gil...@gmail.com ---
Simon,

Now i can reproduce the downloading problem with lensfun: 

[  0%] Creating directories for 'ext_lensfun'
[ 50%] Performing download step (download, verify and extract) for
'ext_lensfun'
-- downloading...

src='http://downloads.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz'
 dst='/mnt/data/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz'
 timeout='none'
-- [download 0% complete]
CMake Error at ext_lensfun-stamp/download-ext_lensfun.cmake:27 (message):
  error: downloading
  'http://downloads.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz'
  failed

status_code: 1
status_string: "Unsupported protocol"
log:   Trying 216.34.181.59...

  Connected to downloads.sourceforge.net (216.34.181.59) port 80 (#0)

  GET /project/lensfun/0.3.2/lensfun-0.3.2.tar.gz HTTP/1.1

  Host: downloads.sourceforge.net

  User-Agent: curl/7.44.0

  Accept: */*



  HTTP/1.1 302 Found

  Server: nginx

  Date: Fri, 20 Jan 2017 10:10:42 GMT

  Content-Type: text/html; charset=UTF-8

  Connection: close

  content-disposition: attachment; filename="lensfun-0.3.2.tar.gz"

  Set-Cookie: sf_mirror_attempt="lensfun:vorboss:0.3.2/lensfun-0.3.2.tar.gz";
  expires=120; Path=/

  Location:
  https://vorboss.dl.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz


  Content-Length: 337



  Closing connection 0

  Issue another request to this URL:
 
'https://vorboss.dl.sourceforge.net/project/lensfun/0.3.2/lensfun-0.3.2.tar.gz'


  Protocol "https" not supported or disabled in libcurl

  Closing connection -1





ext_lensfun/CMakeFiles/ext_lensfun.dir/build.make:89: recipe for target
'ext_lensfun/ext_lensfun-prefix/src/ext_lensfun-stamp/ext_lensfun-download'
failed
gmake[3]: ***
[ext_lensfun/ext_lensfun-prefix/src/ext_lensfun-stamp/ext_lensfun-download]
Error 1
CMakeFiles/Makefile2:755: recipe for target
'ext_lensfun/CMakeFiles/ext_lensfun.dir/all' failed
gmake[2]: *** [ext_lensfun/CMakeFiles/ext_lensfun.dir/all] Error 2
CMakeFiles/Makefile2:767: recipe for target
'ext_lensfun/CMakeFiles/ext_lensfun.dir/rule' failed
gmake[1]: *** [ext_lensfun/CMakeFiles/ext_lensfun.dir/rule] Error 2
Makefile:287: recipe for target 'ext_lensfun' failed
gmake: *** [ext_lensfun] Error 2

[gilles@localhost mxe]$ 

I see the same problem with OpenCV package. this is due to cmake, configured
with MXE, which use curl to get the tarball through https. Strangely, https is
not supported to curl...

I solved the OpenCV problem to use native CURL and pass local url to cmake. I
will do it with LensFun.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #37 from caulier.gil...@gmail.com ---
Git commit 6a762e3d50f6cbb45c7db65ce5e0f814b155da6a by Gilles Caulier.
Committed on 15/01/2017 at 18:09.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in MacOS bundles
Related: bug 374671

M  +1-0project/bundles/mxe/04-build-installer.sh
M  +14   -6project/bundles/mxe/icon-rcc/CMakeLists.txt

https://commits.kde.org/digikam-software-compilation/6a762e3d50f6cbb45c7db65ce5e0f814b155da6a

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #36 from caulier.gil...@gmail.com ---
Git commit bfc94680177ebc360fa11fe3e67dc5fa713562e8 by Gilles Caulier.
Committed on 15/01/2017 at 16:41.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in MacOS bundles
Related: bug 374671

M  +1-0project/bundles/macports/04-build-installer.sh
M  +13   -5project/bundles/macports/icon-rcc/CMakeLists.txt
M  +1-1project/bundles/macports/installer/digikam.pkgproj

https://commits.kde.org/digikam-software-compilation/bfc94680177ebc360fa11fe3e67dc5fa713562e8

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #35 from caulier.gil...@gmail.com ---
Git commit a5664d2515aef4cabbe5b85e79c9304d384886e4 by Gilles Caulier.
Committed on 15/01/2017 at 15:27.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in AppImage bundles
Related: bug 374671

M  +1-0project/bundles/appimage/04-build-appimage.sh
M  +13   -5project/bundles/appimage/icon-rcc/CMakeLists.txt

https://commits.kde.org/digikam-software-compilation/a5664d2515aef4cabbe5b85e79c9304d384886e4

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #34 from caulier.gil...@gmail.com ---
Git commit a1fea8affc57df5008407b7e2c494d3e0be2b6c4 by Gilles Caulier.
Committed on 15/01/2017 at 15:25.
Pushed by cgilles into branch 'master'.

manage breeze and breeze-dark icon themes from ressource files.
Related: bug 374671

M  +39   -8libs/widgets/mainview/dxmlguiwindow.cpp

https://commits.kde.org/digikam/a1fea8affc57df5008407b7e2c494d3e0be2b6c4

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #33 from caulier.gil...@gmail.com ---
Git commit 01864737967122d5457809b8afb7443e02d2731d by Gilles Caulier.
Committed on 15/01/2017 at 10:57.
Pushed by cgilles into branch 'master'.

add new settings to use a specific revision of MXE git repository to build
bundle.
Se t git revision to 16 december 2016 which work as expected to release 5.4.0

M  +10   -4project/bundles/mxe/01-build-mxe.sh
M  +2-0project/bundles/mxe/config.sh

https://commits.kde.org/digikam-software-compilation/01864737967122d5457809b8afb7443e02d2731d

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #32 from caulier.gil...@gmail.com ---
Simon, 

The MXE 64 build failed to Qtbase about ssl linking problem. It's not yet
solved to MXE team, even if 32 bits build fine.

I have a backup of working version :

[gilles@localhost build.win32.old]$ git log -1
commit 6b8a1fd0712eaac40ff95dabc894194fa0a8b369
Merge: 7ce70ae d10bc3e
Author: Boris Nagaev 
Date:   Fri Dec 16 16:25:51 2016 -0800

Merge pull request #1597 from LuaAndC/freetds-non-ftp

freetds: add HTTP download URL

It's the same from 64 bits. It compile fine. I recommend to use this MXE
revision in place of git/master.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #31 from caulier.gil...@gmail.com ---
No problem to compile MXE from scratch.

The 32 bits version is under way to be completed. I used makeall.sh script. The
64 bits will come in few hours.

This is the trace of lensfun 32 bits build (between OPenCV and Exiv2) :

...
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/haarcascades/haarcascade_frontalcatface_extended.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/haarcascades/haarcascade_lowerbody.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/haarcascades/haarcascade_frontalface_alt_tree.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/haarcascades/haarcascade_upperbody.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/haarcascades/haarcascade_lefteye_2splits.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/lbpcascades/lbpcascade_profileface.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/lbpcascades/lbpcascade_frontalcatface.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/lbpcascades/lbpcascade_frontalface.xml
-- Installing:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/OpenCV/lbpcascades/lbpcascade_silverware.xml
[100%] Completed 'ext_opencv'
[100%] Built target ext_opencv
== Using MXE wrapper:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-cmake
== Skip using MXE toolchain:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/cmake/mxe-conf.cmake
Scanning dependencies of target ext_lensfun
[  0%] Creating directories for 'ext_lensfun'
[ 50%] Performing download step (download, verify and extract) for
'ext_lensfun'
-- verifying file...

file='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz'
-- verifying file... done
-- extracting...

src='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.dwnld/lensfun-0.3.2.tar.gz'

dst='/mnt/devel/GIT/5.x/project/bundles/mxe/temp.build/ext_lensfun/ext_lensfun-prefix/src/ext_lensfun'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 50%] Performing patch step for 'ext_lensfun'
[ 50%] No update step for 'ext_lensfun'
patching file CMakeLists.txt
[ 50%] Performing configure step for 'ext_lensfun'
MXE target : 32 bits shared
Installing to /mnt/devel/GIT/5.x/project/bundles/mxe/build.win32 for target
i686-w64-mingw32.shared with build mode relwithdebinfo and configure options
-DBUILD_TESTING=false
== Using MXE wrapper:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-cmake
== Using MXE toolchain:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/cmake/mxe-conf.cmake
== Using MXE runresult:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/share/cmake/modules/TryRunResults.cmake
loading initial cache file
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/share/cmake/modules/TryRunResults.cmake
-- The C compiler identification is GNU 4.9.4
-- The CXX compiler identification is GNU 4.9.4
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-gcc
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-gcc
-- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-g++
-- Check for working CXX compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-g++
-- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for include file endian.h
-- Looking for include file endian.h - not found
-- Found PkgConfig:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-pkg-config
(found version "0.28") 
-- Checking for one of the modules 'glib-2.0'
--
-
-- Building Lensfun 0.3.2.0
--
-
-- Build as dynamic/shared library
-- Build type: Release
-- Build doc: OFF
-- Build test suite: OFF
-- Build lenstool: OFF
-- Build with support for SSE: ON

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #30 from caulier.gil...@gmail.com ---
Maik,

Do you have this kind of liking problem with LensFun/GLib2 under your MXE
install ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #29 from caulier.gil...@gmail.com ---
ok,

I will try again this evening with a new fresh MXE install from scratch

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #28 from Simon  ---
No, the problem remains. With the problem I mean that it still says

-- Install configuration: "Release"

and it still fails on the glib2 dll when compiling lensfun.

I gave up kind of frustrated as I can reproduce the issue starting completely
clean and you can't, and I don't find any reason why CMAKE_BUILD_TYPE is not
propagated correctly or anything related to glib2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #27 from caulier.gil...@gmail.com ---
Simon, 

Your last commits fix the MXE compialtion problem with lenfun library ? If yes,
did you complete the MXE build and test installer on Windows target ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #26 from Simon  ---
Git commit b9a2074364ced57bfb9deb31c2e41ed0ebcb79ad by Simon Frei.
Committed on 11/01/2017 at 09:12.
Pushed by sfrei into branch 'master'.

relwithdebinfo => RelWithDebInfo

M  +1-1bootstrap.mxe
M  +2-2project/bundles/3rdparty/ext_exiv2/CMakeLists.txt
M  +1-1project/bundles/3rdparty/ext_lensfun/CMakeLists.txt
M  +1-1project/bundles/3rdparty/ext_opencv/CMakeLists.txt
M  +1-1project/bundles/appimage/03-build-digikam.sh
M  +1-1project/bundles/mxe/03-build-digikam.sh

https://commits.kde.org/digikam-software-compilation/b9a2074364ced57bfb9deb31c2e41ed0ebcb79ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #25 from caulier.gil...@gmail.com ---
Git commit 71465fadc6ce4c0cb03eca3810d8a1e13721b558 by Gilles Caulier.
Committed on 11/01/2017 at 08:59.
Pushed by cgilles into branch 'master'.

Debug => RelWithDebInfo
relwithdebinfo => RelWithDebInfo

M  +1-1project/bundles/mxe/01-build-mxe.sh
M  +2-2project/bundles/mxe/02-build-extralibs.sh
M  +1-1project/bundles/mxe/04-build-installer.sh

https://commits.kde.org/digikam-software-compilation/71465fadc6ce4c0cb03eca3810d8a1e13721b558

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #24 from Simon  ---
The doc says it should be CamelCase, so I replaced all occurrences of
relwithdebinfo with RelWithDebInfo but the problem remains (I started
completely clean): http://pastebin.com/LyVm2ZEP

I am still very confused with the fact that we get different behaviours at all.
Everything is downloaded and built with these scripts, so where does this
difference come from?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=374313

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #23 from caulier.gil...@gmail.com ---
Look right typo to use cmake doc, especially the CMAKE_BUILD_TYPE variable
section here :

https://cmake.org/Wiki/CMake_Useful_Variables

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #22 from caulier.gil...@gmail.com ---
And the problem exist also in others shell scripts...

At least the same typo must used everywhere. Please fix and check if it solve
your problem.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #21 from caulier.gil...@gmail.com ---
i think that i found the problem. There is a typo. Look on 01-build-mxe.sh line
149 and compare with lines 165 to 168...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #20 from Simon  ---
After building with win32 comparing was easier and I found an issue:

you:
-- Install configuration: "relwithdebinfo"
me:
-- Install configuration: "Release"

I have no clue why, we use the exact same scripts and cmake files. Any idea why
I end up with build type Release?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #19 from Simon  ---
Yes, I know it is weird, but that is what is in the lensfun CMakeList.txt
(https://github.com/lensfun/lensfun/blob/v0.3.2/CMakeLists.txt#L76)
I am currently trying to run it for 32bit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #18 from caulier.gil...@gmail.com ---
Really ???

My log from Lensfun compiled to 64 bits MXE :

Using: 
-- GLIB2 include dir:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/include/glib-2.0;/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/lib/glib-2.0/include;/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/include
-- GLIB2 library: glib-2.0;intl
-- GLIB2 DLL:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/bin/libglib-2.0-0.dll
-- Configuring done

DLL is here... And i don't see any reason to not have a DLL if lensfun target
is compiled as shared. DLL is the wanted goal in this case...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #17 from Simon  ---
This is because your log is from 32bit and mine from 64bit. As I said earlier
the dll should never be installed when compiling for 64bit according to
https://github.com/lensfun/lensfun/blob/v0.3.2/CMakeLists.txt#L76

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #16 from caulier.gil...@gmail.com ---
Look the difference. From you :

--
Using:
-- GLIB2 include dir:
/media/nunkystorage/4_Simon/Programme/Linux/source/digikam/develsoftwarecomp/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/include/glib-2.0;/media/nunkystorage/4_Simon/Programme/Linux/source/digikam/develsoftwarecomp/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/lib/glib-2.0/include;/media/nunkystorage/4_Simon/Programme/Linux/source/digikam/develsoftwarecomp/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/include
-- GLIB2 library: glib-2.0;intl
-- Configuring done

>From me :

-- 
Using: 
-- GLIB2 include dir:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/include/glib-2.0;/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/lib/glib-2.0/include;/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/include
-- GLIB2 library: glib-2.0;intl
-- GLIB2 DLL: /mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-
mingw32.shared/bin/libglib-2.0-0.dll
-- Configuring done


It miss this line from you side : 

-- GLIB2 DLL:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/bin/libglib-2.0-0.dll

The glib2 dll exists on your MXE ?
What the MXE log about glib2 ? 
Mine from
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/log/glib_i686-w64-mingw32.shared
indicate a trace about download + configure + make + make install without
error.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #15 from Simon  ---
The entire trace (of 01-build-mxe.sh): http://pastebin.com/39kEW80q

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #14 from caulier.gil...@gmail.com ---
No problem too to get and compile lensfun under MXE in 64 bits...

What's your complete trace exactly ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #13 from caulier.gil...@gmail.com ---
Simon,

No problem for me to get Lensfun tarball and compile it with MXE. See my trace
below :

[gilles@localhost mxe]$ ./01-build-mxe.sh
01-build-mxe.sh : build a bundle MXE install with digiKam dependencies.
---
Target Windows architecture: 32 bits.
CPU Cores to use : 7

...

-- Building digiKam 3rd-party dependencies with MXE
== Using MXE wrapper:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-cmake
== Using MXE toolchain:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/i686-w64-mingw32.shared/share/cmake/mxe-conf.cmake
== Using MXE runresult:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/share/cmake/modules/TryRunResults.cmake
loading initial cache file
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/share/cmake/modules/TryRunResults.cmake
-- The C compiler identification is GNU 4.9.4
-- The CXX compiler identification is GNU 4.9.4
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-gcc
-- Check for working C compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-gcc
-- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-g++
-- Check for working CXX compiler:
/mnt/devel/GIT/5.x/project/bundles/mxe/build.win32/usr/bin/i686-w64-mingw32.shared-g++
-- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_GENERATOR: Unix Makefiles
-- CMAKE_CL_64: 
-- 
-- KF5 component: extra-cmake-modules
-- Component version: 5.29
-- Component MD5: dd3e13ee27fb421a9d215fc708ae02b3
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: kconfig
-- Component version: 5.29
-- Component MD5: d9686ba5a3b1732236a3dcf3b7d1b4a4  
-- Configure options:   
-- Patch to apply   :   
--  
-- KF5 component: breeze-icons  
-- Component version: 5.29  
-- Component MD5: 799c237be7c59ee0a452cea034565f43  
-- Configure options: -DBINARY_ICONS_RESOURCE=OFF   
-- Patch to apply   :   
--  
-- KF5 component: solid 
-- Component version: 5.29  
-- Component MD5: f118ab316c536b84500d472c4141f3d7  
-- Configure options:   
-- Patch to apply   : 
-- 
-- KF5 component: kcoreaddons
-- Component version: 5.29
-- Component MD5: f0a3330cd34e3269cd65b65bb465b02c
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: threadweaver
-- Component version: 5.29
-- Component MD5: 629079e41766c0b40e350287e493e5b1
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: kwindowsystem
-- Component version: 5.29
-- Component MD5: e2e4416e793f72cfada80d85dd4e84dc
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: karchive
-- Component version: 5.29
-- Component MD5: 9a0a1d8e13b45bbed97cf6945eafadff
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: kdbusaddons
-- Component version: 5.29
-- Component MD5: dceedee3876d1d792995e70466af8977
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: ki18n
-- Component version: 5.29
-- Component MD5: 5619f4e80d97c9ee697f0e8b9300d2e3
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: kcrash
-- Component version: 5.29
-- Component MD5: d85c85ecfe38a796c3bce4313df8ece7
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 component: kcodecs
-- Component version: 5.29
-- Component MD5: baf7fdef49333280abed66420f741b88
-- Configure options: 
-- Patch to apply   : 
-- 
-- KF5 

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #12 from caulier.gil...@gmail.com ---
I will take a look in few hours today about MXE and lensfun...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #11 from Simon  ---
(In reply to caulier.gilles from comment #10)
> Simon,
> 
> I don't recieve the comment #9 to my mail box... Strange.
> 
> I will try to reproduce the Lensfun problem. But as i know, it work fine
> since few month until now...
> 
> Note : About icon problem, look also in this comment :
> 
> https://bugs.kde.org/show_bug.cgi?id=374671#c2
> 
> Gilles


I am pretty sure I can solve the problem, but I need to be able to go through
the build process to check whether these ideas work - and I am stuck building,
so I am not making any progress at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #10 from caulier.gil...@gmail.com ---
Simon,

I don't recieve the comment #9 to my mail box... Strange.

I will try to reproduce the Lensfun problem. But as i know, it work fine since
few month until now...

Note : About icon problem, look also in this comment :

https://bugs.kde.org/show_bug.cgi?id=374671#c2

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #9 from Simon  ---
Thanks Gilles for bearing with me - I think I know what the problem is with the
symlinks.

So I tried to do the windows build, but I am running into two problems (one
unsovled) on the 01-build-mxe.sh part (so far):

Building lensfun fails at install target, because it tries to install
GLIB2_DLL. This should not happen, as the install target is only set for win32,
see
   
./project/bundles/mxe/temp.build/ext_lensfun/ext_lensfun-prefix/src/ext_lensfun/CMakeLists.txt
lines 76-86
There are no errors up until that point, GLIB2_DLL is not set, the rest of 
CMake Error at cmake_install.cmake:100 (file):
  file INSTALL cannot find
 
".../project/bundles/mxe/temp.build/ext_lensfun/ext_lensfun-prefix/src/ext_lensfun/GLIB2_DLL-NOTFOUND".
The entire output of 01-build-mxe.sh is here: http://pastebin.com/39kEW80q
I have no clue what is going on here.

Before that I ran into the following problem, but fixed it with a workaround:
It doesn't download the lensfun tarball (the usual generic protocol unsupported
error), I tried a bunch of different URLs, which did not work either. Manually
downloading using curl works fine, no clue what the problem is. I just
downloaded it manually and added a local URL to the makefile.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #8 from caulier.gil...@gmail.com ---
Simon,

>Replace symlinked icons with actual file in windows build (untested)

untested want mean on run-time under Windows ?
did you compiled at least the installer under Linux with MXE ? It's simple, all
i automatized through makeall.sh

>What do you think about replacing all symlinks with actual files in the 
>windows >build as a permanent workaround for this problem?

It must be better, but...

As i explained before, the icons are copie in a single archive as a Qt rcc
file. The rcc file is copied at the right place near digikam.exe. At run time
digiKam check if this file exist and register the archive as source of
ressource of icon.
Rcc file is loaded in memory and it's very fast to get an icon in GUI. Windows
FS is very slow to get small icon file from the system.


>I looked at the build process, but I did not understand whether only the 
>needed >icons or all icons are packaged. If it is all icons, this increases 
>the size >from roughly 47MB to 74MB. 

Probably the file are really copied inside the RCC file.

>Also my proposed patch is untested and there probably is a nicer, less hacky 
>>way to achieve this (if it is a good idea anyway) - I don't know much
>(anything) about cmake.

We have a rcc compiler for icons into project/bundles/mxe/icon-rcc. This one is
a parser of icon files and encapsulate all in RCC archive. look main.cpp, it's
based on C++/Qt. Probably the case of symlinked files must be processed in this
implementation.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #7 from Simon  ---
Created attachment 103198
  --> https://bugs.kde.org/attachment.cgi?id=103198=edit
Replace symlinked icons with actual file in windows build (untested)

What do you think about replacing all symlinks with actual files in the windows
build as a permanent workaround for this problem?
I looked at the build process, but I did not understand whether only the needed
icons or all icons are packaged. If it is all icons, this increases the size
from roughly 47MB to 74MB. Also my proposed patch is untested and there
probably is a nicer, less hacky way to achieve this (if it is a good idea
anyway) - I don't know much (anything) about cmake.

@Wolfgang Scheffner:
I completely agree the German phrasing is unfortunate. This is handled by KDE
Localization (https://l10n.kde.org/) or in this case its German team
(https://l10n.kde.org/team-infos.php?teamcode=de). I also think "Icons" would
be more appropriate than "Thumbnails". And regarding the configuration: The
"Views" should definitely use the same terminology and for me it is generally
confusing (e.g. I don't get what "Mime Types" has to do with "Views"). These
are however other issues than those addresses here - would you mind opening a
new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Wolfgang Scheffner]

https://bugs.kde.org/show_bug.cgi?id=374313

Wolfgang Scheffner  changed:

   What|Removed |Added

 CC||wscheffn...@gmail.com

--- Comment #6 from Wolfgang Scheffner  ---
I don't understand all this tech talk but I would like to add something: if
somebody is working on this anyway he might also change the labeling: replace
"Thumbnails" by "Icons", in the German version as well. In my understanding the
whole thing including all the data is an icon, a thumbnail is only the little
pic. This would also correspond to the terminology we used in "Configure
digiKam".

The labeling in the German version "Vorschaubilder" (plural) for
Icons/Thumbnails and "Vorschaubild" (singular) for the preview is not very
entangling. So "Icons" and "Vorschaubild" would be better since "Icons" is a
well known technical term also in Germany (and probably many other countries).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=374313

Maik Qualmann  changed:

   What|Removed |Added

 CC||artem.anuf...@live.de

--- Comment #5 from Maik Qualmann  ---
*** Bug 374397 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

--- Comment #4 from caulier.gil...@gmail.com ---
The Windows bundle is process with MXE cross compiler (MinGW based).

Whole digiKam + dependencies are compiled under Linux. This take few hours for
32 and 64 bits. There is no need of Windows target, and especially the weird M$
MSVC compiler.

I waste a lots of time, for digiKam, and also in my office, with this Microsoft
compiler. Really, it slow to compile and it's a big puzzle to obtain a good
result at end. MSVC require also to patch a lots of time with pre processor
rules, which become a big plat of cheese with black holes...

So, to resume. MXE compile the whole environement with all low level
dependencies, including Qt5. This is done by this bash script :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/mxe/01-build-mxe.sh

The second script build and install all KF5 dependencies. Breeze is compiled at
this stage :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/mxe/02-build-extralibs.sh#n75

... which call these cmake scripts :

1/
https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/3rdparty/CMakeLists.txt

2/
https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/3rdparty/ext_kf5/CMakeLists.txt

For breeze, note the compilation option used :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/3rdparty/ext_kf5/CMakeLists.txt#n196

Breeze is compacted as Qt rcc resource (this is valid for AppImage and
Macports). Why ? Because parsing small icons file on file system is slow,
especially under Windows. So a memory resource embedded in binary and loaded in
memory is faster.

2nd Question : why disable brezze based rcc rules included since 5.29 ? Because
this require to use KIcon framework which is dropped since 5.x release now.

So the breeze rcc is compiled after than digiKam in installed by 3rd bash
script. Look script 4th, especially here :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/mxe/04-build-installer.sh#n60

This will build the icon sets for whole KF5 and digikam and kipi-plugins. This
is not only Brezze icon sets.

Now, to complete, at runtime, digiKam try to find the rcc resource file at
init. It's done here :

https://cgit.kde.org/digikam.git/tree/libs/widgets/mainview/dxmlguiwindow.cpp#n820

Voilà...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=374313

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #3 from Maik Qualmann  ---
Yes this is still valid for Windows. We use currently KF-5.29 for the Windows
build.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

Simon  changed:

   What|Removed |Added

 Attachment #103091|0   |1
is obsolete||

--- Comment #2 from Simon  ---
Created attachment 103115
  --> https://bugs.kde.org/attachment.cgi?id=103115=edit
Replace icons

>From the previous bug about this:
> Note: The icon globe does not work under Windows, always use the unlinked
> variant -> folder-html.
> 
> Maik

Is this still valid or did something change in the build process to solve this
symlink issue?

If this is still valid this patch must be in sync with an update of breeze
icons for the windows package (the change in breeze will be part of a future
v5.30.0 release). I tried to determine how breeze icons are added to bundles,
but I didn't succeed.

So how/when do you update breeze icons for bundles?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=374313

Simon  changed:

   What|Removed |Added

 Attachment #103075|0   |1
is obsolete||

--- Comment #1 from Simon  ---
Created attachment 103091
  --> https://bugs.kde.org/attachment.cgi?id=103091=edit
Replace icons

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374313] wrong icon usage revisited [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374313

caulier.gil...@gmail.com changed:

   What|Removed |Added

Summary|wrong icon usage revisited  |wrong icon usage revisited
   ||[patch]
 CC||caulier.gil...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.