[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 Ahmed Fathi changed: What|Removed |Added Latest Commit|https://commits.kde.org/dig |https://commits.kde.org/dig |ikam/e3c85fbd1fa892fbf82180 |ikam/e99d0867a27dd3c5853d54 |4fd892b81d00b4bb7b |1905406c938ef4323c --- Comment #6 from Ahmed Fathi --- Git commit e99d0867a27dd3c5853d541905406c938ef4323c by Ahmed Fathi Shaban, on behalf of Simon Frei. Committed on 06/08/2017 at 23:14. Pushed by ahmedfathy into branch 'gsoc17-dlna'. cmake: Don't abort until all dependencies have checked In effect this means: Never using the REQUIRED parameter to find_package. Only exception: ECM, as finding dependencies doesn't work without it. FIXED-IN: 5.7.0 M +25 -24 CMakeLists.txt M +2-1NEWS M +29 -29 cmake/modules/MacroOpenCV.cmake M +3-3cmake/modules/MacroUtils.cmake https://commits.kde.org/digikam/e99d0867a27dd3c5853d541905406c938ef4323c -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 Simon changed: What|Removed |Added Version Fixed In||5.7.0 Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/dig ||ikam/e3c85fbd1fa892fbf82180 ||4fd892b81d00b4bb7b Resolution|--- |FIXED --- Comment #5 from Simon --- Git commit e3c85fbd1fa892fbf821804fd892b81d00b4bb7b by Simon Frei. Committed on 02/08/2017 at 09:23. Pushed by sfrei into branch 'master'. cmake: Don't abort until all dependencies have checked In effect this means: Never using the REQUIRED parameter to find_package. Only exception: ECM, as finding dependencies doesn't work without it. FIXED-IN: 5.7.0 M +25 -24 CMakeLists.txt M +2-1NEWS M +29 -29 cmake/modules/MacroOpenCV.cmake M +3-3cmake/modules/MacroUtils.cmake https://commits.kde.org/digikam/e3c85fbd1fa892fbf821804fd892b81d00b4bb7b -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 --- Comment #4 from Simon --- Created attachment 106997 --> https://bugs.kde.org/attachment.cgi?id=106997&action=edit Don't abort until all dependencies were checked -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 --- Comment #3 from Simon --- I don't have a problem with the dependencies, I think this is a problem of the CMakeList.txt file. It should not stop processing when a required dependency is not found. Example: https://cgit.kde.org/digikam.git/tree/CMakeLists.txt?id=7e00441c257e7e9e5dc5ab983fc06046fb72b0c5#n205 It should simply print an error message and continue until here: https://cgit.kde.org/digikam.git/tree/CMakeLists.txt?id=7e00441c257e7e9e5dc5ab983fc06046fb72b0c5#n482 Where it stops because a required dependency isn't found. Is this sound or am I missing anything? -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 caulier.gil...@gmail.com changed: What|Removed |Added CC||caulier.gil...@gmail.com --- Comment #2 from caulier.gil...@gmail.com --- Please list the the famous problematic dependencies. Look also the full DEPENDENCIES list with comments given in digiKam-SC repository : https://cgit.kde.org/digikam-software-compilation.git/tree/DEPENDENCIES Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 382952] Don't abort cmake when package is missing
https://bugs.kde.org/show_bug.cgi?id=382952 Veaceslav Munteanu changed: What|Removed |Added CC||veaceslav.munteanu90@gmail. ||com --- Comment #1 from Veaceslav Munteanu --- On my archlinux system, opencv 2 is not even available anymore in the official repos. I think that opencv 2 was set since long time ago, and if the bootstrap enables it, we should also enable it. -- You are receiving this mail because: You are watching all bug changes.
