[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

Maik Qualmann  changed:

   What|Removed |Added

   Version Fixed In||6.0.0
  Latest Commit|https://commits.kde.org/dig |https://commits.kde.org/dig
   |ikam/ff0fb215633010d563083c |ikam/0e8da899d20a4549e41cff
   |33e35d45b17d3484f0  |d83a488c85fa7ad85f
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Maik Qualmann  ---
Git commit 0e8da899d20a4549e41cffd83a488c85fa7ad85f by Maik Qualmann.
Committed on 05/05/2018 at 15:35.
Pushed by mqualmann into branch 'master'.

check if a date exists more than once and use it
FIXED-IN: 6.0.0

M  +2-1NEWS
M  +113  -30   core/libs/dmetadata/metaengine_image.cpp

https://commits.kde.org/digikam/0e8da899d20a4549e41cffd83a488c85fa7ad85f

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

Maik Qualmann  changed:

   What|Removed |Added

 Attachment #112203|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

Maik Qualmann  changed:

   What|Removed |Added

 Attachment #108902|0   |1
is obsolete||

--- Comment #17 from Maik Qualmann  ---
Created attachment 112203
  --> https://bugs.kde.org/attachment.cgi?id=112203=edit
datetime.patch

This patch fixes the date problem with a ranking of the date entries found in
the metadata.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

--- Comment #16 from Maik Qualmann  ---
The idea is good to introduce a ranking and could solve the problem. We read
all dates from the image, most of the same win before dates without time part.
I will create a patch this evening.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[mau]

https://bugs.kde.org/show_bug.cgi?id=386959

mau  changed:

   What|Removed |Added

 CC||b-m...@gmx.ch

--- Comment #15 from mau  ---
Hmm, for me it looks like we have two different problems here:

First one is the mapping:

The Metadata Working Group (MWG) [1] recommends

for Tag Name "CreateDate"

Composite:SubSecCreateDate 
EXIF:CreateDate 
IPTC:DigitalCreationDate 
IPTC:DigitalCreationTime 
XMP-xmp:CreateDate 
CurrentIPTCDigest 
IPTCDigest

which is the "creation date of the digital representation" (MWG),

and for Tag Name "DateTimeOriginal"

Composite:SubSecDateTimeOriginal 
EXIF:DateTimeOriginal 
IPTC:DateCreated 
IPTC:TimeCreated 
XMP-photoshop:DateCreated 
CurrentIPTCDigest 
IPTCDigest

which is the "creation date of the intellectual content being shown" (MWG).

So apparently a photoshop-named tag should be used for DateTime information -
at least as a fallback if no other field contains the DateTime information.


Second problem is: Resolution (time information included or not).

Since there seem to be cases when Xmp.photoshop.DateCreated does only contain
the date and not the time (and that could at least theoretically be the case
for all DateTime fields), I'd propose to prefer fields wich contain both date
and time over fields which contain only the date part. So I'd use two priority
rankings:
First go through all DateTime fields in the defined order, if a valid value for
Date and Time is found -> use that and exit.
If no entry is found, go through all DateTime fields again, in the same order,
and accept the first date value (withouth time) -> use that and exit.

Another way of handling all the different fields would be to group them (just
as MWG does) and check for and report any inconsistencies found (like different
dates / times or different resolution (missing time)). That would allow to
correct them, but the resulting question would be which cases of inconsistent
information could be corrected silently and which cases would require human /
user intervention.


[1] https://sno.phy.queensu.ca/~phil/exiftool/TagNames/MWG.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=386959

--- Comment #14 from caulier.gil...@gmail.com ---
yes it sound logic.
If the Exif to XMP conversion is suspect, i recommend to report this problem to
Exiv2 team. At least they lust said if we have really a problem here ...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

--- Comment #13 from Maik Qualmann  ---
Yes, both entries exist:

Xmp.exif.DateTimeOriginal
Xmp.exif.DateTimeDigitized

But I do not think that this entrys exists in a sidecar file:

Exif.Photo.DateTimeOriginal
Exif.Photo.DateTimeDigitized

The problem is, we begins by looking for the date with the query from the EXIF
name space. Through http://www.exiv2.org/conversion.html we get:

Exif.Photo.DateTimeOriginal ==> Xmp.photoshop.DateCreated
Exif.Photo.DateTimeDigitized ==> Xmp.xmp.CreateDate

I think it would be correct:

Exif.Photo.DateTimeOriginal ==> Xmp.exif.DateTimeOriginal
Exif.Photo.DateTimeDigitized ==> Xmp.exif.DateTimeDigitized

Or am I completely wrong?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=386959

--- Comment #12 from caulier.gil...@gmail.com ---
>Gilles, are you really sure that the Exif tags Exif.Photo.DateTimeOriginal or 
>>Exif.Photo.DateTimeDigitized exist in an XMP sidcar file?

Both tags exists in XMP definition of Exif namespace :

https://github.com/Exiv2/exiv2/blob/master/src/properties.cpp#L813
https://github.com/Exiv2/exiv2/blob/master/src/properties.cpp#L816

There exists also for video namespace :

https://github.com/Exiv2/exiv2/blob/master/src/properties.cpp#L1388
https://github.com/Exiv2/exiv2/blob/master/src/properties.cpp#L1389

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 386959] Properties view: wrong creation date [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=386959

Maik Qualmann  changed:

   What|Removed |Added

Summary|Properties view: wrong  |Properties view: wrong
   |creation date   |creation date [patch]

-- 
You are receiving this mail because:
You are watching all bug changes.