[digikam] [Bug 400492] Rotation does not work

2018-11-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #12 from caulier.gil...@gmail.com ---
Thanks Milan for the feedback.
Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-11-03 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #11 from Milan Knížek  ---
Thanks Maik, the latest digikam-6.0.0-beta3-20181102T200629-x86-64 works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-11-01 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=400492

Maik Qualmann  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/dig
   ||ikam/866ccbc40a9796ccfda20f
   ||7026bd690bea65a99a
 Resolution|--- |FIXED
   Version Fixed In||6.0.0

--- Comment #10 from Maik Qualmann  ---
Git commit 866ccbc40a9796ccfda20f7026bd690bea65a99a by Maik Qualmann.
Committed on 01/11/2018 at 19:30.
Pushed by mqualmann into branch 'master'.

fix write orientation flag to Exif.Thumbnail.Orientation
FIXED-IN: 6.0.0

M  +2-1NEWS
M  +5-4core/libs/jpegutils/jpegutils.cpp
M  +1-3core/libs/metadataengine/engine/metaengine_image.cpp

https://commits.kde.org/digikam/866ccbc40a9796ccfda20f7026bd690bea65a99a

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #9 from Milan Knížek  ---
The thing is, the flag for thumbnail does not rotate - it stays as it was
originally (from camera) and the thumbnail rotates physically. 

Try show the exif metadata in the right hand pane, filter for orientation flag
and rotate the image.

In other words, originally both flags might be "rotated right", but when I
rotate the image, then the image flag gets set to 'normal', while the thumbnail
flag remains 'rotated right'. In order to get the thumbnail displayed correctly
(in Digikam), digiKam must actually physically rotate it, too.


The trouble is, that the above behaviour unsyncs the flags and the thumbnail is
not shown properly anymore (in Samsung Gallery app).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #8 from Maik Qualmann  ---
In your case, so it works with the Samsung Gallery app, I would only rotate the
indicator.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #7 from Maik Qualmann  ---
I do not see a mistake here.

Only very few cameras have Exif.Thumbnail.Orientation, yes Samsumg is one.

If you only rotate the indicator, digiKam also updates
Exif.Thumbnail.Orientation.

If you rotate the image lossless, only the main image is rotated, the preview
image is not. I do not know if LibJpeg can also rotate the embedded preview
image lossless, I do not think so.

This is of course different with the image editor, as it always generates new
image data and also generates a new preview image.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #6 from Milan Knížek  ---
One app is confused with out of sync orientation flag - the default Gallery app
in Samsung S7. It displays the embedded thumbnail as per Exif.Image.Orientation
and ignores Exif.Thumbnail.Orientation.

It is probably Samsung's bug, but anyway, wouldn't it be safer to have the
image and embedded thumbnail orientation in sync?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #5 from Milan Knížek  ---
This one works again.

However, I am still wondering if it is a problem that even after rotation
(which sets the Orientation Flag to "Normal"), the flag for thumbnail is still
reported as "rotated" (even after rebuilding the thumbnails):

$ exiv2 -pa z2.jpg | grep -a rientat
Exif.Image.Orientation   Short   1  top, left
Exif.Thumbnail.Orientation   Short   1  right, top
Xmp.tiff.Orientation XmpText 1  top, left

It does not seem to cause problem in digiKam Preview view, in EOG, in Geeqie -
all show the thumbnail properly.

The Exif.Thumbnail.Orientation flag is removed when the image is edited in
digiKam's editor and saved.

Shouldn't it be either synced with the image orientation or removed also within
Rotation actions in digiKam?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #4 from Maik Qualmann  ---
Milan,

can you please test it with the latest AppImage? Your version of time 03:16:45
was affected by the error. New version is:
digikam-6.0.0-beta2-20181030T175240-x86-64.appimage

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-30 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=400492

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #3 from caulier.gil...@gmail.com ---
Maik, AppImage have been updated today evening with your commit from this
morning.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-30 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=400492

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #2 from Maik Qualmann  ---
Gilles must create a new AppImage, this has a problem with write item
information to the DB.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-30 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

--- Comment #1 from Milan Knížek  ---
The prior version digikam-6.0.0-beta2-20181015T071907-x86-64.appimage seems to
work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 400492] Rotation does not work

2018-10-30 Thread Milan Knížek
https://bugs.kde.org/show_bug.cgi?id=400492

Milan Knížek  changed:

   What|Removed |Added

 Attachment #115991|The file names are  |Sample files (The file
description|self-explanatory|names are self-explanatory)

-- 
You are receiving this mail because:
You are watching all bug changes.