[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #13 from Maik Qualmann  ---
The digiKam debug version is not required for the text debug output.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread David Griffiths
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #12 from David Griffiths  ---
Created attachment 128964
  --> https://bugs.kde.org/attachment.cgi?id=128964=edit
Debug log when doing rotate of a thumbnail.

I think this is more like what you need. Using 7.0.0 rc1 debug.
Rotating the same image file I sent you earlier.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread David Griffiths
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #11 from David Griffiths  ---
Do I need to install the debug version of digiKam? I'm guessing I do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

Maik Qualmann  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/digikam/commit/e038d66
   ||62b77f1e5c0f868d824f3b3d8dd
   ||6e4240
   Version Fixed In||7.0.0
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Maik Qualmann  ---
Git commit e038d6662b77f1e5c0f868d824f3b3d8dd6e4240 by Maik Qualmann.
Committed on 31/05/2020 at 18:54.
Pushed by mqualmann into branch 'master'.

check for perfect JPEG transformation
We use the option for perfect JPEG transformation.
For images whose aspect ratio is not the correct
aspect ratio, a line would otherwise remain
without the trim option. In this case, we
perform a lossy rotation.
FIXED-IN: 7.0.0

M  +2-1NEWS
M  +12   -3core/libs/jpegutils/jpegutils.cpp

https://invent.kde.org/graphics/digikam/commit/e038d6662b77f1e5c0f868d824f3b3d8dd6e4240

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #9 from Maik Qualmann  ---
The debug log contains hardly anything from digiKam. Setting the environment
variable does not have to be correct.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread David Griffiths
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #8 from David Griffiths  ---
Created attachment 128954
  --> https://bugs.kde.org/attachment.cgi?id=128954=edit
Debug log when doing rotate

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #7 from Maik Qualmann  ---
No rotation works anymore? How exactly? Install the latest version from here:

https://files.kde.org/digikam/

1. Download "DebugView" from Microsoft.
2. Set this environment variable in the Windows editor for environment
variables:

Variable: QT_LOGGING_RULES
Value: digikam.*=true

3. Start DebgugView and start digiKam. Try a rotation, send the log from
DebugView.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #6 from Maik Qualmann  ---
Git commit c8809100d8a3fb3f76433b79d16af83c4dd56398 by Maik Qualmann.
Committed on 31/05/2020 at 08:03.
Pushed by mqualmann into branch 'master'.

remove static declarations from error handlers

M  +0-4core/libs/jpegutils/jpegutils.cpp

https://invent.kde.org/graphics/digikam/commit/c8809100d8a3fb3f76433b79d16af83c4dd56398

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread David Griffiths
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #5 from David Griffiths  ---
Since I loaded 7.0.0 rc1 it seems I cannot rotate any image, either as
thumbnail or preview.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #4 from Maik Qualmann  ---
I can sometimes reproduce the crash on Windows. The JPEG error handler doesn't
always seem to work.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=422279

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #3 from caulier.gil...@gmail.com ---
yes, DNL (define-number-of-line) JPEG markers are not supported by libjpeg used
in background by digiKam :

https://stackoverflow.com/questions/16470268/empty-jpeg-image-dnl-not-supported-node-canvas

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #2 from Maik Qualmann  ---
I cannot reproduce a crash, neither on Linux nor on Windows. However, this JPG
image is special, it cannot be rotated lossless. There is a slightly different
but similar error message from libjpeg under Windows:

Empty JPEG image (DNL not supported)

-
libjpeg doesn't support DNL markers in JPEG files. Files which contains such
markers will declare to be of zero height.
-

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 422279] Repeatable crash when rotating

2020-05-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=422279

--- Comment #1 from Maik Qualmann  ---
Git commit 7a98463487996bc91b79e5ad67d307a7199e6c2b by Maik Qualmann.
Committed on 31/05/2020 at 06:21.
Pushed by mqualmann into branch 'master'.

polish and don't use QFileInfo::absolutePath()
QFileInfo::absolutePath() replaces "//" with "UNC",
this means that the file cannot be opened with fopen().

M  +5-12   core/libs/jpegutils/jpegutils.cpp

https://invent.kde.org/graphics/digikam/commit/7a98463487996bc91b79e5ad67d307a7199e6c2b

-- 
You are receiving this mail because:
You are watching all bug changes.