[digikam] [Bug 425884] GPS Processing Method: "charset=Ascii" to remove
https://bugs.kde.org/show_bug.cgi?id=425884 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||7.1.0 Latest Commit||https://invent.kde.org/grap ||hics/digikam/commit/b88e48d ||680ccb6b993243d21eb8d320bac ||f9f10c Status|REPORTED|RESOLVED --- Comment #5 from caulier.gil...@gmail.com --- Git commit b88e48d680ccb6b993243d21eb8d320bacf9f10c by Gilles Caulier. Committed on 29/08/2020 at 14:40. Pushed by cgilles into branch 'master'. With Exiv2 0.23.3, 2 new GPSInfo tags from Exif are avaialble and need to be post-processed for the Exif metadata viewer as Exif comment tag. FIXED-IN: 7.1.0 M +12 -0core/libs/metadataengine/engine/metaengine_exif.cpp https://invent.kde.org/graphics/digikam/commit/b88e48d680ccb6b993243d21eb8d320bacf9f10c -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425884] GPS Processing Method: "charset=Ascii" to remove
https://bugs.kde.org/show_bug.cgi?id=425884 --- Comment #4 from caulier.gil...@gmail.com --- Ok, Fix arrive for Exif tags. What about corresponding Xmp.Exif.* tags for these GPS information ? Typically these Exif tags can be forwarded in XMP as well by Exiv2. I'm not sure if a post conversion exist somewhere. If you can please check this point. At least i will convert these Exif tags content in metadata view to be human readable. Processing Xmp tags by the same will be more 2 lines of code to add later if necessary... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425884] GPS Processing Method: "charset=Ascii" to remove
https://bugs.kde.org/show_bug.cgi?id=425884
--- Comment #3 from Nicofo ---
Useful information:
(In reply to Nicofo from comment #0)
> Note: GPSProcessingMethod and GPSAreaInformation are both encoded in the
> same way as EXIF UserComment. (see details
> https://github.com/Exiv2/exiv2/issues/1046#issuecomment-599540926 )
I check the UserComment tag: it is correctly handled by Digikam (meaning
Digikam removes the "charset=Ascii" before the UserCommment).
As far as I understand digikam code, this is realised:
- in metaengine_exif.cpp ==> function getExifComment ==> call to
convertCommentValue
- in metaengine_p.cpp ==> function convertCommentValue ==> reads the charset
and consequently decode the UserComment:
// libexiv2 will prepend "charset=\"SomeCharset\" " if charset is
specified
// Before conversion to QString, we must know the charset, so we stay
with std::string for a while
if (comment.length() > 8 && comment.substr(0, 8) == "charset=")
{ ...
GPSProcessingMethod and GPSAreaInformation are both encoded in the same way as
EXIF UserComment.
CONCLUSION: you should also use the function convertCommentValue to these Exif
tags.
--
You are receiving this mail because:
You are watching all bug changes.
[digikam] [Bug 425884] GPS Processing Method: "charset=Ascii" to remove
https://bugs.kde.org/show_bug.cgi?id=425884 --- Comment #2 from Nicofo --- (In reply to caulier.gilles from comment #1) > And ??? > > What did you expect from digiKam side ? you want to remove what ? The tags > content ? The whole tags as well from the list ? I expect that: charset=Ascii MANUAL is changed to: MANUAL GPSProcessingMethod is an EXIF tag that contains 8 bytes describing the encoding (in my case ASCII) + x bytes containing the value of the GPSProcessingMethod (in my case 6 bytes containing "MANUAL") Exiv2 output gives everything (encoding method + value), but of course only the value is interesting. So no need to display "charset=xxx" Note: > I seen the exiv2 report : > https://github.com/Exiv2/exiv2/issues/1266 This exiv2 report is indeed a bug in exiv2 tool but is not related to this one. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425884] GPS Processing Method: "charset=Ascii" to remove
https://bugs.kde.org/show_bug.cgi?id=425884 caulier.gil...@gmail.com changed: What|Removed |Added CC||caulier.gil...@gmail.com --- Comment #1 from caulier.gil...@gmail.com --- And ??? What did you expect from digiKam side ? you want to remove what ? The tags content ? The whole tags as well from the list ? I seen the exiv2 report : https://github.com/Exiv2/exiv2/issues/1266 It's clear that Exiv2 do not do the right job in background. Exiv2 code must be fixed in priority. I don't like to add a extra layer in client area because the low level as a problem and will not fixed quickly. We will make an hamburger. Best Glles Caulier -- You are receiving this mail because: You are watching all bug changes.
