[digikam] [Bug 449142] Existing People tag is deleted when ignoring face region of unconfirmed face with the people tag's name

2022-10-18 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=449142

Maik Qualmann  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/digikam/commit/9e730de |hics/digikam/commit/b6bfa28
   |086b0eb4626a880dfc0d0465be4 |01f437505e58a0926d118788232
   |e56133  |db4ea3
   Version Fixed In|7.6.0   |8.0.0
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #3 from Maik Qualmann  ---
Git commit b6bfa2801f437505e58a0926d118788232db4ea3 by Maik Qualmann.
Committed on 18/10/2022 at 06:13.
Pushed by mqualmann into branch 'master'.

only remove face tag if it was a confirmed one
FIXED-IN: 8.0.0

M  +1-6core/libs/database/tags/facetagseditor.cpp

https://invent.kde.org/graphics/digikam/commit/b6bfa2801f437505e58a0926d118788232db4ea3

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 449142] Existing People tag is deleted when ignoring face region of unconfirmed face with the people tag's name

2022-10-17 Thread José Oliver-Didier
https://bugs.kde.org/show_bug.cgi?id=449142

José Oliver-Didier  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 Ever confirmed|0   |1

--- Comment #2 from José Oliver-Didier  ---
Still happening in 7.9.0
I have many files which have "People Tags" with no face regions associated. I
clicked on the reject this suggestion to re-run the face recognition and
deleted a thousand of tags! I have the files backed up. This is a data loss
issue in my opinion.

Detailing the repo steps further. This time using lazy sync.

STEPS TO REPRODUCE
1. Run the Face Detection and Face recognition on a photo with a person's face
you know will immediately return a name.
2. For unconfirmed images under a particular person, say the suggested face is
"John Doe" (can be any other name in your collection).
Do not accept the suggestion for the face region, simply add the People Tag
"John Doe" from the Tag Manager to the image. - Save Metadata to File
3. Go to the People tab, search for the image with the suggested face which
displays "John Doe" and click on "Reject this suggestion" button on that image.
- Change pending / Save metadata to file

ENCOUNTERED BEHAVIOR:
- The suggested face region removes the existing "People Tag" with no face
region associated to it.

EXPECTED BEHAVIOR:
- The suggested face region is removed, but the existing "People Tag" should
remain. 
- Example: cases with images with multiple faces, suggested face region is
wrong and rejected - it strips the existing tag metadata from the file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 449142] Existing People tag is deleted when ignoring face region of unconfirmed face with the people tag's name

2022-01-25 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=449142

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||7.6.0
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/digikam/commit/9e730de
   ||086b0eb4626a880dfc0d0465be4
   ||e56133

--- Comment #1 from Maik Qualmann  ---
Git commit 9e730de086b0eb4626a880dfc0d0465be4e56133 by Maik Qualmann.
Committed on 25/01/2022 at 18:37.
Pushed by mqualmann into branch 'master'.

fix tag remove from unconfirmed face if ignored
FIXED-IN: 7.6.0

M  +9-3core/libs/database/tags/facetagseditor.cpp
M  +1-1core/libs/database/tags/facetagseditor.h

https://invent.kde.org/graphics/digikam/commit/9e730de086b0eb4626a880dfc0d0465be4e56133

-- 
You are receiving this mail because:
You are watching all bug changes.