[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2023-08-28 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #21 from Maik Qualmann  ---
Git commit 314d33677686cb88db21d33936b8003118971ff5 by Maik Qualmann.
Committed on 28/08/2023 at 22:14.
Pushed by mqualmann into branch 'master'.

ignore the date to compare the CaptionValues
I think it's safe to do this.

M  +2-2core/libs/metadataengine/containers/captionvalues.cpp

https://invent.kde.org/graphics/digikam/-/commit/314d33677686cb88db21d33936b8003118971ff5

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2023-08-28 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #20 from Maik Qualmann  ---
The problem occurs when there is a difference in
"Xmp.digiKam.CaptionsDateTimeStamps" between the images. I'm still unsure if we
ignore the date timestamp (it's hidden in the GUI in this case).

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2023-08-28 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #19 from Peter  ---
You said:
"If the content differs the text appears as disabled..."
"As I said, the text of the last selected item is dimmed and is therefore an
indication that the content of the other items is different..."

Here a small video (25 sec):
https://mega.nz/folder/8BxmyJzD#CwIdNXz65hu_QqVtkKCb4Q
This shows that digiKam incorrectly indicates that the captions are different,
even though they are exactly the same!
This function of digiKam is very unreliable!
I'm sorry, but I'm still of the opinion that this can cause information loss
(this is my own experience too!).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-12-02 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #18 from Maik Qualmann  ---
*** Bug 462535 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-07 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #17 from Maik Qualmann  ---
As I said, the text of the last selected item is dimmed and is therefore an
indication that the content of the other items is different. It should be clear
that if you edit the comment, the content will apply to all other selected
items (including languages).
Keep in mind that users who edit comments in bulk expect all items to have the
same content afterwards. If we start mixing comments and languages here, there
will be chaos.
I didn't really like the solution with the icon, because the layout changes
when it appears. I'm thinking about it again...

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #16 from Peter  ---
Your idea: "A possible idea would be this warning icon if the selected items in
the comments and title texts are different."
It was a very good idea... ...why did you throw it away?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #15 from Peter  ---
"Change a language and you will surely see the message."
Ok, tested it, but: The message display problem is not related to the language
settings.

Pic01 caption: A
Pic02 caption: B
Pic03 caption: default empty
In this case the captions is differents.

Select Pic01 and Pic02, but no warning message!!!
Press CTRL and select Pic03 too: "Selected items have different different text
here" message is appear.
Conclusion: The warning message appears when the caption of the last selected
image is blank.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #14 from Maik Qualmann  ---
The patch is included in this version and works as intended. If you see
"deactivated" text in the fields, this is also an indication that different
content is included. Change a language and you will surely see the message.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #13 from caulier.gil...@gmail.com ---
yes, the builds are done one time by day

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #12 from Peter  ---
Hi Gilles.
Thanks for answer. I tested digiKam-7.7.0-20220306T200649-Win64.exe, but not
contain this fix (or don't work fix?).
Perhaps later I try again...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=450567

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #11 from caulier.gil...@gmail.com ---
Future 7.7.0 pre-release bundles available here :

https://files.kde.org/digikam/

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-06 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #10 from Peter  ---
Hi Maik.
Which build will this fix be available?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-05 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

Maik Qualmann  changed:

   What|Removed |Added

   Version Fixed In||7.7.0
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/digikam/commit/5fd1ee7
   ||37ba4c8871deb4273aa028a2d3f
   ||7f72cc
 Resolution|--- |FIXED

--- Comment #9 from Maik Qualmann  ---
Git commit 5fd1ee737ba4c8871deb4273aa028a2d3f7f72cc by Maik Qualmann.
Committed on 05/03/2022 at 19:58.
Pushed by mqualmann into branch 'qt5-maintenance'.

inform with the placeholder text if different text here
FIXED-IN: 7.7.0

M  +2-1NEWS
M  +5-1core/libs/properties/captions/captionedit.cpp
M  +2-0core/libs/properties/captions/captionedit.h
M  +34   -1core/libs/properties/captions/itemdescedittab.cpp
M  +3-0core/libs/properties/captions/itemdescedittab.h

https://invent.kde.org/graphics/digikam/commit/5fd1ee737ba4c8871deb4273aa028a2d3f7f72cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-03-04 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #8 from Peter  ---
(In reply to Maik Qualmann from comment #6)
> Created attachment 147080 [details]
> warning-icon
> 
> A possible idea would be this warning icon if the selected items in the
> comments and title texts are different.
> 
> Maik

Hi Maik.
Your idea (warning icon) and disable the edit field if the caption is
different. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-23 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #7 from Peter  ---
Not a bad idea!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-23 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #6 from Maik Qualmann  ---
Created attachment 147080
  --> https://bugs.kde.org/attachment.cgi?id=147080=edit
warning-icon

A possible idea would be this warning icon if the selected items in the
comments and title texts are different.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-20 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #5 from Peter  ---
In my opinion lost image information is more annoying than the warning
window...
...but, if the digikam  would allow the information to be expansion in the case
of a group selection, maybe this problem would be solved.
What I mean?

Image_1 : Caption: A
Image_2 : Caption: B
Select: Image_1 and Image_2
Add a new information: C
In this case
Image_1 new caption: A C
Image_2 new caption: B C

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-20 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #4 from Maik Qualmann  ---
If the metadata is different, the input fields will be "dimmed" and look as if
they are disabled. Depending on the color scheme, it may not be immediately
obvious. What I definitely don't want is any warning message popping up. Right
now I have no idea how we can better tell the user that the metadata isn't the
same...
Other users should not be annoyed by a popup either.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-19 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #3 from Maik Qualmann  ---
No, we don't need a warning window here. The idea in the background is actually
that you should see a grayed out caption or title in the window if they are not
identical. In light letters if they are all the same. The problem is, if your
last selected image does not contain a caption/title, an empty content will be
displayed. I fix it...

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-19 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

--- Comment #2 from Peter  ---
(In reply to Maik Qualmann from comment #1)
> It is actually clear that if you mark several images, the change goes to all
> images.

This function works well, but if the user is inattentive or does not check
images before performing a group operation, existing captions may be lost, and
unfortunately, digikam does not warn you that there is a captioned image in the
album.
For many hundreds of images, the user must check all the images in the album,
before performing a group operation.

A warning window would be nice!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-19 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=450567

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #1 from Maik Qualmann  ---
It is actually clear that if you mark several images, the change goes to all
images. This is no different with a template or when you change the rating.
Even if some images already have a rating, all will be set to the new value.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 450567] When editing a group caption, the digikam does not warn of possible information loss.

2022-02-19 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=450567

Peter  changed:

   What|Removed |Added

Summary|When editing a group|When editing a group
   |caption, the digikam does   |caption, the digikam does
   |not warn of possible data   |not warn of possible
   |loss.   |information loss.

-- 
You are receiving this mail because:
You are watching all bug changes.