[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #28 from Maik Qualmann --- Git commit e3028bd8610c43783e377445aca578645dfdabf0 by Maik Qualmann. Committed on 08/05/2024 at 19:11. Pushed by mqualmann into branch 'master'. try moving it to the main thread. The thread is identical under Linux, but perhaps not under macOS. M +2-1 core/dplugins/generic/metadata/geolocationedit/geolocationeditplugin.cpp M +2-1core/dplugins/generic/metadata/timeadjust/timeadjustplugin.cpp https://invent.kde.org/graphics/digikam/-/commit/e3028bd8610c43783e377445aca578645dfdabf0 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #27 from caulier.gil...@gmail.com --- Maik, Passing the active windows as parent to the plugins dialog do not change anything... Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #26 from caulier.gil...@gmail.com --- Git commit c1fd8e1ad84fcc4425e248fe3afdfaa5e8ef427d by Gilles Caulier. Committed on 07/05/2024 at 15:58. Pushed by cgilles into branch 'master'. pass the active windows as parent to the Geolocation and TimeAdjust dialogs M +2-1 core/dplugins/generic/metadata/geolocationedit/geolocationeditplugin.cpp M +2-1core/dplugins/generic/metadata/timeadjust/timeadjustplugin.cpp https://invent.kde.org/graphics/digikam/-/commit/c1fd8e1ad84fcc4425e248fe3afdfaa5e8ef427d -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #25 from caulier.gil...@gmail.com --- Yes, this can be the origin. The Q is why in this case, Linux and Windows are not affected ? Note : MacOS still uses Qt5... Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #24 from Maik Qualmann --- It could also be the parent from the first dialog. The maintenance tool has the digikamApp as parent, the Geolocation Editor and the Time Adjust Tool has a nullptr as parent. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #23 from Maik Qualmann --- Could it also be because we have already modified the first/basic dialog via the window flags -> QDialog to QWindow? We did this once because of problems with Gnome. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #22 from caulier.gil...@gmail.com --- The Maintenance Tool dialog under MacOS / Image Quality / Settings : the setup dialog work as expected. Perhaps the plugin wizard/dialog as a property than a child dialog don't like. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #21 from caulier.gil...@gmail.com --- Time Adjust dialog under MacOS: the Determine clock difference dialog has also strange side effects. The way to open a dialog from a dialog under MacOS do not work as expected (where Linux and Windows work fine). -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #20 from caulier.gil...@gmail.com --- And why the Edit Bookmark dialog still open below than the Geolocation Edit dialog ? This is really strange... -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #19 from caulier.gil...@gmail.com --- I tried the Edit Bookmark under Linux, and the dialog is exactly the same than under MacOS. The missing icons buttons are also there... -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #18 from caulier.gil...@gmail.com --- Another point : the cursor in the Edit bookmark "Search" field is blinking, but the mouse has no action over this dialog. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #17 from Maik Qualmann --- The map in the Bookmark Manager is only loaded when you have added a bookmark and clicked on it. So the screenshot looks normal for empty bookmarks. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #16 from caulier.gil...@gmail.com --- Link to the second screenshot : https://i.imgur.com/q64EBvk.png -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #15 from caulier.gil...@gmail.com --- Maik, As you can see on this second screenshot, the map is well displayed on the Geolocation dialog and all icons are present. Sound like a lock in Marble. Note : There is no bookmark registered yet on my computer. Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #14 from caulier.gil...@gmail.com --- Hi Maik, Look my screenshot : https://i.imgur.com/wCJXdON.png Before to open the Edit Bookmark dialog, i moved the geolocation dialog on the right side of screen. The Bookmark dialog appears on the middle of the screen but is not complete. Map is not loaded and some icons are missing. I think the dialog code is blocked somewhere. Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #13 from caulier.gil...@gmail.com --- Git commit 747bbe9204c0f509761e8fa35ecc142c60a9a44f by Gilles Caulier. Committed on 06/05/2024 at 21:42. Pushed by cgilles into branch 'master'. set dialog modal M +3-0core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp https://invent.kde.org/graphics/digikam/-/commit/747bbe9204c0f509761e8fa35ecc142c60a9a44f -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #12 from caulier.gil...@gmail.com --- changing the edit bookmark dialog parent to active windows do not fix the problem -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #11 from caulier.gil...@gmail.com --- Git commit 16567cfe1e40838b1fab63e7d3168f49cab22919 by Gilles Caulier. Committed on 06/05/2024 at 11:14. Pushed by cgilles into branch 'master'. use same window flags than DPlugin About Dialog M +4-1core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp M +1-1 core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp https://invent.kde.org/graphics/digikam/-/commit/16567cfe1e40838b1fab63e7d3168f49cab22919 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #10 from caulier.gil...@gmail.com --- Maik, I think the problem under MacOS can be the flags passed to dialog here : https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp?ref_type=heads#L80 If i take a look to other setWindowFlags() call in digiKam core, we never use Qt::Sheet, but always a customized combination as this one : https://invent.kde.org/graphics/digikam/-/blob/master/core/libs/dplugins/widgets/dplugindialog.cpp?ref_type=heads#L46 Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #9 from caulier.gil...@gmail.com --- Git commit 1c890c7017e021b471fe5fe1834eedfb0437d1ac by Gilles Caulier. Committed on 06/05/2024 at 11:03. Pushed by cgilles into branch 'master'. pass active windows parent to the dialog M +2-1 core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp https://invent.kde.org/graphics/digikam/-/commit/1c890c7017e021b471fe5fe1834eedfb0437d1ac -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #8 from Maik Qualmann --- We could test a different parent for the dialog (qApp->activeWindow()). Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #7 from caulier.gil...@gmail.com --- Maik, I think it's not a raise problem with the dialog. In fact the dialog is open and presnet on screen, but show behind the metadata editor dialog. If i move this last one, bookmarks editor appear, but is not suitable : the mouse has no effect. It sounds like a even loop problem. Not that the bookmarks editor dialog has the 3 buttons on the title bar. So it can be reduced. Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #6 from Maik Qualmann --- Git commit 866f0532c62d0b8934ed4f965f151b9564db5720 by Maik Qualmann. Committed on 06/05/2024 at 06:28. Pushed by mqualmann into branch 'master'. try to bring the bookmark dialog to the front M +1-0 core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp https://invent.kde.org/graphics/digikam/-/commit/866f0532c62d0b8934ed4f965f151b9564db5720 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #5 from caulier.gil...@gmail.com --- Hi, The Edit Bookmarks work but don"t show the dialog with the focus by default. Go to the mac taskbar digiKam icon context menu and select the Show All Windows. The bookmarks editor dialog appears... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com --- Comment #4 from Maik Qualmann --- I don't really see an error. The dialog also works under Windows. I'm surprised by the (!) in front of !d->bookmarksDialog->isHidden(). Because if the dialog is hidden, it can also be reactivated. We also use the same code in the plugin dialogs for reactivation. However, it doesn't matter because the pointer is NULL at the start anyway. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #3 from caulier.gil...@gmail.com --- There is probably something wrong under MacOS here : https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp?ref_type=heads#L117 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 caulier.gil...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 CC||caulier.gil...@gmail.com Status|REPORTED|CONFIRMED --- Comment #2 from caulier.gil...@gmail.com --- Yes, it's fully reproducible under MacOS with 8.3.0. Under Linux all works as expected... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 486341] Edit Bookmarks menu item does nothing
https://bugs.kde.org/show_bug.cgi?id=486341 --- Comment #1 from Mark --- Sorry, step 3 should say "Right-click a image from Geolocation Edit dialog list and choose Edit Bookmarks" -- You are receiving this mail because: You are watching all bug changes.
