https://bugs.kde.org/show_bug.cgi?id=295526
Nate Graham changed:
What|Removed |Added
Version Fixed In||18.12.0
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/dol
||phin/cf0052c2968a7c3e110e24
||134dbe7ef13c835995
--- Comment #33 from Nate Graham ---
Git commit cf0052c2968a7c3e110e24134dbe7ef13c835995 by Nathaniel Graham.
Committed on 06/09/2018 at 20:47.
Pushed by ngraham into branch 'master'.
Make thumbnail frame-and-shadow drawing criteria match those of the file dialog
Summary:
KIO's file dialog already has logic to avoid drawing frames around images
detected as likely to be icons, which is improved with D15071. Since Dolphin
doesn't use KIO for any of this (boo) we have to pull it over here too; this
patch brings the same feature to Dolphin, as well as the feature to disable
frames and shadows for all thumbnails at very small sizes, which improves
clarity.
With this patch, Dolphin's frame drawing behavior becomes consistent with that
of the file dialog (as of D15071).
FIXED-IN: 18.12.0
Test Plan:
Icons no longer have frames:
{F6214279}
Images without transparency still have frames:
{F6214280}
Nicer presentation for folders with mixed image types (images without
transparency get frames; images without it don't):
{F6214278}
At small sizes, thumbnail clarity is improved by omitting the frame and shadow.
Before:
{F6214296}
After:
{F6214294}
Reviewers: #dolphin, broulik, elvisangelaccio
Reviewed By: #dolphin, broulik, elvisangelaccio
Subscribers: markg, anthonyfieroni, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D15069
M +3-8src/kitemviews/kfileitemmodelrolesupdater.cpp
https://commits.kde.org/dolphin/cf0052c2968a7c3e110e24134dbe7ef13c835995
--
You are receiving this mail because:
You are watching all bug changes.
