[dolphin] [Bug 367626] No previews for cbr comic books

2017-09-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=367626

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Nate Graham  ---
Fantastic! Gettin' things done...

-- 
You are receiving this mail because:
You are watching all bug changes.


[dolphin] [Bug 367626] No previews for cbr comic books

2017-09-04 Thread Rog131
https://bugs.kde.org/show_bug.cgi?id=367626

--- Comment #4 from Rog131  ---
Fixed with the commit c734c5d5a1b47f749ef9230454f963b3b7daf573.

https://cgit.kde.org/kio-extras.git/commit/?id=c734c5d5a1b47f749ef9230454f963b3b7daf573

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 367626] No previews for cbr comic books

2017-09-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=367626

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Nate Graham  ---
Massimiliano, would you be able to upload a patch for the CBR plugin to
http://phabricator.kde.org/? Looks like it should be a one-character change.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 367626] No previews for cbr comic books

2017-01-20 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=367626
Bug 367626 depends on bug 341305, which changed state.

Bug 341305 Summary: kio thumbnail slave unable to create previews for .cbr 
files due to inabillity to identify unrar due to unrar having removed the 
--version flag since unrar 5.2.1
https://bugs.kde.org/show_bug.cgi?id=341305

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 367626] No previews for cbr comic books

2016-10-24 Thread Massimiliano Torromeo via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367626

Massimiliano Torromeo  changed:

   What|Removed |Added

 CC||massimiliano.torromeo@gmail
   ||.com

--- Comment #2 from Massimiliano Torromeo  ---
I took a look at the source code and found the problem.

When the archive is a rar file the thumbnailer has an algorithm to identify the
presence of an unrar binary and when it finds one in the path it calls it with
"--version" but both that unrar and rar binaries do not accept that argument
and instead they expect arguments to have a single dash (just "-version").

I tested this with a dirty hack (tm) by moving /usr/bin/unrar to
/usr/bin/unrar-bin and replacing it with the a bash script and the thumbnails
are now being generated correctly.

For anyone interested, the script looks like this (do not forget to "chmod
755"):

#!/bin/bash
if [ "$1" = "--version" ]; then
exec unrar-bin -version
fi
exec unrar-bin "$@"

-- 
You are receiving this mail because:
You are watching all bug changes.


[dolphin] [Bug 367626] No previews for cbr comic books

2016-08-21 Thread anewuser via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367626

anewuser  changed:

   What|Removed |Added

 Depends on||341305

-- 
You are receiving this mail because:
You are watching all bug changes.


[dolphin] [Bug 367626] No previews for cbr comic books

2016-08-21 Thread Rog131 via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367626

Rog131  changed:

   What|Removed |Added

 CC||samrog...@hotmail.com

--- Comment #1 from Rog131  ---
A possible dublicate of the Bug 341305 - kio thumbnail slave unable to create
previews for .cbr files due to inabillity to identify unrar due to unrar having
removed the --version flag since unrar 5.2.1:
https://bugs.kde.org/show_bug.cgi?id=341305

-- 
You are receiving this mail because:
You are watching all bug changes.