[dolphin] [Bug 388555] renamed file reclaims focus

[Mircea Kitsune]

https://bugs.kde.org/show_bug.cgi?id=388555

--- Comment #9 from Mircea Kitsune  ---
This has been a huge annoyance to me as well for quite some time. Thank you for
fixing it!

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=388555

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||sonichedgehog_hyperblast00@
   ||yahoo.com

--- Comment #8 from Elvis Angelaccio  ---
*** Bug 389809 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=388555

Elvis Angelaccio  changed:

   What|Removed |Added

   Version Fixed In||18.03.80

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/dol
   ||phin/bba44ae907b4faaf115d33
   ||fb0a3c50cd96ee2cb6

--- Comment #7 from Nate Graham  ---
Git commit bba44ae907b4faaf115d33fb0a3c50cd96ee2cb6 by Nathaniel Graham, on
behalf of Andreas Krutzler.
Committed on 21/01/2018 at 20:43.
Pushed by ngraham into branch 'master'.

Fix renamed file reclaims focus

Summary:
After renaming a file and then selecting another file immediately the just
selected file stays selected.

Test Plan:
Steps to reproduce:
$ mkdir /tmp/test
$ cd /tmp/test
$ touch a.tmp b.tmp
$ dolphin /tmp/test

In dolphin:
* select a.tmp
* 
* type aaa
* select b.tmp immediately

Expected result:
* a.tmp renamed to aaa.tmp
* b.tmp stays selected, aaa.tmp stays unselected

Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio

Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio

Subscribers: emateli, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D9711

M  +33   -26   src/views/dolphinview.cpp

https://commits.kde.org/dolphin/bba44ae907b4faaf115d33fb0a3c50cd96ee2cb6

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

--- Comment #6 from Nate Graham  ---
Thanks to Andreas, we have a potential patch that fixes the issue:
https://phabricator.kde.org/D9711

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

Nate Graham  changed:

   What|Removed |Added

 CC||pe...@hack-libre.org

--- Comment #5 from Nate Graham  ---
*** Bug 38 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388555

--- Comment #4 from andreas.krutz...@gmx.net ---
As far as I can tell this is not related to the fixes of Bug 205157 or Bug
378786. But it could be related to https://phabricator.kde.org/D6312.

Lets see if I can fix that in the next few days :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

--- Comment #3 from Nate Graham  ---
(And if you want to dig into this yourself and figure it out, Michael, please
feel free to submit a patch!)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388555

--- Comment #2 from ottw...@gmail.com ---
If you hit  fast enough you can even rename b.tmp *and* have aaa.tmp
selected.
After that focus stays at aaa.tmp

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=388555

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|dolphin-bugs-n...@kde.org   |andreas.krutz...@gmx.net
 Status|UNCONFIRMED |CONFIRMED
 CC||pointedst...@zoho.com

--- Comment #1 from Nate Graham  ---
Can reproduce. This happens if you select another file *immediately* after
renaming; it seems that there's some timer that waits a moment before forcing
selection on the newly-renamed file, and fast users can beat it and get their
desired new selection reset to the old renamed file.

Could be related to the recent fixes for Bug 205157 or Bug 378786. Andreas,
would you mind having a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 388555] renamed file reclaims focus

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388555

ottw...@gmail.com changed:

   What|Removed |Added

 CC||ottw...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.