[dolphin] [Bug 392743] Crash when renaming (not using inline rename)

[Scott Harvey]

https://bugs.kde.org/show_bug.cgi?id=392743

Scott Harvey  changed:

   What|Removed |Added

 CC||bund...@gmail.com

--- Comment #5 from Scott Harvey  ---
Beat me to it. I was going to attempt this, but I doubt I could have done it as
quickly as Elvis did. At least I know my idea was roughly correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 392743] Crash when renaming (not using inline rename)

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=392743

Elvis Angelaccio  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/30349ef1bdcae0ed80f47c
   ||168d46c15020b927d3
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||18.03.90

--- Comment #4 from Elvis Angelaccio  ---
Git commit 30349ef1bdcae0ed80f47c168d46c15020b927d3 by Elvis Angelaccio.
Committed on 05/04/2018 at 21:15.
Pushed by elvisangelaccio into branch 'Applications/18.04'.

[RenameDialog] Fix crash when renaming single items

Summary:
`m_spinBox` is initialized only when renaming multiple items.

This commit restores the single-item rename logic which was wrongly
removed by commit c5eb4e31161ccf422.
FIXED-IN: 18.03.90

Test Plan: Disable inline renaming and try to rename single or multiple items
(and also to undo the jobs).

Subscribers: #dolphin

Differential Revision: https://phabricator.kde.org/D11972

M  +11   -4src/views/renamedialog.cpp

https://commits.kde.org/dolphin/30349ef1bdcae0ed80f47c168d46c15020b927d3

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 392743] Crash when renaming (not using inline rename)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=392743

Christoph Feck  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Christoph Feck  ---
https://cgit.kde.org/dolphin.git/commit/src/views?id=c5eb4e31161ccf422a2f2492fe998c5c9817bea4
removed the code for the simple rename KIO::moveAs call, but instead always
uses KIO::batchRename. Only the undo logic checks for the simple rename.

For the simple rename, KIO::batchRename cannot be used, because it always tries
to either replace or append the running index number.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 392743] Crash when renaming (not using inline rename)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=392743

--- Comment #2 from Christoph Feck  ---
Well, there is no QSpinBox in the simple rename dialog. The new code probably
was written with the more complex rename dialog in mind.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 392743] Crash when renaming (not using inline rename)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=392743

Christoph Feck  changed:

   What|Removed |Added

 CC||chinmoyr...@gmail.com

--- Comment #1 from Christoph Feck  ---
This might be a bug in 18.04 branch, too.

-- 
You are receiving this mail because:
You are watching all bug changes.