[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-03-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399430

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||19.04.0
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/303cd17444e1fb88d1f92a
   ||911f7c770214b8f90e

--- Comment #24 from Nate Graham  ---
Git commit 303cd17444e1fb88d1f92a911f7c770214b8f90e by Nate Graham, on behalf
of Tigran Gabrielyan.
Committed on 20/03/2019 at 16:46.
Pushed by ngraham into branch 'Applications/19.04'.

Fix rearranging items in places panel with hidden items

Summary:
`m_sourceModel->movePlace` is called using index from the view model.
This becomes an issue when there are hidden places items.

This change calls `m_sourceModel->movePlace` using the corresponding mapped
source index.
FIXED-IN: 19.04.0

Test Plan:
  # Create at least 4 Places items
  # Hide first item
  # Drag the now first visible item between second and third item

Actual: The item does not move
Expected: The first visible item should now be second visible item in the list

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19901

M  +4-1src/panels/places/placesitemmodel.cpp

https://commits.kde.org/dolphin/303cd17444e1fb88d1f92a911f7c770214b8f90e

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-12 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #23 from udevn...@t-online.de ---
(In reply to lurulf from comment #22)
> It really seems that you have a hidden entry between your "from" and "to"
> destination. Right-click on an empty area of the places panel, and I bet you
> get an option "Show hidden places" or "Show all entries". When you get the
> "move, copy, link" options, you have dropped an entry above another. You
> have to place it between two entries so the blue border line appears. Hope
> this help.

That might help, yes, but doesn't solve the problem that it used to work
without workaround and now it doesn't.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread lurulf
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #22 from lurulf  ---
It really seems that you have a hidden entry between your "from" and "to"
destination. Right-click on an empty area of the places panel, and I bet you
get an option "Show hidden places" or "Show all entries". When you get the
"move, copy, link" options, you have dropped an entry above another. You have
to place it between two entries so the blue border line appears. Hope this
help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #21 from roger herz-fischler  ---
Created attachment 117368
  --> https://bugs.kde.org/attachment.cgi?id=117368=edit
an attempt to move a directory  up

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #20 from roger herz-fischler  ---
Created attachment 117367
  --> https://bugs.kde.org/attachment.cgi?id=117367=edit
christoph feck comment

I was unable to locate

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #19 from roger herz-fischler  ---
Created attachment 117366
  --> https://bugs.kde.org/attachment.cgi?id=117366=edit
dolphin handbook: configuration

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #18 from roger herz-fischler  ---
Created attachment 117365
  --> https://bugs.kde.org/attachment.cgi?id=117365=edit
configuration search 03

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #17 from roger herz-fischler  ---
Created attachment 117364
  --> https://bugs.kde.org/attachment.cgi?id=117364=edit
configuration search 02

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #16 from roger herz-fischler  ---
Created attachment 117363
  --> https://bugs.kde.org/attachment.cgi?id=117363=edit
configuration file search 01

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #15 from roger herz-fischler  ---
Created attachment 117362
  --> https://bugs.kde.org/attachment.cgi?id=117362=edit
parker reed comment re work around

I had already tried to find the configuration file, but as the snapshots show I
can not find it

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #14 from roger herz-fischler  ---
Created attachment 117361
  --> https://bugs.kde.org/attachment.cgi?id=117361=edit
configuration file for Dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread roger herz-fischler
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #13 from roger herz-fischler  ---
Created attachment 117360
  --> https://bugs.kde.org/attachment.cgi?id=117360=edit
configuration file for Dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-09 Thread lurulf
https://bugs.kde.org/show_bug.cgi?id=399430

lurulf  changed:

   What|Removed |Added

 CC||frodekolg...@gmail.com

--- Comment #12 from lurulf  ---
Yes, can confirm this. Workaround works. I had the Desktop entry hidden...

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2019-01-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=399430

Christoph Feck  changed:

   What|Removed |Added

 CC||k...@herz-fischler.ca

--- Comment #11 from Christoph Feck  ---
*** Bug 402980 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-12-18 Thread KDErobo3me
https://bugs.kde.org/show_bug.cgi?id=399430

KDErobo3me  changed:

   What|Removed |Added

 CC||k...@robo3.me

--- Comment #10 from KDErobo3me  ---
I confirm the bug. usability suffers here. But nice to read about the workround
at least. Would be nice if it could be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-12-09 Thread Markel Cuesta Manciles
https://bugs.kde.org/show_bug.cgi?id=399430

Markel Cuesta Manciles  changed:

   What|Removed |Added

 CC||wakutiteo...@protonmail.com

--- Comment #9 from Markel Cuesta Manciles  ---
(In reply to Nate Graham from comment #4)
> I've intermittently seen this with 18.08 and git master, but I've never been
> able to come up with a reproducible test case.

The bug happens when you have any entry hidden and it's above or between the
entries that you want to reorder. But if the hidden entry is below the icons
that you want to reorder, it works.

And always works if 'Show All Entries' is checked.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-11-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=399430

Christoph Feck  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #8 from Christoph Feck  ---
*** Bug 395269 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-22 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=399430

Patrick Silva  changed:

   What|Removed |Added

 CC||lcswill...@gmail.com

--- Comment #7 from Patrick Silva  ---
*** Bug 400172 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-15 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=399430

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399430

Nate Graham  changed:

   What|Removed |Added

 CC||renatooliveira@gmail.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-12 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=399430

--- Comment #6 from Christoph Feck  ---
Reporter of bug 399722: reordering works if "Show all entries" is checked!

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-12 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=399430

Christoph Feck  changed:

   What|Removed |Added

 CC||rockonthemoo...@gmail.com

--- Comment #5 from Christoph Feck  ---
*** Bug 399722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399430

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Keywords||usability

--- Comment #4 from Nate Graham  ---
I've intermittently seen this with 18.08 and git master, but I've never been
able to come up with a reproducible test case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-11 Thread Parker Reed
https://bugs.kde.org/show_bug.cgi?id=399430

Parker Reed  changed:

   What|Removed |Added

 CC||parker.l.r...@gmail.com

--- Comment #3 from Parker Reed  ---
Found a workaround: open any KDE file dialog (I used Ctrl O in Chrome) and sort
the entries there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-11 Thread Julian Schraner
https://bugs.kde.org/show_bug.cgi?id=399430

Julian Schraner  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||juliquad...@gmail.com
 Status|REPORTED|CONFIRMED

--- Comment #2 from Julian Schraner  ---
Confirmed, if somebody who runs Dolphin 17.12.3 could test this that'd be
great.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 399430] Dolphin: Places: Regression: Move items up/down not working properly

2018-10-07 Thread Richard Bowen
https://bugs.kde.org/show_bug.cgi?id=399430

Richard Bowen  changed:

   What|Removed |Added

 CC||rgb@gmail.com

--- Comment #1 from Richard Bowen  ---
Have a similar issue. Cant move a specific folder above trash. Whenever I try,
the items remain in the same position.

-- 
You are receiving this mail because:
You are watching all bug changes.