[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 Titir Adhikary changed: What|Removed |Added CC||slashkey...@outlook.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 Nate Graham changed: What|Removed |Added Keywords|junior-jobs | -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 --- Comment #6 from Nate Graham --- Super awesome, thanks. Let's continue the conversation in the patch review request! -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 --- Comment #5 from Tommy Lincoln --- (In reply to Nate Graham from comment #4) Thanks! I went ahead and submitted to phabricator. I just wasn't sure if I should get a separate ticket going since it's not technically a change to Dolphin. My submission is at https://phabricator.kde.org/D24993, and I referenced this ticket. If that change gets accepted, the change to Dolphin is a simple one-liner to to take advantage. Let me know if I should do that as well, otherwise I'll hold off until the current change gets through. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 --- Comment #4 from Nate Graham --- That's pretty cool! FWIW the reason why you might not have gotten a response yet is because patches are submitted using https://phabricator.kde.org, not GitHub PRs. The documentation is https://community.kde.org/Infrastructure/Phabricator. Let me know if you need a hand submitting it there! -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 --- Comment #3 from Tommy Lincoln --- Despite the "junior-jobs" tag, I didn't see any simple way of accomplishing this. I suppose I got carried away, but I sort of got sucked in to the problem. Here's the solution I worked up for KTextEdit, including a screenshot and link to a diff for Dolphin to make use of the change: https://github.com/KDE/ktextwidgets/compare/master...pajamapants3000:400647 This was fun so no worries if it can't be used; even though I haven't gotten a response yet, it seemed silly to not share the solution I had worked up. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 Tommy Lincoln changed: What|Removed |Added CC||pajamapants3...@gmail.com --- Comment #2 from Tommy Lincoln --- I was wondering if it might be better to add a flag to the KTextEdit widget (in KTextWidgets) that allows the user to specify whether Sonnet's own dialog should be used, or whether its results and functionality should be integrated into the standard context menu. This seems like a change that wouldn't just be relevant to Dolphin, but any application using KTextEdit. If so, I could open a ticket for this change under KTextEdit and work on that, then come back here and set the flag in Dolphin (assuming we'd want the new flag to default to the current behavior). Thoughts? Would I open something here, at bugs.kde.org, or at phabricator? This doesn't really seem like a bug, but more of a change request. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 400647] While inline renaming, integrate spelling suggestions menu with regular context menu to avoid hiding any features
https://bugs.kde.org/show_bug.cgi?id=400647 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Keywords||junior-jobs Summary|Inline rename context menu |While inline renaming, ||integrate spelling ||suggestions menu with ||regular context menu to ||avoid hiding any features CC||n...@kde.org Severity|normal |minor Status|REPORTED|CONFIRMED --- Comment #1 from Nate Graham --- The simplified version of the issue is that when the insertion point is immediately to the left or or within a red-underlined word, right-clicking will bring up a spelling menu instead of the typical context menu. It only happens if the insertion point is immediately to the left or or within a red-underlined word. -- You are receiving this mail because: You are watching all bug changes.
