[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 Antonio Rojas changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/dol ||phin/faa37a6138fc0a7458f61d ||2799370994b936396e Resolution|--- |FIXED --- Comment #10 from Antonio Rojas --- Git commit faa37a6138fc0a7458f61d2799370994b936396e by Antonio Rojas. Committed on 09/12/2019 at 22:21. Pushed by arojas into branch 'release/19.12'. Fix build with Qt 5.14 RC Add needed Qt includes that are no longer pulled transitively. Differential Revision: https://phabricator.kde.org/D25783 M +1-0src/global.h M +1-0src/kitemviews/kstandarditem.h M +2-0src/search/dolphinsearchbox.cpp M +1-0src/settings/dolphinsettingsdialog.cpp M +1-0src/settings/general/previewssettingspage.cpp M +1-0src/settings/services/servicessettingspage.cpp M +1-0src/views/draganddrophelper.cpp https://commits.kde.org/dolphin/faa37a6138fc0a7458f61d2799370994b936396e -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 Antonio Rojas changed: What|Removed |Added CC||aro...@archlinux.org --- Comment #9 from Antonio Rojas --- Are you going to submit the patch for merging? This should be included in the 19.12 tarball. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 Laurent Montel changed: What|Removed |Added CC||mon...@kde.org --- Comment #8 from Laurent Montel --- I confirm with last qt5.14 that there is a compile error. So patch seems ok -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 David Faure changed: What|Removed |Added CC||fa...@kde.org --- Comment #7 from David Faure --- This is. interesting. I'm using Qt 5.4 from git (54f5b89750, 2 weeks ago) and dolphin builds fine. So I looked at how qevent.h gets included by views/draganddrophelper.cpp (easy technique: put #error in qevent.h), and it turns out that the generated header include/QtGui/QList says: #include !!! I have no idea why this forwarding header even exists, there's include/QtCore/QList which includes qlist.h as it should. Ah, that's a bug that got fixed in Qt recently. Commit 5771b5325b85 in qtbase says commit 5771b5325b85f71a8f8ff78ed13eaee3df2e3ba8 Author: Andy Shaw Date: Tue Nov 5 22:10:24 2019 +0100 syncqt: Add a means to suspend/resume the processing of a file Rather than tweaking the parser to cover every eventuality with corner case lines that could cause incorrect header files to be created then the means to suspend/resume the processing of a file is added. This enables us to have it skip over the template line that is causing a QList header to be created as part of the QtGui headers. This patch includes the fix to solve this in addition. Fixes: QTBUG-68129 Change-Id: I751646c4b20a4434347c149ae5e6dcb6e7618853 Reviewed-by: Joerg Bornemann So your fixes seem correct to me. Suddenly includes qlist.h and not qevent.h anymore... Man, I'm not looking forward to updating my qt git and fixing compilation in the 399 modules I build.. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 --- Comment #6 from Elvis Angelaccio --- What is your Qt version exactly? Did you build Qt by yourself or it's from your distro? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 --- Comment #5 from bluescreenaven...@gmail.com --- Created attachment 124163 --> https://bugs.kde.org/attachment.cgi?id=124163=edit this patch gets Dolphin to compile against qt5.14 Not sure if I placed the headers in the best places... -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 --- Comment #4 from bluescreenaven...@gmail.com --- But this one does NOT seem to be based on if the .git folder exist. There are no add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06) lines -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 --- Comment #3 from bluescreenaven...@gmail.com --- Yeah, I'm building from Git -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 --- Comment #2 from Christoph Feck --- Is this related to git vs. non-git builds? See bug 414493. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14
https://bugs.kde.org/show_bug.cgi?id=414492 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org --- Comment #1 from Elvis Angelaccio --- Builds fine here with Qt 5.14 beta3. -- You are receiving this mail because: You are watching all bug changes.
