[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #21 from Elvis Angelaccio --- Git commit 8e2f0a1d5b88f9ac6e06a0ac7a64d7080198f678 by Elvis Angelaccio, on behalf of Alexander Lohnau. Committed on 05/09/2020 at 17:32. Pushed by elvisangelaccio into branch 'master'. Clear services model after KNS entries changed We can not know if a service got deleted, so we clear the model and reload the services. The issue that the entries are not uninstalled has already been solved, this is just a patch to fix the state of the UI. M +7-0src/settings/servicemodel.cpp M +1-0src/settings/servicemodel.h M +7-1src/settings/services/servicessettingspage.cpp https://invent.kde.org/system/dolphin/commit/8e2f0a1d5b88f9ac6e06a0ac7a64d7080198f678 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #20 from Alexander Lohnau --- >And Set as Wallpaper is still present in Services section after uninstalling >until Dolphin settings are reopened. Hmm okay. I will look into it. For the others we would need to contact the authors to fix the installation. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #19 from Patrick Silva --- Tested these services on neon unstable: Set as Wallpaper KDE Services KDE 5 Service Menu ReImage getMediaInfo Autoversion Simple send as Attachment with Kmail Mediainfo Service Menu Mediainfo Service Menu and Set as Wallpaper are the only ones successfully installed, but Mediainfo Service Menu is not listed in Services section of Dolphin settings. And Set as Wallpaper is still present in Services section after uninstalling until Dolphin settings are reopened. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.74.0 Qt Version: 5.14.2 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #18 from Alexander Lohnau --- On related note, I have made a version of the mediainfo plugin which actually works: https://www.pling.com/p/1418250/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Alexander Lohnau changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #17 from Alexander Lohnau --- Marking this as fixed again, that is a problem with the individual plugins. They will be removed from the list of downloadable entries since they are not maintained anymore. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #16 from Patrick Silva --- (In reply to Alexander Lohnau from comment #15) > > this one not even appears in "Services" section of Dolphin settings after > > apparently successful installation > > Huh can confirm, this seems to be an issue on the service menu loading side > of things. > > The installer should just put the files in the right location, which works > as it should. https://bugs.kde.org/show_bug.cgi?id=405186 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #15 from Alexander Lohnau --- > this one not even appears in "Services" section of Dolphin settings after > apparently successful installation Huh can confirm, this seems to be an issue on the service menu loading side of things. The installer should just put the files in the right location, which works as it should. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Patrick Silva changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #14 from Patrick Silva --- Unfortunately this bug persists after update to frameworks 5.71. Uninstalled services are still present in Services section until Dolphin settings is reopened. I even tested with a new user account installing these services: dolphin folder color (this one not even appears in "Services" section of Dolphin settings after apparently successful installation) set as wallpaper color folder getMediaInfo (Dolphin crashed when I reopened its settings after install this one - reported as bug 423027) Operating System: Arch Linux KDE Plasma Version: 5.19.0 KDE Frameworks Version: 5.71.0 Qt Version: 5.15.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Alex changed: What|Removed |Added Latest Commit|https://cgit.kde.org/knewst |https://commits.kde.org/kne |uff.git/commit/?id=4c6b3afc |wstuff/a2ecdd333c492d3e4be5 |d80a7b03e0381e2a5c8bb693a8f |c21301374073784f1b60 |916fd | --- Comment #13 from Alex --- Git commit a2ecdd333c492d3e4be5c21301374073784f1b60 by Alexander Lohnau. Committed on 11/05/2020 at 18:39. Pushed by alex into branch 'master'. Do not mark entry as uninstalled if uninstallation script failed Summary: As described in the bug report the uninstallation failed, but the service was marked as removed. Now the service gets only marked as uninstalled if the script runs without an error. If there is an error the user gets a popup. Depends on D29101 Test Plan: Set the exit code to 1 and try to install a dolphin plugin. You should get an error message. Without modifying the exit code you should be able to install services. The manual deletion can be tested by removing the installed service file. for example: rm ~/.local/share/kservices5/ServiceMenus/iso_mounter_unmounter.desktop Then the uninstaller will crash: "Failed to remove .desktop file ... No such file or directory" Then you delete the installed file manually: rm ~/.local/share/servicemenu-download/iso_mounter_unmounter.desktop And now you can click the uninstall button and it gets removed from the list of installed services. Reviewers: #knewstuff, meven, ngraham, leinir Reviewed By: #knewstuff, ngraham, leinir Subscribers: leinir, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D29123 M +1-3src/core/engine.cpp M +41 -10 src/core/installation.cpp M +3-3src/core/installation.h https://commits.kde.org/knewstuff/a2ecdd333c492d3e4be5c21301374073784f1b60 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #12 from Patrick Silva --- Thank you Christoph. I have built 20.04 branch of Dolphin, uninstalled services are not immediately removed from "Services" section of Dolphin settings when they are uninstalled. The list of services only is updated when I reopen Dolphin settings, exactly as mentioned in bug 405186 comment 7. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #11 from Christoph Feck --- Patrick, you can check which branches a phabricator commit landed in by clicking on the "Closed by commit" reference, and read the "Branches" details there. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #10 from Alex --- > does 20.04 branch of Dolphin include that fix? It is not in the initial release of 20.04, but on the 20.04 branch. So it will be released with 20.04.1. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #9 from Patrick Silva --- (In reply to Alex from comment #8) > Ah, that is an issue fixed with dolphin https://phabricator.kde.org/D28836. does 20.04 branch of Dolphin include that fix? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #8 from Alex --- Ah, that is an issue fixed with dolphin https://phabricator.kde.org/D28836. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #7 from Patrick Silva --- (In reply to Alex from comment #6) > The (In reply to Patrick Silva from comment #5) > > which frameworks version contains this fix? > 5.70 > > It's still reproducible on Arch after update to frameworks 5.70. > > What you described is most likely caused by the malformed install path from > the previous version. > > If you install it again and then uninstall it it should be removed. I have reproduced even with a newly installed service called Color Folder. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #6 from Alex --- The (In reply to Patrick Silva from comment #5) > which frameworks version contains this fix? 5.70 > It's still reproducible on Arch after update to frameworks 5.70. What you described is most likely caused by the malformed install path from the previous version. If you install it again and then uninstall it it should be removed. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #5 from Patrick Silva --- which frameworks version contains this fix? It's still reproducible on Arch after update to frameworks 5.70. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #4 from Alex --- The uninstallation failing was one issue(fixed now), the entry being marked as installed another: https://phabricator.kde.org/D29123 But I guess marking it as fixed is fine :-). -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Nate Graham changed: What|Removed |Added Version Fixed In||5.70 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://cgit.kde.org/knewst ||uff.git/commit/?id=4c6b3afc ||d80a7b03e0381e2a5c8bb693a8f ||916fd --- Comment #3 from Nate Graham --- Fixed with https://cgit.kde.org/knewstuff.git/commit/?id=4c6b3afcd80a7b03e0381e2a5c8bb693a8f916fd -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Nate Graham changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |alex1701c@gmx.net Status|REPORTED|ASSIGNED CC||n...@kde.org Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 --- Comment #2 from Alex --- https://phabricator.kde.org/D29101 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420312] Dolphin services not being remove after uninstall
https://bugs.kde.org/show_bug.cgi?id=420312 Alex changed: What|Removed |Added CC||alex1701c@gmx.net --- Comment #1 from Alex --- Hello, I can reproduce the issue and will do my best to write a patch. -- You are receiving this mail because: You are watching all bug changes.
