[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added CC||vze1p...@verizon.net --- Comment #20 from Felix Ernst --- *** Bug 465193 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added Version Fixed In||Dolphin 22.12.1 and/or KF ||5.102 Version|unspecified |22.12.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Bug Janitor Service changed: What|Removed |Added Priority|NOR |HI -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Antonio Rojas changed: What|Removed |Added CC||sbjonatha...@hotmail.com --- Comment #19 from Antonio Rojas --- *** Bug 463816 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Antonio Rojas changed: What|Removed |Added CC||jeffrey.ken...@gmail.com --- Comment #18 from Antonio Rojas --- *** Bug 463672 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Antonio Rojas changed: What|Removed |Added CC||michael...@gmail.com --- Comment #17 from Antonio Rojas --- *** Bug 464235 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added CC||jens-bugs.kde.org@spamfreem ||ail.de --- Comment #16 from Felix Ernst --- *** Bug 463351 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added CC||thesource...@gmail.com --- Comment #15 from Felix Ernst --- *** Bug 463579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #14 from Felix Ernst --- This should be fixed in the yet-to-be-released KDE frameworks 5.102 now by Ilya's commit https://invent.kde.org/frameworks/kcoreaddons/-/commit/75241a0929fb9d648c72385471760cfc937ff226. Marking as resolved. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added CC||akb...@gmail.com --- Comment #13 from Felix Ernst --- *** Bug 463095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Ilya Bizyaev changed: What|Removed |Added CC||bizy...@zoho.com --- Comment #12 from Ilya Bizyaev --- I think the actual fix is here? https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/267 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Xavier Corredor Llano changed: What|Removed |Added CC||xavier.corredor.llano@gmail ||.com --- Comment #11 from Xavier Corredor Llano --- First of all, thanks for the quick fix of this bug. Today I almost lost a lot of documents due to this error while moving and overwriting some files in different folders, this bug could be terrible, KDE's users can easily lose their data with this bug, IMHO please consider releasing this patch asap in a new release. Thanks so much. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added Platform|Debian unstable |Compiled Sources Version|22.12.0 |unspecified --- Comment #10 from Felix Ernst --- With above commit, this will be fixed for Dolphin 22.12.1. I didn't revert on master so I hope we will be able to fix this bug in time for the Dolphin 23.04 release. This bug report will be kept open to track that. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 --- Comment #9 from Felix Ernst --- Git commit c8aed8ac81d9f7f3dc93a7570037041228a98bf4 by Felix Ernst. Committed on 14/12/2022 at 12:33. Pushed by felixernst into branch 'release/22.12'. Revert "portalize drag urls" This reverts commit 8d7e600f63a1961294dfe2c278a710b4ce0716e9. While this revert unfortunately removes Dolphin's ability to copy to sandboxed applications, the bugs being temporarily fixed by this seem more important. See the bugs mentioned below for details. Especially copy-pasting needs to work flawlessly for an application like Dolphin. After the revert this will either work correctly or – in the case of sandboxed applications – not at all. Related: bug 457529 M +1-3src/kitemviews/kitemlistcontroller.cpp M +0-1src/panels/folders/treeviewcontextmenu.cpp M +1-4src/views/dolphinview.cpp https://invent.kde.org/system/dolphin/commit/c8aed8ac81d9f7f3dc93a7570037041228a98bf4 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 --- Comment #8 from Felix Ernst --- (In reply to antonio from comment #6) > (In reply to Felix Ernst from comment #5) > > I couldn't reproduce this. > > Would be interesting to know if > > https://invent.kde.org/system/dolphin/-/commit/ > > 8d7e600f63a1961294dfe2c278a710b4ce0716e9 might be the cause of this. That > > commit made it so Dolphin can copy files to sandboxed applications (flatpak, > > snap). For this to work, it had to change what is exported to the clipboard. > > I tried to recompile locally, revert this commit solve the problem. Thanks a lot for testing! This helps quite a bit! (In reply to antonio from comment #7) > I don't know the code, but if you recompile these changes, no problems occur > (and maintain export): Your changes are unfortunately functionally identical to a complete revert of 8d7e600f63a1961294dfe2c278a710b4ce0716e9. We need the same `data` object that was used in `exportUrlsToPortal()` to make its way to the clipboard, otherwise it has no effect and we lose the functionality of copy-pasting into sandboxed applications. Thanks for trying to fix it though! -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928
--- Comment #7 from antonio ---
(In reply to antonio from comment #6)
> (In reply to Felix Ernst from comment #5)
> > I couldn't reproduce this.
> > Would be interesting to know if
> > https://invent.kde.org/system/dolphin/-/commit/
> > 8d7e600f63a1961294dfe2c278a710b4ce0716e9 might be the cause of this. That
> > commit made it so Dolphin can copy files to sandboxed applications (flatpak,
> > snap). For this to work, it had to change what is exported to the clipboard.
>
> I tried to recompile locally, revert this commit solve the problem.
The following changes create the problem:
src/kitemviews/kitemlistcontroller.cpp
src/views/dolphinview.cpp -> create problem
This change instead does not seem to influence:
src/panels/folders/treeviewcontextmenu.cpp -> no problem
---
I don't know the code, but if you recompile these changes, no problems occur
(and maintain export):
src/views/dolphinview.cpp:
void DolphinView::cutSelectedItemsToClipboard()
{
QMimeData* mimeData = selectionMimeData();
KIO::setClipboardDataCut(mimeData, true);
- KUrlMimeData::exportUrlsToPortal(mimeData);
QApplication::clipboard()->setMimeData(mimeData);
+ QMimeData* mimeData2 = selectionMimeData();
+ KUrlMimeData::exportUrlsToPortal(mimeData2);
}
void DolphinView::copySelectedItemsToClipboard()
{
QMimeData *mimeData = selectionMimeData();
- KUrlMimeData::exportUrlsToPortal(mimeData);
QApplication::clipboard()->setMimeData(mimeData);
+ QMimeData* mimeData2 = selectionMimeData();
+ KUrlMimeData::exportUrlsToPortal(mimeData2);
}
src/kitemviews/kitemlistcontroller.cpp:
- KUrlMimeData::exportUrlsToPortal(data);
+ QMimeData *data2 = m_model->createMimeData(selectedItems);
+ KUrlMimeData::exportUrlsToPortal(data2);
if it can help...
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 --- Comment #6 from antonio --- (In reply to Felix Ernst from comment #5) > I couldn't reproduce this. > Would be interesting to know if > https://invent.kde.org/system/dolphin/-/commit/ > 8d7e600f63a1961294dfe2c278a710b4ce0716e9 might be the cause of this. That > commit made it so Dolphin can copy files to sandboxed applications (flatpak, > snap). For this to work, it had to change what is exported to the clipboard. I tried to recompile locally, revert this commit solve the problem. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Felix Ernst changed: What|Removed |Added CC||felixer...@kde.org --- Comment #5 from Felix Ernst --- I couldn't reproduce this. Would be interesting to know if https://invent.kde.org/system/dolphin/-/commit/8d7e600f63a1961294dfe2c278a710b4ce0716e9 might be the cause of this. That commit made it so Dolphin can copy files to sandboxed applications (flatpak, snap). For this to work, it had to change what is exported to the clipboard. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Delta-One changed: What|Removed |Added CC||delta...@debian.org -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Aurélien COUDERC changed: What|Removed |Added CC||couc...@debian.org --- Comment #4 from Aurélien COUDERC --- The same bug was reported on Debian unstable since the 22.12.0 upload : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025943 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 --- Comment #3 from Per Pomsel --- ...same here on Gentoo and Arch. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 Per Pomsel changed: What|Removed |Added CC||phant...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 --- Comment #2 from antonio --- It seems to be a clipboard problem: only the first element is inserted in the clipboard, the next are ignored, so the problem occurs -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 462928] Copying a file after another copies the first file again
https://bugs.kde.org/show_bug.cgi?id=462928 antonio changed: What|Removed |Added CC||antde...@gmail.com --- Comment #1 from antonio --- I confirm this bug. Operating System: Debian GNU/Linux KDE Plasma Version: 5.26.4 KDE Frameworks Version: 5.100.0 Qt Version: 5.15.6 -- You are receiving this mail because: You are watching all bug changes.
